Clean up and fix EA MT4

İş tamamlandı

Tamamlanma süresi: 3 saat

İş Gereklilikleri

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      Yanıtlandı

      1
      Geliştirici 1
      Derecelendirme
      (115)
      Projeler
      129
      18%
      Arabuluculuk
      11
      27% / 55%
      Süresi dolmuş
      4
      3%
      Ücretsiz
      2
      Geliştirici 2
      Derecelendirme
      (43)
      Projeler
      72
      49%
      Arabuluculuk
      4
      0% / 50%
      Süresi dolmuş
      19
      26%
      Ücretsiz
      3
      Geliştirici 3
      Derecelendirme
      (185)
      Projeler
      190
      27%
      Arabuluculuk
      0
      Süresi dolmuş
      3
      2%
      Ücretsiz
      4
      Geliştirici 4
      Derecelendirme
      (126)
      Projeler
      151
      48%
      Arabuluculuk
      6
      83% / 17%
      Süresi dolmuş
      2
      1%
      Ücretsiz
      5
      Geliştirici 5
      Derecelendirme
      (220)
      Projeler
      249
      61%
      Arabuluculuk
      3
      33% / 67%
      Süresi dolmuş
      5
      2%
      Çalışıyor
      6
      Geliştirici 6
      Derecelendirme
      (7)
      Projeler
      12
      42%
      Arabuluculuk
      0
      Süresi dolmuş
      2
      17%
      Ücretsiz
      7
      Geliştirici 7
      Derecelendirme
      (28)
      Projeler
      30
      63%
      Arabuluculuk
      0
      Süresi dolmuş
      4
      13%
      Ücretsiz
      8
      Geliştirici 8
      Derecelendirme
      (261)
      Projeler
      535
      50%
      Arabuluculuk
      54
      41% / 37%
      Süresi dolmuş
      224
      42%
      Çalışıyor
      9
      Geliştirici 9
      Derecelendirme
      (14)
      Projeler
      14
      21%
      Arabuluculuk
      1
      0% / 100%
      Süresi dolmuş
      1
      7%
      Ücretsiz
      10
      Geliştirici 10
      Derecelendirme
      (66)
      Projeler
      143
      34%
      Arabuluculuk
      11
      9% / 55%
      Süresi dolmuş
      26
      18%
      Çalışıyor
      Benzer siparişler
      Hello there, Am looking for an expert in coding mt4, mt5 EA and indicator, am a project manager who help people in getting there strategy or idea been convert to well performance EA or indicator by a professional programmer and developer, so if you are a professional and interested in working with me let talk in the comment so we can build a long business relationship together. THANK YOU
      Hello how are you doing? Can you help me with a projects connecting trend lines to pivot points on a wave, for trendlines, color detention, and dynamic visualization? I have a project I’d like you to look at. I need a pine script code to capture the different Trendline colors that cross both above and below horizontal lines on the wave indicator
      Fixing mt4 ea 30+ USD
      So right now just these! The high and low entry will opposite , so right now the bot opens buy stops at previous candles highs and sell stops at candle lows but I want to change it to entering opposite so at highs it’ll be sell limits and at lows it’ll be buy limits Then a second time filter ( right now i have 1 time filter with start and stop trading time but want to add a second one. RSI filter if oversold sell and
      Hi, I want a custom indicator to be coded based on 2 default Indicators. Add alerts for signals and news filter alerts to be sent through metaquotes id, email and phone. Popup alerts for pc/laptop as well. I would like it to have a display panel that logs the trade history and a buy/sell button with risk % based on balance and equity, fixed lots and some other features
      Unicorn model entry for optimal entry in synthetic indices.. Indicator is only for catching spikes and crashes Please have an experience with boom and crash before applying Demo for quick selection
      Creating a Forex Expert Advisor (EA) or indicator that hedges every candle opening and closing for a buy if bullish or sell bearish with accurate take profit and stop loss, while executing trades automatically every one minute or five minutes for scalping. It must close all the trades open in every candle open for a buy or sell automatically to hegde for next candle tick direction of a buy or sell also also allow
      Whoever did the job for https://www.mql5.com/en/job/215680 I hope it's working well. I'd like this EA and source for MT4, send screenshots of EA settings and UI. I need to copy trades to FTMO dxtrade. I need the developer for that job to respond. He already has the EA
      I need a dominant break indicator for candlestick pattern. A dominant break buy occurs usually at the end of a downtrend there is a large bearing candle and three or more bullish candlestick breaking passed the bearish candle for a new trend to begin https://youtu.be/QH2c8pZNL3A?si=s7AD3tbHzr2qOdQ6 refer to the YouTube video for further clarification
      Hello I have a EA that I want to convert to mt5 and I have Indicator I want to convert as well can anyone help me with this? I dont need any changes to it just a conversion from mql4 to mql5
      Hello, My request is as follows: Write an MT4 robot (EA MT4) that automatically adds indicators and updates values in the indicator's input and then runs that indicator. Do not use chart templates. Do not use auto click. Thank! Exemple: MACD

      Proje bilgisi

      Bütçe
      40+ USD
      KDV (22%): 8.8 USD
      Toplam: 48.8 USD
      Geliştirici için
      36 USD
      Son teslim tarihi
      to 7 gün