Clean up and fix EA MT4

MQL4 Indicateurs Experts

Tâche terminée

Temps d'exécution 3 heures

Spécifications

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      Répondu

      1
      Développeur 1
      Évaluation
      (115)
      Projets
      129
      18%
      Arbitrage
      11
      27% / 55%
      En retard
      4
      3%
      Gratuit
      2
      Développeur 2
      Évaluation
      (43)
      Projets
      72
      49%
      Arbitrage
      4
      0% / 50%
      En retard
      19
      26%
      Gratuit
      3
      Développeur 3
      Évaluation
      (204)
      Projets
      209
      28%
      Arbitrage
      0
      En retard
      3
      1%
      Gratuit
      4
      Développeur 4
      Évaluation
      (126)
      Projets
      151
      48%
      Arbitrage
      6
      83% / 17%
      En retard
      2
      1%
      Gratuit
      5
      Développeur 5
      Évaluation
      (251)
      Projets
      280
      65%
      Arbitrage
      6
      17% / 33%
      En retard
      10
      4%
      Chargé
      6
      Développeur 6
      Évaluation
      (7)
      Projets
      12
      42%
      Arbitrage
      1
      0% / 100%
      En retard
      2
      17%
      Gratuit
      7
      Développeur 7
      Évaluation
      (28)
      Projets
      30
      63%
      Arbitrage
      0
      En retard
      4
      13%
      Gratuit
      8
      Développeur 8
      Évaluation
      (266)
      Projets
      540
      50%
      Arbitrage
      55
      40% / 36%
      En retard
      224
      41%
      Travail
      9
      Développeur 9
      Évaluation
      (14)
      Projets
      14
      21%
      Arbitrage
      1
      0% / 100%
      En retard
      1
      7%
      Gratuit
      10
      Développeur 10
      Évaluation
      (66)
      Projets
      143
      34%
      Arbitrage
      10
      10% / 60%
      En retard
      26
      18%
      Gratuit
      Commandes similaires
      Hello, I’m looking for an experienced MQL5 developer to help integrate cloud-based parameter control for an existing MT5 EA. The goal is to allow EA parameters to be adjusted via a secure web interface. Please reach out via private message for more details and to discuss further
      Hello, How are you doing?. i am Looking for a skilled developer to integrate my broker into MetaTrader 5 (MT5). Currently, my broker is not available on the platform, and I need someone with expertise in creating or adapting broker connections for MT5. The ideal candidate will have a strong understanding of MT5 architecture. If you are proficient at working with APls and have a background in trading platform
      Hello mate .. i am Looking for a skilled developer to integrate my broker into MetaTrader 5 (MT5). Currently, my broker is not available on the platform, and I need someone with expertise in creating or adapting broker connections for MT5. The ideal candidate will have a strong understanding of MT5 architecture. If you are proficient at working with APls and have a background in trading platform integration, please
      Hi developer, I need a EA bot with forex news filtering for USD currency pairs (usdjpy, audUSD,EURUSD, gbpUSD, NZDUSD, USDcad, USDCHF, xauusd). That's no problem if you can share your own profitable ea to me. I don't have any idea about ea strategy. But, I need profit in m30 or other TF. Please share backtest, strategy, how ea works and ea's features
      COETZEE EA BOT 30 - 100 USD
      Hello I am looking for an EA developer that can create for me a bot that trades prop firms accounts and makes at least $500 a day from a $50,000 account balance. This EA should have SL on every trade as mandatory. I do not have any EMAs strategies but I am willing to accept any strategy the developer has to deploy as long as it produces 0.5% a day and is not HFT
      BOT SAFE 30 - 100 USD
      Określ swoje wymagania Specyfikacje tutaj punkt po punkcie. Postaraj się krótko i przejrzyście opisać swoje wymagania, aby Twój potencjalny programista był w stanie prawidłowo ocenić ich złożoność i koszt, a także wymagany czas realizacji. Zły lub zbyt ogólny opis spowoduje, że Twoje zamówienie zostanie zignorowane lub spędzisz dużo czasu negocjując szczegóły z każdym wnioskodawcą. Pamiętaj: Lepiej poświęcić
      I need to make EA (Expert Advisor) and would appreciate it if you could provide your most competitive quote. Please let me know your best price for completing these changes, as I’m looking to get this done promptly and effectively. Thank you
      I need to make several modifications to an EA (Expert Advisor) and would appreciate it if you could provide your most competitive quote for these edits. Please let me know your best price for completing these changes, as I’m looking to get this done promptly and effectively. Thank you
      in this document i have explained the EA requirements in details and given some pictures of needed options . please Grid EA expert apply to my job . and do not come with no experience. https://docs.google.com/document/d/1Y_Vbv87Ep5BQavRxgDlsWT7GH5VjSgVDnm6C1wtVtj0/edit?usp=sharing i can pay 30 USD now but later on if EA get successful . i'll gift with tip of 50 USD after successful month
      All information is detailed in the attached EA diagram. I need a risk management EA build that calculated % amounts based on a snapshot of the starting balance each day, the initial balance and the floating balance. I then need to close positions based on this targets and also disable/enable algo trading. Quite basic ideas. Please see the attached image for all/more details and please let me know what you think/your

      Informations sur le projet

      Budget
      40+ USD
      TVA (22%): 8.8 USD
      Total: 48.8 USD
      Pour le développeur
      36 USD
      Délais
      à 7 jour(s)