Clean up and fix EA MT4

Работа завершена

Время выполнения 3 часа

Техническое задание

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      Откликнулись

      1
      Разработчик 1
      Оценка
      (115)
      Проекты
      129
      18%
      Арбитраж
      11
      27% / 55%
      Просрочено
      4
      3%
      Свободен
      2
      Разработчик 2
      Оценка
      (43)
      Проекты
      72
      49%
      Арбитраж
      4
      0% / 50%
      Просрочено
      19
      26%
      Свободен
      3
      Разработчик 3
      Оценка
      (182)
      Проекты
      186
      27%
      Арбитраж
      0
      Просрочено
      3
      2%
      Свободен
      4
      Разработчик 4
      Оценка
      (126)
      Проекты
      151
      48%
      Арбитраж
      6
      83% / 17%
      Просрочено
      2
      1%
      Свободен
      5
      Разработчик 5
      Оценка
      (220)
      Проекты
      249
      61%
      Арбитраж
      3
      33% / 67%
      Просрочено
      5
      2%
      Работает
      6
      Разработчик 6
      Оценка
      (7)
      Проекты
      12
      42%
      Арбитраж
      0
      Просрочено
      2
      17%
      Свободен
      7
      Разработчик 7
      Оценка
      (28)
      Проекты
      30
      63%
      Арбитраж
      0
      Просрочено
      4
      13%
      Свободен
      8
      Разработчик 8
      Оценка
      (258)
      Проекты
      532
      50%
      Арбитраж
      54
      41% / 37%
      Просрочено
      224
      42%
      Загружен
      9
      Разработчик 9
      Оценка
      (14)
      Проекты
      14
      21%
      Арбитраж
      1
      0% / 100%
      Просрочено
      1
      7%
      Свободен
      10
      Разработчик 10
      Оценка
      (66)
      Проекты
      143
      34%
      Арбитраж
      10
      10% / 60%
      Просрочено
      26
      18%
      Свободен
      Похожие заказы
      Need an EA similar to Patrex pro to execute trades. The strategy is as follows: BUY If EA attached to a 5 min chart and trade direction is set buy, the EA will buy at every bullish candle close and pause buy on any bearish candle close. SELL If EA attached to a 5 min chart and trade direction is set sell, the EA will sell at every bearish candle close and pause sell on any bullish candle close. The EA is timeframe
      i need Create a standalone telegram signals copier EA Similar to Redfox on the market EA will trade received signals from the telegram channel telegram will add the pending / market order i need to g=create a trading groups such as (forex /indices / commodities ..etc. ) i can add a predefined simples to add a prefix this is the basic requirements , remining will be shared later
      preciso de um EA baseado em um indicador simples parecido com bandas de bolinger. O indicador funciona como um canal e quando o preço bater na linha de baixo deve ser feito a compra e vice-versa,ele deve abrir apenas uma ordem por direção,se abrir uma compra a próxima entrada deverá ser uma venda
      Trendline 30+ USD
      inserisce ordine buy quando la chiusura della candela precedente è sopra la retta, sell viceversa. chiude a stoploss chiude in 1 o più volte l'ordine quando guadagna % variabile sul prezzo di ingresso e mette stop a breakeven ogni volta le rette vengono inserite automaticamente al prezzo high/low della candela dell'ultimo fractal confermato. (confermato!! non quando appare)
      Hi, I am looking for a PHP developer who is expert in handling complex script job combined of HTML, MysQL and PHP. It is a pro job Please apply only if you are able to handle all those mentioned and highlighted skill sets. Job description will be provided to selected developer
      I am laying the last hand on my EA and want someone with great experience to check it and add the following features to it: -Magicnumber, custimizable -Account lock, so i can put in a accountnumber and the EA will only work on that specific accountnumber
      hi i will share the file with you it will contain everything u need to know the ea will be tested on the demo and backtester * please explain your understanding of the file once u finish reading it * SMC should be considered * the coder should be fast and accurate * the ea should be functioal on the renko charts also . good luck
      This strategy is going to be based on 3 sets of indicators. Indicator 1: Moving averages. Here we need 2 moving averages. ✓ The 50EMA and, ✓ The 200EMA. - Whenever the red 200EMA is above the blue 50EMA, this gives the idea that the market is bearish (look for sell opportunities) - Whenever the 50EMA is above the 200EMA this gives as the ideas that the market us bullish (look for buy opportunities). Indicator 2
      I need an expert advisor who will provide me with consistent and high profitability. I need the source code for this high-performance robot. the robot must trade on the major forex currency pairs. I want the accuracy to be high and the growth of the account's capital to be exponential. If you have a great expert advisor and want to negotiate, get in touch. thanks. Edit 1: Or an Indicator. Advise your Username on MQL5
      Modify EA 30+ USD
      I would like my EA to be converted into a multi-symbol EA with customizable input via a string, and additionally, to be capable of trading on IC Markets because currently it is not possible as I believe the ctrade module is required. It must have an input for calculating the lot size. It should be in proportion to the balance, meaning what percentage of the balance to open for each new trade

      Информация о проекте

      Бюджет
      40+ USD
      VAT (22%): 8.8 USD
      Итого: 48.8 USD
      Исполнителю
      36 USD
      Сроки выполнения
      до 7 дн.