Clean up and fix EA MT4

MQL4 Indicadores Experts

Trabalho concluído

Tempo de execução 3 horas

Termos de Referência

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      Respondido

      1
      Desenvolvedor 1
      Classificação
      (115)
      Projetos
      129
      18%
      Arbitragem
      11
      27% / 55%
      Expirado
      4
      3%
      Livre
      2
      Desenvolvedor 2
      Classificação
      (43)
      Projetos
      72
      49%
      Arbitragem
      4
      0% / 50%
      Expirado
      19
      26%
      Livre
      3
      Desenvolvedor 3
      Classificação
      (204)
      Projetos
      209
      28%
      Arbitragem
      0
      Expirado
      3
      1%
      Livre
      4
      Desenvolvedor 4
      Classificação
      (126)
      Projetos
      151
      48%
      Arbitragem
      6
      83% / 17%
      Expirado
      2
      1%
      Livre
      5
      Desenvolvedor 5
      Classificação
      (251)
      Projetos
      280
      65%
      Arbitragem
      6
      17% / 33%
      Expirado
      10
      4%
      Carregado
      6
      Desenvolvedor 6
      Classificação
      (7)
      Projetos
      12
      42%
      Arbitragem
      1
      0% / 100%
      Expirado
      2
      17%
      Livre
      7
      Desenvolvedor 7
      Classificação
      (28)
      Projetos
      30
      63%
      Arbitragem
      0
      Expirado
      4
      13%
      Livre
      8
      Desenvolvedor 8
      Classificação
      (266)
      Projetos
      540
      50%
      Arbitragem
      55
      40% / 36%
      Expirado
      224
      41%
      Trabalhando
      9
      Desenvolvedor 9
      Classificação
      (14)
      Projetos
      14
      21%
      Arbitragem
      1
      0% / 100%
      Expirado
      1
      7%
      Livre
      10
      Desenvolvedor 10
      Classificação
      (66)
      Projetos
      143
      34%
      Arbitragem
      10
      10% / 60%
      Expirado
      26
      18%
      Livre
      Pedidos semelhantes
      I HAVE A SQ EA AND IT NEEDS TO RUN WITH 3 SETS WITH DIFFERENT TIME CONFIGURATION. Basically the trade logic will read different input values for the same parameter with the same and/or different timeframes and manage trades accordingly and individually. If it is a trouble, timeframe can be ignored and we can continue only with the parametrization
      I need to make several modifications to an EA (Expert Advisor) and would appreciate it if you could provide your most competitive quote for these edits. Please let me know your best price for completing these changes, as I’m looking to get this done promptly and effectively. Thank you
      hello here am looking for someone that can assist me in removing validation form my demo file and if anyone is interested dm the for more details i will be waiting to get any reply by some on that can assist me with this
      I want a combined Standard deviation channel and Fibonacci channel indicators into just one indicator. The standard deviation channel lines would have same characteristics as the Fibonacci lines in terms of format (adjustable width, colors, type, size etc.). I want unique buffer values for all the lines (for both the 3 upper and 3 lower STD.DEV lines and the same for the Fibonacci channel lines) which would be
      A green point should be added at the Low point of candlesticks in the oversold zone—it is the L point. If there is at least one L point between two H points, search for a LL point in the interval between two H points. The candlestick with the lowest Low price will be the LL point. Generally, the LL point is not necessarily an L point. Search for candlesticks with the lowest Low price. If there is at least one H point
      Trading robots are programs, which operate according to underlying algorithms. An algorithm is a set of actions that need to be performed in response to certain events. For example, the most common task in algo trading is the identification of the "New bar" event. When the event occurs, the robot checks the emergence of trading signals and acts accordingly. Before you decide to program or order a trading robot, you
      RRB 50 - 400 USD
      The overbought zone is determined as candlesticks, at which the indicator value Value > Lmax (Lmax=-20). The oversold zone is determined as candlesticks, at which the indicator value Value < Lmin (Lmin=-80). The values of Lmax and Lmin should be included in indicator parameters. A yellow point should be added at the High point of candlesticks in the overbought zone—it is the H point. A green point should be added at
      At bot 30+ USD
      Help me to trade create orders for me and analyze the markets and decide when is a good time to buy or sell. Determine which pairs are best to use to trade with and indicate trading signals to me
      Fair Value Gap Scanner 30 - 100 USD
      Hi, Greetings. Can somebody revert with an offer to code a FVG Scanner across Forex Pairs / Time Frame Selection / Alert please in order to support a Trading Strategy where entries are considered with the market direction confluence such as a Half Trend / Semafor Indicator. Look forward to hear back. Kind Regards. Anton
      Project Description : I need an experienced programmer to convert the TradingView indicator "CURRENCY STRANGHT CHART by boitoki" into a MetaTrader 5 (MT5) format. The indicator should function identically to the original and be fully compatible for integration into an Expert Advisor (EA) on MT5. Requirements : Convert "TTD Middle Right Normal" from TradingView to a .mq5 file for MT5. Ensure all indicator features and

      Informações sobre o projeto

      Orçamento
      40+ USD
      IVA (22%): 8.8 USD
      Total: 48.8 USD
      Desenvolvedor
      36 USD
      Prazo
      para 7 dias