Clean up and fix EA MT4

MQL4 指标 专家

工作已完成

执行时间3 小时

指定

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      反馈

      1
      开发者 1
      等级
      (115)
      项目
      129
      18%
      仲裁
      11
      27% / 55%
      逾期
      4
      3%
      空闲
      2
      开发者 2
      等级
      (43)
      项目
      72
      49%
      仲裁
      4
      0% / 50%
      逾期
      19
      26%
      空闲
      3
      开发者 3
      等级
      (204)
      项目
      208
      28%
      仲裁
      0
      逾期
      3
      1%
      空闲
      4
      开发者 4
      等级
      (126)
      项目
      151
      48%
      仲裁
      6
      83% / 17%
      逾期
      2
      1%
      空闲
      5
      开发者 5
      等级
      (250)
      项目
      279
      65%
      仲裁
      6
      17% / 33%
      逾期
      10
      4%
      已载入
      6
      开发者 6
      等级
      (7)
      项目
      12
      42%
      仲裁
      1
      0% / 100%
      逾期
      2
      17%
      空闲
      7
      开发者 7
      等级
      (28)
      项目
      30
      63%
      仲裁
      0
      逾期
      4
      13%
      空闲
      8
      开发者 8
      等级
      (266)
      项目
      540
      50%
      仲裁
      55
      40% / 36%
      逾期
      224
      41%
      工作中
      9
      开发者 9
      等级
      (14)
      项目
      14
      21%
      仲裁
      1
      0% / 100%
      逾期
      1
      7%
      空闲
      10
      开发者 10
      等级
      (66)
      项目
      143
      34%
      仲裁
      10
      10% / 60%
      逾期
      26
      18%
      空闲
      相似订单
      I have an equity reporter. This equity reporter displays the maximum and minimum equity reached over a specific interval. So, if the interval is set to 24 hours, the script will generate data in the format: "Profit ATT" (profit AtThatTime) shows max./min. during the specific interval This specific report shows data in pips. It can also be set to display in price or percentages. The interval is also easily adjustable
      I want you to make me an indicator in Training View. Its idea is very simple, and I want it to have an alarm. Here's a clearer step-by-step guide to checking the last 50 candles on your chart and applying Fibonacci retracement levels based on their colors: Identify Candle Color: Start from the 100th candle from the left on the chart and check its color. If the 100th candle is green (i.e., the close is higher than the
      Hello, is it possible to be made accommodation of provided signal for Forex for mt4? I bought a signal for multiple pairs. it is executing all pair.I want to use it on couple of pairs.Is it possible to be made some modifications?I do not have codes for the signal
      I have an MT4 indicator, I want to receive an alert on WhatsApp when the indicator gives a buy or sell signal, I already have an API that will send the message, just send the json with the content, I will pass the API link when I have the proposal: { "symbol": "xauusd", "cellphonenumber": "00000000", "message": "test" }
      KILL MODE 30 - 60 USD
      i Need an expert advisor that trade by signal moving average indictors.it must check and correct the process of possible errors in trading operations. The main criteria of opening and closing positions direction of average moving,price of last bar and set the number of lots to trade as an input parameter
      Creating a chart composed of different assets, weighted by their trading lot size & quantity. Using this chart to trade the assets in those lot sizes &quantity (by hand or with an EA ) In other words: composing a private index or pair, plotting that as a chart and have the ability to trade it directly with an EA and/or one order click. Inspired by Basket Chart Creator
      Hello, I am highly in need of a professional and expert developer who is capable to convert my tradingview indicator to MT5, if you can perfectly do this project kindly meet me at the comment section to proceed
      You must have knowledge of forex tester. Don't bother unless you do The indicator to convert from trading view to FOREX TESTER 5 -- wave trend 3d by JDEHORTY Please note this is a multi time frame indicator. Im not interested in any other wave trend indicator. It has to be a conversion of this indicator. Forex tester conversion https://www.youtube.com/watch?v=S64LjZVr9jE code python
      Craet and indicator which has 15 price source and set a T/F tick for each price source then make Bollinger bands and Rsi with BollingerBands just for true sorces and plot buy and sell signals on main chart based on some conditions and strategy.... i explained every thing clear in the zip file ... theres no need to display those indicators i just need to see their value for testing how indicator works inside chart
      I have one expert advisor. I optimized it and generated 3 optimized set files. As each EA can run only single set file, I need my EA to run with the parametrization from 3 set files at the same time because trade conditions those are defined by the set files are not same

      项目信息

      预算
      40+ USD
      VAT (22%): 8.8 USD
      总计: 48.8 USD
      开发人员
      36 USD
      截止日期
       7 天