Clean up and fix EA MT4

仕事が完了した

実行時間3 時間

指定

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      応答済み

      1
      開発者 1
      評価
      (115)
      プロジェクト
      129
      18%
      仲裁
      11
      27% / 55%
      期限切れ
      4
      3%
      2
      開発者 2
      評価
      (43)
      プロジェクト
      72
      49%
      仲裁
      4
      0% / 50%
      期限切れ
      19
      26%
      3
      開発者 3
      評価
      (204)
      プロジェクト
      208
      28%
      仲裁
      0
      期限切れ
      3
      1%
      仕事中
      4
      開発者 4
      評価
      (126)
      プロジェクト
      151
      48%
      仲裁
      6
      83% / 17%
      期限切れ
      2
      1%
      5
      開発者 5
      評価
      (251)
      プロジェクト
      280
      65%
      仲裁
      6
      17% / 33%
      期限切れ
      10
      4%
      仕事中
      6
      開発者 6
      評価
      (7)
      プロジェクト
      12
      42%
      仲裁
      1
      0% / 100%
      期限切れ
      2
      17%
      7
      開発者 7
      評価
      (28)
      プロジェクト
      30
      63%
      仲裁
      0
      期限切れ
      4
      13%
      8
      開発者 8
      評価
      (266)
      プロジェクト
      540
      50%
      仲裁
      55
      40% / 36%
      期限切れ
      224
      41%
      仕事中
      9
      開発者 9
      評価
      (14)
      プロジェクト
      14
      21%
      仲裁
      1
      0% / 100%
      期限切れ
      1
      7%
      10
      開発者 10
      評価
      (66)
      プロジェクト
      143
      34%
      仲裁
      10
      10% / 60%
      期限切れ
      26
      18%
      類似した注文
      Hello, I am looking for developer who develops me a renko trading robo with following requirement Time :1 sec Box assignment method : Percentage change LTP Source : Close/OHLC Auto Break-even setup option after certain box Trialling Profit Pips after certain box profit with auto Sl set in PIPs Auto open reverse trade after hitting Sl with given conditions . It is very simple trading tool
      At bot 30+ USD
      Help me to trade create orders for me and analyze the markets and decide when is a good time to buy or sell. Determine which pairs are best to use to trade with and indicate trading signals to me
      I currently have a Forex trading script in .txt format that I want to be converted to a functional/working robot (in .mq4), without altering the strategy of the script. The strategy of the script is already in and shouldn't be changed unless with mutual understanding
      Hi, Can you develop the Scalper EA based on Market indicator. EA should open the buy trade at the buy arrow and at every DOT. Close the buy trade with few Pips TP (profit after commission) and SL at opposite Sell arrow. EA should open the SELL trade at the sell arrow and at every DOT. Close the sell trade with few Pips TP (profit after commission) and SL at opposite Buy arrow. Provide the source code at the end
      Hey greetings, It my pleasure to met you . I need a MT4 develop that can develop an EA based on alert . If you are a professional MT4 programmer you can kindly bid for this project and let proceed
      Hello, I want an ( EXPERT ADVISER that can run automated) that will use CCI as the main entry and ATR as the exit. When the CCI is greater than the custom value of 0, you buy and when the CCI is less than the custom value -0, you sell. ATR Exit - profit of 1.0 and exit as .05 (Please, let it be modifiable) The time frame can be 15 or 5 minutes (variable) EMA 20 DAYS OR 480 (can be disabled) Spread should not be more
      Hi, I would like to create an EA similar to this link: https://www.mql5.com/en/market/product/33508?source=External#description Drawdown 5% Scalping! Ability to avoid big price drop that can hurt capital! stable! bid and ask price different is 0.5
      Qwuick Fix 85+ USD
      I need a couple options added to an existing EA. I’m in need of an input option to modify pending orders, ensures live positions are correlated with pending orders, and provide an oversight that EA is running smoothly. I also need a calendar feature added to an existing input option for scheduling trades. This project is a side project to do on your own time with a 3-day window due date on Sunday – Monday by next
      I am looking for an experienced expert to develop an Expert Advisor based on my idea. We can discuss the details in private messages. Please apply only if you are available now, as I need this project completed within one day
      Mt4/mt5 30 - 100 USD
      i need a remote trade copier over internet for mt4 and mt5, i need the open source, its ok also from stratch or if you have someone available please share some screen or other about it

      プロジェクト情報

      予算
      40+ USD
      VAT(付加価値税) (22%): 8.8 USD
      合計: 48.8 USD
      開発者用
      36 USD
      締め切り
      最高 7 日