Clean up and fix EA MT4

MQL4 지표 전문가

작업 종료됨

실행 시간 3 시간

명시

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      응답함

      1
      개발자 1
      등급
      (115)
      프로젝트
      129
      18%
      중재
      11
      27% / 55%
      기한 초과
      4
      3%
      무료
      2
      개발자 2
      등급
      (43)
      프로젝트
      72
      49%
      중재
      4
      0% / 50%
      기한 초과
      19
      26%
      무료
      3
      개발자 3
      등급
      (184)
      프로젝트
      188
      27%
      중재
      0
      기한 초과
      3
      2%
      무료
      4
      개발자 4
      등급
      (126)
      프로젝트
      151
      48%
      중재
      6
      83% / 17%
      기한 초과
      2
      1%
      무료
      5
      개발자 5
      등급
      (220)
      프로젝트
      249
      61%
      중재
      3
      33% / 67%
      기한 초과
      5
      2%
      작업중
      6
      개발자 6
      등급
      (7)
      프로젝트
      12
      42%
      중재
      0
      기한 초과
      2
      17%
      무료
      7
      개발자 7
      등급
      (28)
      프로젝트
      30
      63%
      중재
      0
      기한 초과
      4
      13%
      무료
      8
      개발자 8
      등급
      (259)
      프로젝트
      533
      50%
      중재
      54
      41% / 37%
      기한 초과
      224
      42%
      작업중
      9
      개발자 9
      등급
      (14)
      프로젝트
      14
      21%
      중재
      1
      0% / 100%
      기한 초과
      1
      7%
      무료
      10
      개발자 10
      등급
      (66)
      프로젝트
      143
      34%
      중재
      10
      10% / 60%
      기한 초과
      26
      18%
      작업중
      비슷한 주문
      In search of a dev who can develop an EA that executes buys on Boom and sells on Crash after a Spike. Need to be able to specify TP and SL
      1. Extract all historical economic calendar data. 2. Extract all historical price data for all symbols and all timeframes. 3. Calculate the difference between successive OPEN, HIGH, LOW, and CLOSE prices for each symbol to measure correlation ( https://youtu.be/TytPUU9Y55E?si=hTGn4YBWw786J5QY 1:55-2:20). 4. Assign weights to each symbol based on their correlation with other symbols. 5. Aggregate the data from all
      Hi, I am looking for a developer who will develop for me an EA code/program which will help me to get data from forex factory. The EA code/program meets the following requirements. 1. I currently have an EA that I manually specify specific (High impact) news times where I would want to start analysis (You will see a screenshot in the attached requirement). 2. I developed this EA myself, so I have the source code but
      Please I need a profitable EA with any of the following criteria; Hedge Trading Hedging trades is permitted however, hedging separate accounts against each other (known as Wash Trading) is not permitted and is a direct violation of the OnlyFunds’ Terms and Conditions. Wash trading is illegal and considered to be fraudulent, as it undermines the integrity of financial markets. Swing Trading Swing trading is
      I have an EA that has a nasty drawdown but otherwise is quite profitable. I am looking for a developer who can improve the drawdown by closing or hedging the older open orders. You'll need to supply a demo showing that you've solved this problem rather than just claiming that you can fix it
      dear developers.i want to modify my custom indicator by adding new rules for alerts and arrows,the indicator is based upon some trend following rules and the indicator should be able to send out all types of alerts.i will need demonstration...thank you
      Looking for a developer of profitable EA tested for over 2 or more years time history of profits with investors read me only access as proof of usage. MT4 or MT5
      Adjust MY Hedging EA 30 - 40 USD
      1. Need averaging TP for my hedging EA. (Close both Buy and Sell position with TP) 2. Add function auto/manual entry. (EA will entry based on manual position(placed by trader) or auto trade based on existing setting)
      I have a robot set up that sends trading signals to my telegram group and the group sends trading signals for (28 forex pairs, 3 crypto pairs, 6 commodities, 6 indexes, & 55 stocks) basically almot 100 CFDs and sends out trend price action breakout, impulse, reversal, and exit indications to each one of those CFDs on different timeframes. I want to make it so that a person can sign up and choose which alerts they
      I am in search of a skilled robot developer to craft a Martingale with Hedge strategy algorithm. The ideal candidate will possess deep expertise in algorithmic trading, proficiency in programming languages, and a keen understanding of financial markets. The role entails designing and implementing an automated system capable of effectively executing the Martingale strategy while integrating a hedge mechanism to manage

      프로젝트 정보

      예산
      40+ USD
      VAT (22%): 8.8 USD
      총: 48.8 USD
      개발자에게
      36 USD
      기한
       7 일