Clean up and fix EA MT4

MQL4 Indicatori Esperti

Lavoro terminato

Tempo di esecuzione 3 ore

Specifiche

Hello. I need to clean up the code of an EA. There are some things to delete, some to be remade better and above all, errors to fix.


Errors are two:

1) The EA gives an error in live trading, in backtesting not, but in live it gives sometimes the error "Order failed - Invalid TP/SL",
and when this error happens the order is not opened. Some say that is because the Stoploss and TakeProfit are too small, but I tried increasing them and the issue persist.
The developer should check on his own on M1 timeframe in Live that the error is fixed.

2) Testing with some brokers, in backtest it returns error "OrderSendError 130". This error should be fixed.


Then, regarding deleting parts and remake some parts better, I scrolled down the code and signed the parts to delete and the ones to check to be fixed:

  • From line 77 to 86 in the properties under "Close Order Settings" and the relative parts in the code, should be deleted (down below I state where are these parts.
  • The lines 75, 76 in the properties and the relative function in the code "IsFarEnough()", should be deleted (down below I state where are these parts).
  •  From line 114 to 119 in the properties under "Martingale Settings" and the relative parts in the code that use Martingale, should be deleted (down below I state where are these parts).
  • From line 412 to 417 I think is useless, so it can be deleted, together with the relative parts in the code.
  • At line 450 and 460 I added on my own the functions: (LastActionTime != Time[0]) and isDelayed(), which both together allow the EA to open only one order per candle after the open of the candle (if signal is true),
    and when the order is closed by StopLoss or TakeProfit, the next order is always opened on the next candle if the signal on that candle is true. But these functions are not the best way to do this, so they should be replaced with better code.
    I summarize how it should be: if signal is true, the EA should open only one order per candle, then after some candles the order is closed by Take Profit, then if signal is true on the same candle where order has been closed the EA should NOT open a new order on that candle,
    but it should wait the next candle to open, so if the signal is true the EA should open an order only one time on that new candle...and so on.
  • From 477 to 513 are Alerts, you can delete them, I don't use them.
  • From Line 518 to 530 is CloseByTime() a function to close order that can be deleted, I don't use it.
  • From 532 to 545 is function IsGoodTime, it's the timefilter, this one I use and you should check if there are no errors. And also for function IsFridayEvening(line 550-555) and function IsCloseTime(Line 560-567)
  • From Line 569 to 760 is the main part, it should be checked if there are errors or bugs.
  • From line 823 to 830 is Martingale, delete it.
  • From 832 to 1020 should be checked for errors, it a buggy part: function Normalize Lots at line 905 is not used, but some parts of it are still used, it should be revised, or better deleted.
  • Recovery() at line 1004 I don't know what is...
  • From 1026 to 1086 are the functions that are called at lines 450, 460...as I said they should be replaced with better solution.
  • From line 1090 to the end, delete all.

    As you can see there are more things to delete than to fix. I hope that doing part of the work can speed up yours. I cannot delete them on my own because I'm afraid to delete something that is useful, it's better the developer do that.

    I guess bugs are in the main parts, the ones to send orders or SL, TP, TrailingStop parts...


    I request final mq4 file source code.

    Thanks.

    Regards





      Con risposta

      1
      Sviluppatore 1
      Valutazioni
      (115)
      Progetti
      129
      18%
      Arbitraggio
      11
      27% / 55%
      In ritardo
      4
      3%
      Gratuito
      2
      Sviluppatore 2
      Valutazioni
      (43)
      Progetti
      74
      50%
      Arbitraggio
      5
      0% / 60%
      In ritardo
      19
      26%
      Gratuito
      3
      Sviluppatore 3
      Valutazioni
      (258)
      Progetti
      269
      29%
      Arbitraggio
      2
      50% / 0%
      In ritardo
      3
      1%
      In elaborazione
      Pubblicati: 2 codici
      4
      Sviluppatore 4
      Valutazioni
      (126)
      Progetti
      151
      48%
      Arbitraggio
      6
      83% / 17%
      In ritardo
      2
      1%
      Gratuito
      5
      Sviluppatore 5
      Valutazioni
      (317)
      Progetti
      355
      72%
      Arbitraggio
      7
      43% / 29%
      In ritardo
      20
      6%
      In elaborazione
      6
      Sviluppatore 6
      Valutazioni
      (7)
      Progetti
      12
      42%
      Arbitraggio
      1
      0% / 100%
      In ritardo
      2
      17%
      Gratuito
      7
      Sviluppatore 7
      Valutazioni
      (28)
      Progetti
      30
      63%
      Arbitraggio
      0
      In ritardo
      4
      13%
      Gratuito
      Pubblicati: 1 codice
      8
      Sviluppatore 8
      Valutazioni
      (271)
      Progetti
      553
      50%
      Arbitraggio
      57
      40% / 37%
      In ritardo
      227
      41%
      In elaborazione
      9
      Sviluppatore 9
      Valutazioni
      (14)
      Progetti
      14
      21%
      Arbitraggio
      1
      0% / 100%
      In ritardo
      1
      7%
      Gratuito
      10
      Sviluppatore 10
      Valutazioni
      (69)
      Progetti
      146
      34%
      Arbitraggio
      13
      8% / 62%
      In ritardo
      26
      18%
      Gratuito
      Pubblicati: 6 codici
      Ordini simili
      Create a fully automated MetaTrader 5 (MT5) Expert Advisor (EA) in MQL5 based on the following exact trading strategy. STRATEGY NAME: Previous Day High/Low Daily Breakout Strategy INSTRUMENTS: 1. XAUUSD — fixed lot size: 0.01 2. EURUSD — fixed lot size: 0.10 TIMEZONE: All strategy times must be calculated in Indian Standard Time (IST / UTC+5:30). The broker's server time may be different, so the EA must correctly
      OVERVIEW: I am looking for an experienced MQL developer to build a proprietary Expert Advisor (EA) specifically optimized to PASS evaluation challenges on modern prop firms (specifically targeting The 5%ers execution rules). The EA must rely on momentum and volume expansions, completely avoiding toxic strategies such as Grid, Martingale, or averaging down. Every trade must protect the account's daily drawdown
      Hello here, I need someone who can work on pinescript and also with Renko charts. My entries for my strategy would be based on stop orders Kindly let me know if you can work on this for me and i will send necessary file and quote in the chat
      Trade XAUUSD only Support MT5 Use Buy Stop and Sell Stop pending orders around a configurable breakout range. When the market breaks the range, activate the corresponding trade. Automatically place Stop Loss and Take Profit immediately with every order. Automatically cancel the opposite pending order after one side is triggered. No Martingale No Grid No averaging down No loss recovery system No unlimited position
      Hey guys, I’ve got an MT4 HFT EA that’s showing strong results on an IC Markets demo account, and I'm looking to move it over to MT5. Does anyone have a solid MT5 version that performs well on IC Markets? Having the source code (MQL5) included would be awesome. Thanks for any leads
      Hello! I want to automatically trade on Sierra Charts (IronBeam Brokerage). NQ ($20 per "handle") or MNQ ($2 per point or handle) - futures Broker: IronBeam mostly for the low capital requirement for futures Chart: Sierra Charts I almost exclusively trade a 5-20 bracket with 2 contracts (first contract closes at a +5 and second bracket closes at a +20.) When the +5 is reached, I move my stop from -15 to BE
      Let’s use Chart M3. Stochastic 8,3,3. 85/15 trigger for sell stochastic >85, and the reversal move need to engulf the last bar for 1 point. SL over the engulfed bar. Same trigger for buys… Stochastic <15, engulfed bar by 1 point = entrance. SL under the engulfed bar… more details as soon we start to work on it
      Scalping EA/straddle 30 - 200 USD
      Title: Custom EA: Dynamic Trailing Limit Grid with Volatility/Velocity Filter and Auto SL/TP Description: I am looking for an experienced MQL5 programmer to develop a high-performance, robust Expert Advisor (EA) for MetaTrader 5. The strategy relies on dynamic trailing limit orders that automatically adjust to market price changes, featuring a safety buffer during high-velocity price spikes. The EA must include the
      Freelance Task — EA Recovery Layer Hello. I have a ready-made MQL5 EA. The signals, SL/TP and lot calculation should essentially not be touched. I need a recovery system added. I am not a programmer — below is how the robot should behave. What stays Entry only from an EA signal. Stop-loss is not a new signal. Trailing is already built into my EA — recovery does not implement its own trailing. If trailing is disabled
      Watcher position 30 - 100 USD
      //+------------------------------------------------------------------+ //| synthetic tick generator based on two assets | //+------------------------------------------------------------------+ class CSyntheticTickGenerator { private : string symbol_a; string symbol_b; string synth_name; double ratio; double last_price_a; double

      Informazioni sul progetto

      Budget
      40+ USD
      Scadenze
      a 7 giorno(i)