Errors, bugs, questions - page 1907

[fxsaber]

Compiler optimiser error

#define  TOSTRING(A) #A + " = " + (string)(A)

void OnStart()
{
  color Color1 = (color)ColorToARGB(clrWhite, 0xFF);
  color Color2 = -1;
  
  Print(TOSTRING(Color1 == Color2));   // Color1==Color2 = true
  Print(TOSTRING(Color1 == -1));       // Color1==-1 = false
  Print(TOSTRING((int)Color1 == -1));  // (int)Color1==-1 = true
  Print(TOSTRING((uint)Color1 == -1)); // (uint)Color1==-1 = true
}

[fxsaber]

CPositionInfo::Commission is written incorrectly.

[fxsaber]

Can the condition work?

if (PositionGetInteger(POSITION_TICKET) != PositionGetInteger(POSITION_IDENTIFIER))
        ;

[fxsaber]

When debugging the script, the last move by F11 is to exit OnStart. But after exit from OnStart there are more execution steps - destructors of global objects. As a result, F11 skips them - wrong action.

[fxsaber]

The trading environment GUI when debugging on history (speed slider - maximum) does not correspond to reality

#include <Trade\Trade.mqh>

input int Interval = 3600;
input int AmountLastDeals = 5;
input double Lots = 1;

double CorrectLot( const double Lot )
{
  static const double StepVol = SymbolInfoDouble(_Symbol, SYMBOL_VOLUME_STEP);
  static const double MaxVol = SymbolInfoDouble(_Symbol, SYMBOL_VOLUME_MAX);
  static const double MinVol = SymbolInfoDouble(_Symbol, SYMBOL_VOLUME_MIN);
  
  const double Vol = StepVol * (int)(Lot / StepVol + 0.5);
  
  return((Vol < MinVol) ? MinVol : ((Vol > MaxVol) ? MaxVol : Vol));
}

void OnTick()
{
  static CTrade Trade;
  static CDealInfo Deal;
  static CPositionInfo Position; 

  if (!Position.Select(_Symbol))
  {
    if (HistorySelect(0, TimeCurrent()))
    {
      const int Total = HistoryDealsTotal() - 1;

      double SumProfit = 0;
      double SumLots = 0;

      for (int i = Total, Count = 0; (i >= 0) && (Count < AmountLastDeals); i--)
        if (Deal.SelectByIndex(i) && (Deal.Entry() == DEAL_ENTRY_OUT))
        {        
          SumProfit += Deal.Profit() * (AmountLastDeals - Count) / AmountLastDeals;
          SumLots += Deal.Volume() * (AmountLastDeals - Count) / AmountLastDeals;
          
          Count++;
        }

      if (Total == 2)
      {
        string Str;
        
        for (int i = Total; i >= 0; i--)
          if (Deal.SelectByIndex(i))
            Print(Deal.FormatDeal(Str));
        
        DebugBreak();
      }

      if ((Total >= 0) && Deal.SelectByIndex(Total) && (Deal.DealType() == DEAL_TYPE_SELL))
        Trade.Sell((SumProfit >= 0) ? Lots : CorrectLot(SumLots));
      else
        Trade.Buy((SumProfit >= 0) ? Lots : CorrectLot(SumLots));
    }       
  }
  else if (TimeCurrent() - Position.Time() >= Interval)
    Trade.PositionClose(_Symbol);
}

Log at the moment of DebugBreak

2017.06.07 23:29:03.554 EURUSD : real ticks begin from 2017.04.10 00:00:00
2017.06.07 23:29:03.564 2017.04.10 00:00:00   instant buy 1.00 EURUSD at 1.05918 (1.05885 / 1.05918)
2017.06.07 23:29:03.564 2017.04.10 00:00:00   deal #2 buy 1.00 EURUSD at 1.05918 done (based on order #2)
2017.06.07 23:29:03.564 2017.04.10 00:00:00   deal performed [#2 buy 1.00 EURUSD at 1.05918]
2017.06.07 23:29:03.564 2017.04.10 00:00:00   order performed buy 1.00 at 1.05918 [#2 buy 1.00 EURUSD at 1.05918]
2017.06.07 23:29:03.566 2017.04.10 00:00:00   CTrade::OrderSend: instant buy 1.00 EURUSD at 1.05918 [done at 1.05918]
2017.06.07 23:29:03.569 2017.04.10 01:00:00   instant sell 1.00 EURUSD at 1.05833 (1.05833 / 1.05845 / 1.05831)
2017.06.07 23:29:03.569 2017.04.10 01:00:00   deal #3 sell 1.00 EURUSD at 1.05833 done (based on order #3)
2017.06.07 23:29:03.569 2017.04.10 01:00:00   deal performed [#3 sell 1.00 EURUSD at 1.05833]
2017.06.07 23:29:03.569 2017.04.10 01:00:00   order performed sell 1.00 at 1.05833 [#3 sell 1.00 EURUSD at 1.05833]
2017.06.07 23:29:03.570 2017.04.10 01:00:00   CTrade::OrderSend: instant sell 1.00 EURUSD at 1.05833 [done at 1.05833]
2017.06.07 23:29:03.570 2017.04.10 01:00:00   #3 sell 1.00 EURUSD at 1.05833
2017.06.07 23:29:03.570 2017.04.10 01:00:00   #2 buy 1.00 EURUSD at 1.05918
2017.06.07 23:29:03.570 2017.04.10 01:00:00   CSymbolInfo::CheckMarketWatch: Unknown symbol ''
2017.06.07 23:29:03.570 2017.04.10 01:00:00   #1 balance 100000.00 []

Screenshot

The last transaction in the GUI is not displayed. Reproduced at 1596-1606.

[fxsaber]

Classic error, and the compiler clearly gives the wrong errors

struct STRUCT
{
  string Str;

  void operator =( STRUCT& ) {}

  void operator =( int& ) {}
};

STRUCT Func()
{
  STRUCT Res = {0};
  
  return(Res); // OK

  return(true ? Res : Res); // Неадекватные ошибки компилятора
//  'operator=' - no one of the overloads can be applied to the function call
//  could be one of 2 function(s)
//    void STRUCT::operator=(int&)
//    void STRUCT::operator=(STRUCT&)
//  'operator=' - structure have objects and cannot be copied  
}

[fxsaber]

HistorySelect does not work in the tester

void OnTick()
{
  static bool FirstRun = true;
  
  if (FirstRun)
  {
    if (HistorySelect(TimeCurrent() + 1, TimeCurrent() + 2)) // берем историю заведомо там, где ничего нет
      Print(HistoryDealsTotal()); // 1 - балансовая сделка
    
    FirstRun = false;
  }
}

[fxsaber]

In kodobase, the source files have been given the misleading postfix __X.

For example,TypeToBytes__10.mqh

[Rashid Umarov]

fxsaber:
CPositionInfo::Commission is misspelled.

Which is what?

[fxsaber]

Rashid Umarov:
Which is it?

double CPositionInfo::Commission(void) const
  {
   return(PositionGetDouble(POSITION_COMMISSION));
  }

POSITION_COMMISSION is long overdue.