I'm trying to fix the EA on my 5 digit broker - MQL4 and MetaTrader 4

venox250 2010.11.04 05:50 #401

pmacel:
Hi

Could you please fix suffix problem on version 2.0.1 so it will work on forex.com.

Thanks

It's fixed in 2.1 version. If you need 2.0.1 (which I don't recommend) then compare the sources and do the changes by yourself. It's not that hard.

skoda2008 2010.11.04 09:05 #402

I'm still having a few problems with the EA on my 5 digit broker. It modifies the take profits constantly (every tick) which the broker doesn't like. I have tried looking through the code to figure out what is wrong. I have also noticed I still have to manually multiply the spread by 10 for it to work. As the spread is also taken into account when calculating the TP I think the two are related. SL's do not adjust constantly (and do not invlove the spread in the calculation). I have only just started trying to fault find and haven't been able to track it down yet.

How to Subscribe to Basic Principles - Trading Instant Execution - Opening

skoda2008 2010.11.04 15:36 #403

Yes, the latest version, but also previous versions. The SL's seem to behave, but the TP's adjust every second. Also, if I set the allowable spread to 10 no pairs are available to trade, if I set it to 100 they are all available. The spreads generally range from about 1.2 to 7.5 pips depending on the pair.

Here is a log with 3 trades open:

2010.11.05 00:28:25 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76457 ok

2010.11.05 00:28:24 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01932 ok

2010.11.05 00:28:20 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60609 tp: 1.63626 ok

2010.11.05 00:28:19 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76703 ok

2010.11.05 00:28:18 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60609 tp: 1.63686 ok

2010.11.05 00:28:18 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76457 ok

2010.11.05 00:28:13 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76703 ok

2010.11.05 00:28:10 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76457 ok

2010.11.05 00:28:05 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60609 tp: 1.63846 ok

2010.11.05 00:28:04 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63846 ok

2010.11.05 00:28:04 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63569 ok

2010.11.05 00:28:03 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63659 ok

2010.11.05 00:28:03 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76680 ok

2010.11.05 00:27:47 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63710 ok

2010.11.05 00:27:46 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.02051 ok

2010.11.05 00:27:46 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63770 ok

2010.11.05 00:27:46 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01961 ok

2010.11.05 00:27:45 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63523 ok

2010.11.05 00:27:44 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.02081 ok

2010.11.05 00:27:44 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63613 ok

2010.11.05 00:27:43 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01901 ok

2010.11.05 00:27:42 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.02051 ok

2010.11.05 00:27:41 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63521 ok

2010.11.05 00:27:40 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75982 ok

2010.11.05 00:27:40 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01961 ok

2010.11.05 00:27:32 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63581 ok

2010.11.05 00:27:32 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75751 ok

2010.11.05 00:27:32 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.02051 ok

2010.11.05 00:27:31 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76021 ok

2010.11.05 00:27:30 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63701 ok

2010.11.05 00:27:30 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75827 ok

2010.11.05 00:27:28 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63609 ok

2010.11.05 00:27:27 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75695 ok

2010.11.05 00:27:25 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76184 ok

2010.11.05 00:27:25 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76096 ok

2010.11.05 00:27:24 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63700 ok

2010.11.05 00:27:23 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76192 ok

2010.11.05 00:27:21 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76038 ok

2010.11.05 00:27:18 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76494 ok

2010.11.05 00:27:17 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01991 ok

2010.11.05 00:27:11 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63786 ok

2010.11.05 00:27:11 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76089 ok

2010.11.05 00:27:10 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76368 ok

2010.11.05 00:27:09 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63725 ok

2010.11.05 00:27:08 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63636 ok

2010.11.05 00:27:08 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75813 ok

2010.11.05 00:27:07 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76067 ok

2010.11.05 00:27:06 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63725 ok

2010.11.05 00:27:06 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75851 ok

2010.11.05 00:27:04 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63636 ok

2010.11.05 00:27:02 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63819 ok

2010.11.05 00:27:02 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01931 ok

2010.11.05 00:26:58 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76097 ok

2010.11.05 00:26:57 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.02051 ok

2010.11.05 00:26:56 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76635 ok

2010.11.05 00:26:55 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63763 ok

2010.11.05 00:26:55 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75886 ok

2010.11.05 00:26:54 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01931 ok

2010.11.05 00:26:50 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63588 ok

2010.11.05 00:26:48 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63677 ok

2010.11.05 00:26:48 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.02024 ok

2010.11.05 00:26:47 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63551 ok

2010.11.05 00:26:47 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.75788 ok

2010.11.05 00:26:43 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63761 ok

2010.11.05 00:26:42 !xMeter_v2.1 EURUSD,M15: modify #15467461 sell 0.05 EURNZD at 1.79078 sl: 1.81049 tp: 1.76034 ok

2010.11.05 00:26:42 !xMeter_v2.1 EURUSD,M15: modify #15486686 buy 0.05 AUDUSD at 1.01383 sl: 0.99467 tp: 1.01965 ok

2010.11.05 00:26:37 !xMeter_v2.1 EURUSD,M15: modify #15479730 buy 0.05 GBPUSD at 1.62967 sl: 1.60713 tp: 1.63700 ok

Split Hsplit Custom Financial Instruments -

venox250 2010.11.04 17:03 #404

skoda2008:
Yes, the latest version, but also previous versions. The SL's seem to behave, but the TP's adjust every second. Also, if I set the allowable spread to 10 no pairs are available to trade, if I set it to 100 they are all available. The spreads generally range from about 1.2 to 7.5 pips depending on the pair.

I won't make it without running it on a 5 digit broker... I set up one for myself because I had to see it happen. And it happens.

Here is my analysis: only the display was wrong the EA actually did open positions when the spread was 10 instead of 100. The continous TP movement was due to multiple multiplications (the spread value was multiplied by 10 too which is wrong).

I corrected the display and the calculation. Check this one.

Files:

xmeter_v2.1.1.mq4 70 kb

Parabolic SAR - Trend Error fixing and debugging PositionGetSymbol

venox250 2010.11.04 17:04 #405

skoda2008:
I'm still having a few problems with the EA on my 5 digit broker. It modifies the take profits constantly (every tick) which the broker doesn't like. I have tried looking through the code to figure out what is wrong. I have also noticed I still have to manually multiply the spread by 10 for it to work. As the spread is also taken into account when calculating the TP I think the two are related. SL's do not adjust constantly (and do not invlove the spread in the calculation). I have only just started trying to fault find and haven't been able to track it down yet.

Which version? In version 2.1 the code seems to handle 5 digits well (however I don't use 5 digit brokers).

It does not modify TP and SL that often. TP is modified in 5 pip increments (which is 50 on 5 digit brokers) if it is necessary to modify, SL is modified in 20 pip increments. Also spread is included in SL calculation.

If the bug is in 2.1 then show me a log file please.

-----

Edit: I just found that ManageSell has a bug related to Spread. Original code:

if (sprd <= SpreadLimit) {[/CODE]

should be changed to:

[CODE] if (sprd <= sprdLimit) {

OrderModify PositionModify Generating included code -

fate12 2010.11.04 18:23 #406

Hi Venox25,

Could the above error in the code have something to do with the zero divide error?

I hope so.

Its the only thing that scares me. Today I discovered the EA was frozen almost all day before I noticed

btw, may I state here that

Error fixing and debugging Organizing parallel computing using Empty statement

venox250 2010.11.04 19:22 #407

fate:
Hi Venox25,

Could the above error in the code have something to do with the zero divide error?

I hope so.

Its the only thing that scares me. Today I discovered the EA was frozen almost all day before I noticed

btw, may I state here that

Unfortunately it has nothing to do with the zero divide as far as I can see.

The only thing I can think of could be this (which also explains why I don't have zero divide errors):

as I noticed zero divide occurs when I start xMeter on a 'fresh' account - it happened often with me on demo accounts. This is what I do to avoid them: I switch on every symbol in the market watch window and open each symbol (one at a time but it doesn't matter) and refresh it's H1 history (right click on chart, refresh). This ensures that all sysmbols have sufficient history data. After this I never saw zero divide errors.

So my guess is that insufficient history on some symbol causes the zero divide error. You could also use the history downloader (F2).

Good luck,

MikKi

Error fixing and debugging Migration - Virtual Hosting Financial instruments and Market

neo1001 2010.11.04 20:34 #408

Venox250:

Just wanted to say thank you for your superb work.

neo1001

skoda2008 2010.11.04 23:21 #409

venox250:
I corrected the display and the calculation. Check this one.

Thanks so much, it works great now!

neo1001 2010.11.05 01:18 #410

Just a quick observation...

I haven't really reviewed line per line on the meter calculation, but I think weight should be added for the most liquid pairs, because EURUSD and EURGBP should not be considered as equal... if anything, EURUSD should count as 10 times more weight as it is the determining currency. Based on recent survey, September 2010, EURUSD covers 28% of total Forex volume, while EURGBP only 3%.

Most of the time I think less might actually be better, counting entire 112 pairs may skew the total results... Just my 2 cents.

However, truly wonderful job in coding this EA. I hope I can get around to it and add a weighted calculation in the future.

neo1001

Moving Average - Trend Trade - MetaTrader 5 Moving Average - Trend

New EA based on the !xMeter - page 41