MQL4 Stop loss and Take profit

Mostafa Radwan 2023.08.27 14:26

I have a problem with the below code , I am unable to get SL & TP to be working with the code as orders don't close at specific SL & TP

//+------------------------------------------------------------------+
//|                                               Moving Average.mq4 |
//|                   Copyright 2005-2014, MetaQuotes Software Corp. |
//|                                              http://www.mql4.com |
//+------------------------------------------------------------------+
#property copyright   "2005-2014, MetaQuotes Software Corp."
#property link        "http://www.mql4.com"
#property description "Moving Average sample expert advisor"

#define MAGICMA  20131111
//--- Inputs
input double Lots          =0.01;
input double MaximumRisk   =0.02;
input double DecreaseFactor=3;
input int    MovingPeriod  =100;
input int    MovingShift   =40;
double takeProfit = 40;
double stopLoss = 20;
// Define the Close() function
int Close(int ticket, double lots, double price, int slippage, int type = 0) {
  return OrderClose(ticket, lots, price, slippage, type);
}
//+------------------------------------------------------------------+
//| Calculate open positions                                         |
//+------------------------------------------------------------------+
int CalculateCurrentOrders(string symbol)
  {
   int buys=0,sells=0;
//---
   for(int i=0;i<OrdersTotal();i++)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderSymbol()==Symbol() && OrderMagicNumber()==MAGICMA)
        {
         if(OrderType()==OP_BUY)  buys++;
         if(OrderType()==OP_SELL) sells++;
        }
     }
//--- return orders volume
   if(buys>0) return(buys);
   else       return(-sells);
  }
//+------------------------------------------------------------------+
//| Calculate optimal lot size                                       |
//+------------------------------------------------------------------+
double LotsOptimized()
  {
   double lot=Lots;
   int    orders=HistoryTotal();     // history orders total
   int    losses=0;                  // number of losses orders without a break
//--- select lot size
   lot=NormalizeDouble(AccountFreeMargin()*MaximumRisk/1000.0,1);
//--- calcuulate number of losses orders without a break
   if(DecreaseFactor>0)
     {
      for(int i=orders-1;i>=0;i--)
        {
         if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false)
           {
            Print("Error in history!");
            break;
           }
         if(OrderSymbol()!=Symbol() || OrderType()>OP_SELL)
            continue;
         //---
         if(OrderProfit()>0) break;
         if(OrderProfit()<0) losses++;
        }
      if(losses>1)
         lot=NormalizeDouble(lot-lot*losses/DecreaseFactor,1);
     }
//--- return lot size
   if(lot<0.1) lot=0.1;
   return(lot);
  }
//+------------------------------------------------------------------+
//| Check for open order conditions                                  |
//+------------------------------------------------------------------+
void CheckForOpen()
  {
   double ma;
   int    res;
//--- go trading only for first tiks of new bar
   if(Volume[0]>1) return;
//--- get Moving Average 
   ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
//--- sell conditions
   if(Open[0] >ma && Close[1] <ma) //&& Close[2]<ma
     {
      res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,0,0,"",MAGICMA,0,Red);
      return;
     }
//--- buy conditions
   if(Open[0]<ma && Close[1] >ma) //&& Close[2]>ma
     {
      res=OrderSend(Symbol(),OP_BUY,LotsOptimized(),Ask,3,0,0,"",MAGICMA,0,Blue);
      return;
     }
//---
  }
//+------------------------------------------------------------------+
//| Check for close order conditions                                 |
//+------------------------------------------------------------------+
void CheckForClose()
  {
   double ma;
//--- go trading only for first tiks of new bar
   if(Volume[0]>1) return;
//--- get Moving Average 
   ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
//---
   for(int i=0;i<OrdersTotal();i++)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
      //--- check order type 
      if(OrderType()==OP_BUY)
        {
         if(Open[0]>ma && Close[1]>ma)
           {
            if(!OrderClose(OrderTicket(),OrderLots(),Bid,3,White))
               Print("OrderClose error ",GetLastError());
           }
         break;
        }
      if(OrderType()==OP_SELL)
        {
         if(Open[0]<ma && Close[1]<ma)
           {
            if(!OrderClose(OrderTicket(),OrderLots(),Ask,3,White))
               Print("OrderClose error ",GetLastError());
           }
         break;
        }
     }
//---
  }
//+------------------------------------------------------------------+
//| OnTick function                                                  |
//+------------------------------------------------------------------+  
  void OnTick()
{
  // Check for history and trading
  if (Bars < 100 || IsTradeAllowed() == false)
    return;

  // Calculate open orders by current symbol
  if (CalculateCurrentOrders(Symbol()) == 0)
    CheckForOpen();
  else
    CheckForClose();

  // Check for Take Profit and Stop Loss
  if (OrderType() == OP_BUY) {
    // Check if the current price is higher than the Take Profit level
    if (SymbolInfoInteger(Symbol(), SYMBOL_BID) > takeProfit) {
      // Close the trade at the Take Profit level
      Close(OrderTicket(), OrderLots(), Bid, 3, White);
    }

    // Check if the current price is lower than the Stop Loss level
    if (SymbolInfoInteger(Symbol(), SYMBOL_BID) < stopLoss) {
      // Close the trade at the Stop Loss level
      Close(OrderTicket(), OrderLots(), Bid, 3, White);
    }
  } else if (OrderType() == OP_SELL) {
    // Check if the current price is lower than the Take Profit level
    if (SymbolInfoInteger(Symbol(), SYMBOL_BID) < takeProfit) {
      // Close the trade at the Take Profit level
      Close(OrderTicket(), OrderLots(), Ask, 3, White);
    }

    // Check if the current price is higher than the Stop Loss level
    if (SymbolInfoInteger(Symbol(), SYMBOL_BID) > stopLoss) {
      // Close the trade at the Stop Loss level
      Close(OrderTicket(), OrderLots(), Ask, 3, White);
    }
  }
}
//+------------------------------------------------------------------+

Sergey Golubev 2023.08.27 15:08 #1

Please edit your post to insert your code by using the CODE button (Alt-S)!

Use the CODE button

William Roeder 2023.08.27 15:13 #2

Why did you post your MT4 question in the MT5 General section instead of the MQL4 section, (bottom of the Root page)?
General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
Next time, post in the correct place. The moderators will likely move this thread there soon.
Please edit your (original) post and use the CODE button (or Alt+S)! (For large amounts of code, attach it.)
      General rules and best pratices of the Forum. - General - MQL5 programming forum #25 (2019)
          Messages Editor
      Forum rules and recommendations - General - MQL5 programming forum (2023)
```
 double Balance = AccountBalance();
double Stop_Loss = Balance * Stop_Loss_Percentage / 100;
double Take_Profit = Balance * Take_Profit_Percentage / 100;
double BuyPrice = Ask;
double SellPrice = Bid; 
```
Those are not assignments; they are initialization of a common (globally declared), or static variable(s) with a constant. They work exactly the same way in MT4/MT5/C/C++.
1. They are initialized once on program load.
2. They don't update unless you assign to them.
3. In C/C++ you can only initialize them with constants, and they default to zero. In MTx you should only initialize them with constants. There is no default in MT5, or MT4 with strict (which you should always use).
  
  MT4/MT5 actually compiles with non-constants, but the order that they are initialized is unspecified and Don't try to use any price (or indicator) or server related functions in OnInit (or on load or in OnTimer before you've received a tick), as there may be no connection/chart yet:
  1. Terminal starts.
  2. Indicators/EAs are loaded. Static and globally declared variables are initialized. (Do not depend on a specific order.)
  3. OnInit is called.
  4. For indicators OnCalculate is called with any existing history.
  5. Human may have to enter password, connection to server begins.
  6. New history is received, OnCalculate called again.
  7. A new tick is received, OnCalculate/OnTick is called. Now TickValue, TimeCurrent, account information and prices are valid.
4. Unlike indicators, EAs are not reloaded on chart change, so you must reinitialize them, if necessary.
  external static variable - MQL4 programming forum #2 (2013)
```
   if(Volume[0]>1) return; 
```
For a new bar test, Bars is unreliable (a refresh/reconnect can change number of bars on chart), volume is unreliable (miss ticks), Price is unreliable (duplicate prices and The == operand. - MQL4 programming forum.) Always use time.
          MT4: New candle - MQL4 programming forum #3 (2014)
          MT5: Accessing variables - MQL4 programming forum #3 (2022)

I disagree with making a new bar function, because it can only be called once per tick (second call returns false). A variable can be tested multiple times.
          Running EA once at the start of each bar - MQL4 programming forum (2011)
```
    for(int i=0;i<OrdersTotal();i++)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break; 
```
In the presence of multiple orders (one EA multiple charts, multiple EAs, manual trading), while you are waiting for the current operation (closing, deleting, modifying) to complete, any number of other operations on other orders could have concurrently happened and changed the position indexing and order count:
1. For non-FIFO (non-US brokers), (or the EA only opens one order per symbol), you can simply count down, in an index loop, and you won't miss orders. Get in the habit of always counting down.
  Loops and Closing or Deleting Orders - MQL4 programming forum
2. For In First Out (FIFO rules — US brokers), and you (potentially) process multiple orders per symbol, you must find the earliest order (count up), close it, and on a successful operation, reprocess all positions (from zero).
  CloseOrders by FIFO Rules - Strategy Tester - MQL4 programming forum - Page 2 #16
  MetaTrader 5 platform beta build 2155: MQL5 scope, global Strategy Tester and built-in Virtual Hosting updates - Best Expert Advisors - General - MQL5 programming forum #1.11
and check OrderSelect in case other positions were deleted.
What are Function return values ? How do I use them ? - MQL4 programming forum
Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles

and if you (potentially) process multiple orders, must call RefreshRates() after server calls if you want to use, on the next order / server call, the Predefined Variables (Bid/Ask.) Or instead, be direction independent and just use OrderClosePrice().
```
    if (SymbolInfoInteger(Symbol(), SYMBOL_BID) < takeProfit) {
```
Do you see SYMBOL_BID listed under SymbolInfoInteger? Symbol Properties - Environment State - Constants, Enumerations and Structures - MQL4 Reference

Multiple moving average cross select trading time and Please help. While I

Mostafa Radwan 2023.08.27 19:13 #3

Sergey Golubev #:

Please edit your post to insert your code by using the CODE button (Alt-S)!

Done , sorry I am new here and it's all kinda confusing for me :)

New comment