CExpertBase::SetPriceSeries: Changing of timeseries is forbidden, but will it work in trading? - General

roman epifanov 2012.02.22 10:51 #1041

uncleVic:
A little more detail... What is the next line (or better several) in the log?

2012.02.22 12:51:15 st (EURUSD,H1) CExpertBase::SetOtherSeries: changing of timeseries is forbidden
2012.02.22 12:51:15 st (EURUSD,H1) CExpertBase::SetPriceSeries: changing of timeseries is forbidden

nothing else

Victor Kirillin 2012.02.22 10:55 #1042

openlive:

2012.02.22 12:51:15 st (EURUSD,H1) CExpertBase::SetOtherSeries: changing of timeseries is forbidden
2012.02.22 12:51:15 st (EURUSD,H1) CExpertBase::SetPriceSeries: changing of timeseries is forbidden

nothing else

I have found an old module somewhere. Please attach the code of Expert Advisor you got in Wizard. It is not secret, is it?

roman epifanov 2012.02.22 11:04 #1043

uncleVic:
There is an old-style module somewhere. Please attach the EA code obtained in the Wizard. It's not secret, is it?

//+------------------------------------------------------------------+
//|                                               Expert_Candles.mq5 |
//|                        Copyright 2010, MetaQuotes Software Corp. |
//|                                              http://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2010, MetaQuotes Software Corp."
#property link      "http://www.mql5.com"
#property version   "1.00"
//+------------------------------------------------------------------+
//| Include                                                          |
//+------------------------------------------------------------------+
#include <Expert\Expert.mqh>
#include <Expert\Signal\SignalCandles.mqh>
#include <Expert\Trailing\TrailingNone.mqh>
#include <Expert\Money\MoneyFixedLot.mqh>
//+------------------------------------------------------------------+
//| Inputs                                                           |
//+------------------------------------------------------------------+
//--- inputs for expert
input string Inp_Expert_Title              ="Expert_Candles";
int          Expert_MagicNumber            =28148;
bool         Expert_EveryTick              =false;
//--- inputs for signal
input int    Inp_Signal_Candles_Range      =3;
input int    Inp_Signal_Candles_Minimum    =50;
input double Inp_Signal_Candles_ShadowBig  =0.5;
input double Inp_Signal_Candles_ShadowSmall=0.2;
input double Inp_Signal_Candles_Limit      =0.0;
input double Inp_Signal_Candles_StopLoss   =2.0;
input double Inp_Signal_Candles_TakeProfit =1.0;
input int    Inp_Signal_Candles_Expiration =4;
//--- inputs for money
input double Inp_Money_FixLot_Percent      =10.0;
input double Inp_Money_FixLot_Lots         =0.1;
//+------------------------------------------------------------------+
//| Global expert object                                             |
//+------------------------------------------------------------------+
CExpert ExtExpert;
//+------------------------------------------------------------------+
//| Initialization function of the expert                            |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- Initializing expert
   if(!ExtExpert.Init(Symbol(),Period(),Expert_EveryTick,Expert_MagicNumber))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing expert");
      ExtExpert.Deinit();
      return(-1);
     }
//--- Creation of signal object
   CSignalCandles *signal=new CSignalCandles;
   if(signal==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating signal");
      ExtExpert.Deinit();
      return(-2);
     }
//--- Add signal to expert (will be deleted automatically))
   if(!ExtExpert.InitSignal(signal))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing signal");
      ExtExpert.Deinit();
      return(-3);
     }
//--- Set signal parameters
   signal.Range(Inp_Signal_Candles_Range);
   signal.Minimum(Inp_Signal_Candles_Minimum);
   signal.ShadowBig(Inp_Signal_Candles_ShadowBig);
   signal.ShadowSmall(Inp_Signal_Candles_ShadowSmall);
   signal.Limit(Inp_Signal_Candles_Limit);
   signal.StopLoss(Inp_Signal_Candles_StopLoss);
   signal.TakeProfit(Inp_Signal_Candles_TakeProfit);
   signal.Expiration(Inp_Signal_Candles_Expiration);
//--- Check signal parameters
   if(!signal.ValidationSettings())
     {
      //--- failed
      printf(__FUNCTION__+": error signal parameters");
      ExtExpert.Deinit();
      return(-4);
     }
//--- Creation of trailing object
   CTrailingNone *trailing=new CTrailingNone;
   if(trailing==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating trailing");
      ExtExpert.Deinit();
      return(-5);
     }
//--- Add trailing to expert (will be deleted automatically))
   if(!ExtExpert.InitTrailing(trailing))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing trailing");
      ExtExpert.Deinit();
      return(-6);
     }
//--- Set trailing parameters
//--- Check trailing parameters
   if(!trailing.ValidationSettings())
     {
      //--- failed
      printf(__FUNCTION__+": error trailing parameters");
      ExtExpert.Deinit();
      return(-7);
     }
//--- Creation of money object
   CMoneyFixedLot *money=new CMoneyFixedLot;
   if(money==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating money");
      ExtExpert.Deinit();
      return(-8);
     }
//--- Add money to expert (will be deleted automatically))
   if(!ExtExpert.InitMoney(money))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing money");
      ExtExpert.Deinit();
      return(-9);
     }
//--- Set money parameters
   money.Percent(Inp_Money_FixLot_Percent);
   money.Lots(Inp_Money_FixLot_Lots);
//--- Check money parameters
   if(!money.ValidationSettings())
     {
      //--- failed
      printf(__FUNCTION__+": error money parameters");
      ExtExpert.Deinit();
      return(-10);
     }
//--- Tuning of all necessary indicators
   if(!ExtExpert.InitIndicators())
     {
      //--- failed
      printf(__FUNCTION__+": error initializing indicators");
      ExtExpert.Deinit();
      return(-11);
     }
//--- ok
   return(0);
  }
//+------------------------------------------------------------------+
//| Deinitialization function of the expert                          |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
   ExtExpert.Deinit();
  }
//+------------------------------------------------------------------+
//| Function-event handler "tick"                                    |
//+------------------------------------------------------------------+
void OnTick()
  {
   ExtExpert.OnTick();
  }
//+------------------------------------------------------------------+
//| Function-event handler "trade"                                   |
//+------------------------------------------------------------------+
void OnTrade()
  {
   ExtExpert.OnTrade();
  }
//+------------------------------------------------------------------+
//| Function-event handler "timer"                                   |
//+------------------------------------------------------------------+
void OnTimer()
  {
   ExtExpert.OnTimer();
  }
//+------------------------------------------------------------------+

[Deleted] 2012.02.22 11:38 #1044

mql5:

Thank you, if I may ask a quick question - is it acceptable for two processes to read from the same site?

Victor Kirillin 2012.02.22 11:43 #1045

openlive:

Strange that this code compiles at all.

#include <Expert\Signal\SignalCandles.mqh> - это старый модуль

PS The file could have just been attached.

roman epifanov 2012.02.22 11:52 #1046

uncleVic:
Strange that this code compiles at all.

PS The file could have just been attached.

The thing is, the tester works fine with it... but will it work in trading?

as i understand there is no new module? then what should i do in this one, if it's not difficult

Victor Kirillin 2012.02.22 11:58 #1047

openlive:

The thing is, the tester works fine with it... but will it work in trading?

as i understand there is no new module? then what do i have to do in this one, if it's not difficult

It will work. You have to insert it in the method CSignalCandles::ValidationSettings(), at the very beginning:

//--- call of the method of the parent class
   if(!CExpertSignal::ValidationSettings()) return(false);

roman epifanov 2012.02.22 12:15 #1048

uncleVic:

It will work. To avoid it, insert it in CSignalCandles::ValidationSettings() method, at the very beginning:

bool CSignalCandles::ValidationSettings()
{
if(!CExpertSignal::ValidationSettings()) return(false);

if(m_range<=0)
{
printf(__FUNCTION__+": candles range must be greater than 0");
return(false);
}
//--- ok
return(true);
}

so it's already there.

Ilyas 2012.02.22 12:36 #1049

220Volt:
Thank you, if I may ask a quick question - is it acceptable for two processes to read from the same area?

Yes, there are no problems when reading.

Victor Kirillin 2012.02.22 13:49 #1050

openlive:

it's already here.

Task... Please attach signal module (I don't have one). Let's have a look.

Questions from a "dummy" - page 105