Contest - page 14

Sergey Golubev
Moderator
111284
Sergey Golubev  
newdigital:
Please find fixed version of GridMACD.

Statements for GridMACD EA.

EA is on post #33.

Files:
gridmacd.htm 210 kb
gridmacd.gif 6 kb
Sergey Golubev
Moderator
111284
Sergey Golubev  
newdigital:
PriceCross

-------------------

Settings: Default.

TF: 1H

Pairs:

"EURUSD","USDCHF","GBPUSD","EURJPY"

MaChannel

-------------------

Settings: Default.

TF: 1H

Pairs:

"EURUSD","EURGBP","GBPUSD"

MaChannel EA is performing very good:

Totally from the beginning of July: +1693 pips.

https://www.mql5.com/en/forum/173383/page52

Links to files' thread to download https://www.mql5.com/en/forum/176044

Files:
Ahmed Soliman
22009
Ahmed Soliman  

That's GREAT! But the version you have has a little bug! I don't know how it made profit!

for(cnt=0;cnt<total;cnt++)

{

OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

if(OrderType()<=OP_SELL && OrderSymbol()==Symbol())

{

if(OrderType()==OP_BUY) //<-- Long position is opened

{

if(UseClose)

{

if(CloseBuyCondition) //<-- Close the order and exit!

{

CloseOrder(OrderType()); return(0);

}

}

TrailOrder(OrderType()); return(0); //<-- Trailling the order

}

if(OrderType()==OP_SELL) //<-- Go to short position

{

if(UseClose)

{

if(CloseSellCondition) //<-- Close the order and exit!

{

CloseOrder(OP_SELL); return(0);

}

}

TrailOrder(OrderType()); return(0); //<-- Trailling the order

}

}

}[/PHP]

It should be:

[PHP]for(cnt=0;cnt<total;cnt++)

{

OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

if(OrderType()<=OP_SELL && OrderSymbol()==Symbol())

{

if(OrderType()==OP_BUY) //<-- Long position is opened

{

if(UseClose)

{

if(CloseBuyCondition) //<-- Close the order and exit!

{

CloseOrder(OrderType());

}

}

TrailOrder(OrderType()); //<-- Trailling the order

}

if(OrderType()==OP_SELL) //<-- Go to short position

{

if(UseClose)

{

if(CloseSellCondition) //<-- Close the order and exit!

{

CloseOrder(OP_SELL);

}

}

TrailOrder(OrderType()); //<-- Trailling the order

}

}

}

Attached the fixed version!

newdigital:
MaChannel EA is performing very good:

Totally from the beginning of July: +1693 pips.

https://www.mql5.com/en/forum/173383/page52

Links to files' thread to download https://www.mql5.com/en/forum/176044
Files:
machannel.mq4 12 kb
Sergey Golubev
Moderator
111284
Sergey Golubev  

Thanks for fixed version.

BTW the old vesion is having very good performance and no any problems at all (and no any errors in log file): everything is take/profit'ing, stop/loss'ing and trailing.

Ahmed Soliman
22009
Ahmed Soliman  
newdigital:
Thanks for fixed version. BTW the old vesion is having very good performance and no any problems at all (and no any errors in log file): everything is take/profit'ing, stop/loss'ing and trailing.

Thanks newdigital,

Observe this line:

if(OrderType()==OP_BUY)//<-- Long position is opened{

...........TrailOrder(OrderType()); return(0); <-- This line <---

The line above terminate the start function and that mean no trailing to the Sell orders! Maybe the EA looks good but logically it'll better with this fix.

by the way, is there any news about the contest??

Sergey Golubev
Moderator
111284
Sergey Golubev  
codersguru:
Thanks newdigital,

Observe this line:

if(OrderType()==OP_BUY)//<-- Long position is opened{

...........TrailOrder(OrderType()); return(0); <-- This line <---

The line above terminate the start function and that mean no trailing to the Sell orders! Maybe the EA looks good but logically it'll better with this fix.

by the way, is there any news about the contest??

Contest/

Not yet, sorry.

BTW please find the performance of MaChannel EA in excel file.

Files:
Sergey Golubev
Moderator
111284
Sergey Golubev  

GridMACD:

Equity now: 51,810; margin: 601; free margin: 51,213.

What is equity?

It is all close and open trades (balance + open trades).

GridMACD is here (fixed version).. Explanation about this EA/settings. GridMACD with trailing stop version development thread.

Ahmed Soliman
22009
Ahmed Soliman  

Contest news

ND,

Any new out there about the contest resuming?

The contest was a very good opportunity to make the MQL programmer publish their new Expert Advisors and this is WIN-WIN situation for all of the eilte members.

Sergey Golubev
Moderator
111284
Sergey Golubev  

Not yet.

BTW, your MAChannel is performing very good for USDCHF with North Finance broker.

Ahmed Soliman
22009
Ahmed Soliman  
newdigital:
BTW, your MAChannel is performing very good for USDCHF with North Finance broker.

Do you think it will perform good in live trading? Is it risky? I'm asking you because you know it more than me (I only developed the EA and even forgot what was the idea behinde it ).