Discussion of article "The checks a trading robot must pass before publication in the Market" - page 2

You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Thank you, the article is very useful.
I am not very clear in the subtopic "Limiting the number of lots by one symbol" the code of the PositionVolume() function is given twice.
Just below is the description of the NewOrderAllowedVolume() function and its call:
double orders_volume_on_symbol=PendingsVolume(symbol);
Only the description of the PendingsVolume() function is nowhere to be seen in the article.
If instead of PendingsVolume() function the PositionVolume() function is given again by mistake, please correct it.
That's an interesting article, unfortunately there are too much errors (typo or even logical errors in the proposed code), and it will probably confuse more people than help them at some points.
1°
Logical error. If there is no position yet, you still have to check the pendings volume and calculate allowed volume. This code returns allowed_volume=0 if there is no position already opened without taking pendings into account.
2°
An other logical error. Changing a SL/TP by 1 point is allowed. It should be >=
+ typo error, should be "-tp)>=point);"
+ missing parameter (PrintFormat has for %, but only 3 parameters are provided).
3°
Similar error as point 2° above.
And same errors also in OrderModifyCheck() mql4 version.
Thanks for fixing these errors, please note I didn't check all the article in depth, so maybe there is more.
Some other comments about this article, but not related to errors this time, but more on my personal opinion :
Access violation
This error occurs when trying to address memory, the access to which is denied. In each such case, it is necessary to contact the developers via the Service Desk in your Profile or via the Contacts page.This type of errors is relatively rare, many of them have ready codes, that are designed to help in finding the cause.
Newcomers are recommended to read all the articles about error handling, as well as ask questions on the forum and in the article comments. Other more experienced members of the MQL5.community will help you figure out any unclear points. We hope that the information gathered in the article will help you create more reliable trading robots and in a shorter time.
Despite the critics, I would like to thank Metaquotes for their great work on MT4/MT5, and encourage them to continue to increase their level of quality and professionalism.
This is the part that raises questions:
Why is required margin compared to Equity and not FreeMargin?
http://prntscr.com/dgd6s4
now what's wrong?
checks the margin, no enough money, does not trade, but does not let you raise the owl.
Did you try it? Or did you just say that?
I tried it! I got a message that it was not verified, not a single trade opened! Well, it won't open if it's an assistant.
If it is a utility, moderators check the EA personally.
The utility can be set up for the tester to open at least a couple of trades and accompany them as an assistant. It's not a problem.
If it is a utility, moderators check the EA personally.
The utility can be set up for the tester to open at least a couple of trades and accompany them as an assistant. That's not a problem.
I mean, do you want to make it as a panel? And check it that way? Or what?
just open any trade manually at the moment and attach this EA to the chart to the ticket of the open order.