Помогите. Советник не подключается Custom индикатор

Авторизуйтесь или зарегистрируйтесь, чтобы добавить комментарий
Roman Meskhidze
604
Roman Meskhidze  

Коллеги, здравствуйте,

Есть два кастомных индикатора. Вызываю для теста в советники оба и один загружается, а второй нет (в журнале видно какой загрузился).

2019.08.17 13:39:42.335 2018.12.03 00:00:00  Custom indicator 2line_MACD GBPUSD,M15: loaded successfully

А вот второй индикатор такого сообщения не выдаёт.

При этом после остановки тестера видно, что тот который не загружается все верно выводит на график свои данные.

Вот индикатор:

#define INDICATOR_NAME       "123PatternsV6"

#property indicator_chart_window
#property indicator_buffers 8
#property indicator_color1  DodgerBlue   // UpperLine
#property indicator_color2  OrangeRed    // LowerLine
#property indicator_color3  LimeGreen    // Target1
#property indicator_color4  LimeGreen    // Target2
#property indicator_color5  DodgerBlue   // BuyArrow
#property indicator_color6  OrangeRed    // SellArrow
#property indicator_color7  DodgerBlue   // BullDot
#property indicator_color8  OrangeRed    // BearDot
#property indicator_width1  1
#property indicator_width2  1
#property indicator_width3  1
#property indicator_width4  1
#property indicator_width5  3  // BuyArrow
#property indicator_width6  3  // SellArrow
#property indicator_width7  3  // BullDot
#property indicator_width8  3  // BearDot

// extern string Notes           = "Pattern";
extern int    ZigZagDepth     = 12;
extern double RetraceDepthMin = 0.4;
extern double RetraceDepthMax = 1.0;
  bool   ShowAllLines    = True;
  bool   ShowAllBreaks   = False;
  bool   ShowTargets     = False;
  double Target1Multiply = 1.5;
  double Target2Multiply = 3.0;
  bool   HideTransitions = True;

// indicator buffers
double UpperLine[];
double LowerLine[];
double Target1[];
double Target2[];
double BuyArrow[];
double SellArrow[];
double BullDot[];
double BearDot[];

double   firsthigh, firstlow, lasthigh, lastlow, prevhigh, prevlow, signalprice, brokenline;
datetime firsthightime, firstlowtime, lasthightime, lastlowtime, prevhightime, prevlowtime, signaltime;
datetime redrawtime;  // remember when the indicator was redrawn

int     signal;
#define NOSIG   0
#define BUYSIG  1
#define SELLSIG 2

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
   for(int i=0; i<=7; i++) SetIndexEmptyValue(i,EMPTY_VALUE);
   if(ShowAllLines == True) SetIndexStyle(0,DRAW_LINE); else SetIndexStyle(0,DRAW_NONE);
   if(ShowAllLines == True) SetIndexStyle(1,DRAW_LINE); else SetIndexStyle(1,DRAW_NONE);
   if(ShowTargets == True) SetIndexStyle(2,DRAW_LINE); else SetIndexStyle(2,DRAW_NONE);
   if(ShowTargets == True) SetIndexStyle(3,DRAW_LINE); else SetIndexStyle(3,DRAW_NONE);
   SetIndexStyle(4,DRAW_ARROW); SetIndexArrow(4,SYMBOL_ARROWUP);
   SetIndexStyle(5,DRAW_ARROW); SetIndexArrow(5,SYMBOL_ARROWDOWN);
   SetIndexStyle(6,DRAW_ARROW); SetIndexArrow(6,159); // BullDot (WingDings character)
   SetIndexStyle(7,DRAW_ARROW); SetIndexArrow(7,159); // BearDot (WingDings character)
   SetIndexBuffer(0,UpperLine);
   SetIndexBuffer(1,LowerLine);
   SetIndexBuffer(2,Target1);
   SetIndexBuffer(3,Target2);
   SetIndexBuffer(4,BuyArrow);
   SetIndexBuffer(5,SellArrow);
   SetIndexBuffer(6,BullDot);
   SetIndexBuffer(7,BearDot);
   IndicatorShortName(INDICATOR_NAME);
   IndicatorDigits(Digits);
   if(ShowAllLines == True) SetIndexLabel(0,"UpperLine"); else SetIndexLabel(0,"");
   if(ShowAllLines == True) SetIndexLabel(1,"LowerLine"); else SetIndexLabel(1,"");
   if(ShowTargets == True) SetIndexLabel(2,"Target1"); else SetIndexLabel(2,"");
   if(ShowTargets == True) SetIndexLabel(3,"Target2"); else SetIndexLabel(3,"");
   SetIndexLabel(4,"BuyArrow");
   SetIndexLabel(5,"SellArrow");
   SetIndexLabel(6,"");
   SetIndexLabel(7,"");
   
   // cleanup display buffers
   for(i=0; i<1440; i++)
      {
      UpperLine[i] = EMPTY_VALUE;
      LowerLine[i] = EMPTY_VALUE;
      Target1[i] = EMPTY_VALUE;
      Target2[i] = EMPTY_VALUE;
      BuyArrow[i] = EMPTY_VALUE;
      SellArrow[i] = EMPTY_VALUE;
      BullDot[i] = EMPTY_VALUE;
      BearDot[i] = EMPTY_VALUE;
      }
   
      return(0);   
} // end of init()


//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
// REDRAW ONLY ONE TIME PER CANDLE
if(redrawtime == Time[0])  return(0); // if already redrawn on this candle then do no more
else redrawtime = Time[0];                              // remember when the indicator was redrawn

double   zigzag, range, retracedepth, one, two, three;
datetime onetime, twotime, threetime;
int      shift = 1440;
while(shift >= 0)
   {
   // UPPERLINES and LOWERLINES based on ZIGZAG
   UpperLine[shift] = UpperLine[shift+1];
   LowerLine[shift] = LowerLine[shift+1];
   Target1[shift] = Target1[shift+1];
   Target2[shift] = Target2[shift+1];
   //BuyArrow[shift] = EMPTY_VALUE;
   //SellArrow[shift] = EMPTY_VALUE;
   BullDot[shift] = EMPTY_VALUE;
   BearDot[shift] = EMPTY_VALUE;
   zigzag = iCustom(NULL,0,"ZigZag",ZigZagDepth,5,3,0,shift);
   if(zigzag == High[shift])
      {
      UpperLine[shift] = High[shift];
      firsthigh = prevhigh; firsthightime = prevhightime;
      prevhigh = lasthigh;  prevhightime = lasthightime;
      lasthigh = zigzag;    lasthightime = Time[shift];
      }
   if(zigzag == Low[shift])
      {
      LowerLine[shift] = Low[shift];
      firstlow = prevlow; firstlowtime = prevlowtime;
      prevlow = lastlow;  prevlowtime = lastlowtime;
      lastlow = zigzag;   lastlowtime = Time[shift];
      }

   ///////////////////////////
   // BULLISH BREAK ABOVE #2
   one = prevlow; onetime = prevlowtime;
   two = lasthigh; twotime = lasthightime; if(twotime == Time[shift]){two = prevhigh; twotime = prevhightime;}
   three = lastlow; threetime = lastlowtime;
   if(one - two != 0) retracedepth = (three - two) / (one - two);  // retrace depth
   // signal rules
   if(shift > 0)
   if(retracedepth > RetraceDepthMin)                  // minimum retrace depth for 123 pattern
   if(retracedepth < RetraceDepthMax)                  // maximum retrace depth for 123 pattern
   if(brokenline != UpperLine[shift])                  // if this line has not already been broken
   if(Low[shift] < UpperLine[shift])                   // low of rangebar is below the line
   if(Close[shift] > UpperLine[shift])                 // close of rangebar body is above the line (break)
      {
      range = MathAbs(two - three);                    // range is the distance between two and three
      Target1[shift] = two+(range*Target1Multiply);
      Target2[shift] = two+(range*Target2Multiply);
      BuyArrow[shift] = Low[shift]-(High[shift]-Low[shift])/3;
      BullDot[iBarShift(NULL,0,onetime)] = one;        // ONE
      BullDot[iBarShift(NULL,0,twotime)] = two;        // TWO
      BullDot[iBarShift(NULL,0,threetime)] = three;    // THREE
      signal = BUYSIG;
      signaltime = Time[shift];
      signalprice = BuyArrow[shift];
      brokenline = UpperLine[shift];
      }

   /////////////////////////////////////////////
   // BULLISH BREAK OF UPPERLINE (NOT 123 SETUP)
   // signal rules
   if(shift > 0)
   if(ShowAllBreaks == True)
   if(brokenline != UpperLine[shift])                  // if this line has not already been broken
   if(Low[shift] < UpperLine[shift])                   // low of rangebar is below the line
   if(Close[shift] > UpperLine[shift])                 // close of rangebar body is above the line (break)
      {
      range = UpperLine[shift]-LowerLine[shift];
      Target1[shift] = UpperLine[shift]+(range*Target1Multiply);
      Target2[shift] = UpperLine[shift]+(range*Target2Multiply);
      BuyArrow[shift] = Low[shift]-(High[shift]-Low[shift])/3;
      signal = BUYSIG;
      signaltime = Time[shift];
      signalprice = BuyArrow[shift];
      brokenline = UpperLine[shift];
      }

   ///////////////////////////
   // BEARISH BREAK BELOW #2
   one = prevhigh; onetime = prevhightime;
   two = lastlow; twotime = lastlowtime; if(twotime == Time[shift]){two = prevlow; twotime = prevlowtime;}
   three = lasthigh; threetime = lasthightime;
   if(one - two != 0) retracedepth = (three - two) / (one - two);  // retrace depth
   // signal rules
   if(shift > 0)
   if(retracedepth > RetraceDepthMin)                  // minimum retrace depth for 123 pattern
   if(retracedepth < RetraceDepthMax)                  // maximum retrace depth for 123 pattern
   if(brokenline != LowerLine[shift])                  // if this line has not already been broken
   if(High[shift] > LowerLine[shift])                  // high of rangebar is above the line
   if(Close[shift] < LowerLine[shift])                 // close of rangebar is below the line (break)
      {
      range = MathAbs(two - three);                    // range is the distance between two and three
      Target1[shift] = two-(range*Target1Multiply);
      Target2[shift] = two-(range*Target2Multiply);
      SellArrow[shift] = High[shift]+(High[shift]-Low[shift])/3;
      BearDot[iBarShift(NULL,0,onetime)] = one;        // ONE
      BearDot[iBarShift(NULL,0,twotime)] = two;        // TWO
      BearDot[iBarShift(NULL,0,threetime)] = three;    // THREE
      signal = SELLSIG;
      signaltime = Time[shift];
      signalprice = SellArrow[shift];
      brokenline = LowerLine[shift];
      }

   /////////////////////////////////////////////
   // BEARISH BREAK OF LOWERLINE (NOT 123 SETUP)
   // signal rules
   if(shift > 0)
   if(ShowAllBreaks == True)
   if(brokenline != LowerLine[shift])                  // if this line has not already been broken
   if(High[shift] > LowerLine[shift])                  // high of rangebar is above the line
   if(Close[shift] < LowerLine[shift])                 // close of rangebar is below the line (break)
      {
      range = UpperLine[shift]-LowerLine[shift];
      Target1[shift] = LowerLine[shift]-(range*Target1Multiply);
      Target2[shift] = LowerLine[shift]-(range*Target2Multiply);
      SellArrow[shift] = High[shift]+(High[shift]-Low[shift])/3; 
      signal = SELLSIG;
      signaltime = Time[shift];
      signalprice = SellArrow[shift];
      brokenline = LowerLine[shift];
      }

   // TARGET LINE RULES
   if(signal == BUYSIG)
      {
      if(Low[shift] > Target1[shift]) Target1[shift] = EMPTY_VALUE;
      if(Low[shift] > Target2[shift]) Target2[shift] = EMPTY_VALUE;
      }
   if(signal == SELLSIG)
      {
      if(High[shift] < Target1[shift]) Target1[shift] = EMPTY_VALUE;
      if(High[shift] < Target2[shift]) Target2[shift] = EMPTY_VALUE;
      }

   // HIDE LINE TRANSITIONS
   if(HideTransitions == True)
      {
      if(UpperLine[shift] != UpperLine[shift+1]) UpperLine[shift+1] = EMPTY_VALUE;
      if(LowerLine[shift] != LowerLine[shift+1]) LowerLine[shift+1] = EMPTY_VALUE;
      if(Target1[shift] != Target1[shift+1]) Target1[shift+1] = EMPTY_VALUE;
      if(Target2[shift] != Target2[shift+1]) Target2[shift+1] = EMPTY_VALUE;
      }

   shift--; // move ahead one candle
   }

   return(0);
}// end of start()

//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
 
   return(0);  
}// end of deinit()

А вот код вызовы который использую:

   buyArrow =  iCustom(Symbol(), PERIOD_CURRENT, "Pattern", ZigZagDepth, RetraceDepthMin, RetraceDepthMax, 4, 1);      
   Alert(DoubleToString(buyArrow, Digits));      
         
   sellArrow =  iCustom(Symbol(), PERIOD_CURRENT, "Pattern", ZigZagDepth, RetraceDepthMin, RetraceDepthMax, 5, 1);     
   Alert(DoubleToString(sellArrow, Digits));

Пытаюсь получить из буфера когда индикатор дает стрелку-сигнал и узнать её цену.

Но всегда получаю в журнале:

2019.08.17 13:39:42.449 2018.12.03 00:00:00  smartmoney_1 GBPUSD,M15: Alert: 2147483647.00000

2019.08.17 13:39:42.449 2018.12.03 00:00:00  smartmoney_1 GBPUSD,M15: Alert: 2147483647.00000


Помогите разобраться, что не так делаю?

Спасибо.


Evgeniy Zhdan
16734
Evgeniy Zhdan  
Roman Meskhidze:


2019.08.17 13:39:42.449 2018.12.03 00:00:00  smartmoney_1 GBPUSD,M15: Alert: 2147483647.00000

2019.08.17 13:39:42.449 2018.12.03 00:00:00  smartmoney_1 GBPUSD,M15: Alert: 2147483647.00000

Помогите разобраться, что не так делаю?

Спасибо.


Здравствуйте, коллега.

Ну правильно все получается, алерты срабатывают у Вас, коллега, на каждом тике. Если значение, как у Вас - 2147483647.00000,

то стрелки нет.

Надо так:

if(sellArrow < 50000000) Alert("Стрелка на селл");
if(buyArrow < 50000000) Alert("Стрелка на бай");
Renat Akhtyamov
16178
Renat Akhtyamov  

2147483647 - это число, которое равно EMPTY_VALUE

то есть, если

if(buyArrow!=EMPTY_VALUE) Alert("Стрелка на бай");
Roman Meskhidze
604
Roman Meskhidze  

сработал вариант  if(sellArrow < 50000000)

а что думаете о проблеме, что не загружается custom индикатор, как я писал тут:

вызываю для теста в советнике оба и один загружается, а второй нет (в журнале видно какой загрузился).

2019.08.17 13:39:42.335 2018.12.03 00:00:00  Custom indicator 2line_MACD GBPUSD,M15: loaded successfully

А вот второй индикатор такого сообщения не выдаёт.

Авторизуйтесь или зарегистрируйтесь, чтобы добавить комментарий