Can Check The Codes to See Why This EA Doesn't Work?

New comment
 

Hi all, need some help here. 

I used ChatGPT to create an EA for me. It looks good but there are error 131 when I tried testing it with strategy Tester. 

Apprantely my OrderSend command is wrong. Can someone look through the codes and let me know what is missing? 

I am not a coder so if you can enlighten me with th right codes that would be great. 

Thanks in advance. 


//+------------------------------------------------------------------+

//| Expert initialization function                                   |

//+------------------------------------------------------------------+

int OnInit()

  {

   // Initialization code

   return(INIT_SUCCEEDED);

  }

//+------------------------------------------------------------------+

//| Expert deinitialization function                                 |

//+------------------------------------------------------------------+

void OnDeinit(const int reason)

  {

   // Cleanup code

  }

//+------------------------------------------------------------------+

//| Expert tick function                                             |

//+------------------------------------------------------------------+

void OnTick()

  {

   // Parameters

   double fastEMA = iMA(NULL, 0, 20, 0, MODE_EMA, PRICE_CLOSE, 0);

   double slowEMA = iMA(NULL, 0, 400, 0, MODE_EMA, PRICE_CLOSE, 0);

   double macdHist = iMACD(NULL, 0, 26, 100, 9, PRICE_CLOSE, MODE_SIGNAL, 0) - iMACD(NULL, 0, 26, 100, 9, PRICE_CLOSE, MODE_MAIN, 0);

   double atr = iATR(NULL, 0, 14, 0);

   

   // Calculate lot size based on 0.5% risk

   double riskPerTrade = 0.005;

   double accountBalance = AccountBalance();

   double lotSize = NormalizeDouble(accountBalance * riskPerTrade / (2 * atr * Point), 2);

   

   // Check for Long entry

   if (fastEMA > slowEMA && macdHist > 0)

     {

      if (OrderSelect(0, SELECT_BY_POS) == false || OrderType() != OP_BUY)

        {

         double stopLossLong = Bid - 2 * atr;

         double takeProfitLong = Bid + 6 * atr;

         OrderSend(Symbol(), OP_BUY, lotSize, Ask, 3, stopLossLong, takeProfitLong, "Buy Order", 0, 0, Green);

        }

     }

   

   // Check for Short entry

   if (fastEMA < slowEMA && macdHist < 0)

     {

      if (OrderSelect(0, SELECT_BY_POS) == false || OrderType() != OP_SELL)

        {

         double stopLossShort = Ask + 2 * atr;

         double takeProfitShort = Ask - 6 * atr;

         OrderSend(Symbol(), OP_SELL, lotSize, Bid, 3, stopLossShort, takeProfitShort, "Sell Order", 0, 0, Red);

        }

     }

  }

//+------------------------------------------------------------------+

 
Chatgpt... You won't do anything good with the ai
 
  1. fated82: I used ChatGPT

    Stop using ChatGPT/Copilot.
              Help needed to debug and fix an AI EA - Trading Systems - MQL5 programming forum #2 (2023)

    ChatGPT (the worst), “Bots Builder”, “EA builder”, “EA Builder Pro”, EATree, “Etasoft forex generator”, “Forex Strategy Builder”, ForexEAdvisor (aka. ForexEAdvisor STRATEGY BUILDER, and Online Forex Expert Advisor Generator), ForexRobotAcademy.com, forexsb, “FX EA Builder”, fxDreema, Forex Generator, FxPro, “LP-MOBI”, Molanis, “Octa-FX Meta Editor”, Strategy Builder FX, “Strategy Quant”, “Visual Trader Studio”, “MQL5 Wizard”, etc., are all the same. You will get something quick, but then you will spend a much longer time trying to get it right, than if you learned the language up front, and then just wrote it.

    Since you haven't learned MQL4/5, therefor there is no common language for us to communicate. If we tell you what you need, you can't code it. If we give you the code, you don't know how to integrate it into yours.

    We are willing to HELP you when you post your attempt (using Code button) and state the nature of your problem, but we are not going to debug your hundreds of lines of code. You are essentially going to be on your own.

    ChatGPT
    1. Even it says do not use it for coding. * 
    2. Mixing MT4 and MT5 code together.
    3. Creating multiple OnCalculate/OnTick functions.
    4. OnCalculate returning a double.
    5. Filling buffers with zero in OnInit (they have no size yet). Setting buffer elements to zero but not setting Empty Value to correspond.
    6. Calling undefined functions.
    7. Calling MT4 functions in MT5 code.
    8. Sometimes, not using strict (MT4 code).
    9. Code that will not compile.
    10. Creating code outside of functions. * 
    11. Creating incomplete code. * 
    12. Initialization of Global variables with non-constants. * 
    13. Assigning a MT5 handle to a double or missing the buffer and bar indexes in a MT4 call. * 
    14. Useing MT4 Trade Functions without first selecting an order. * 
    15. Uses NULL in OrderSend. * 
    bot builder Creating two OnInit() functions. * 
    EA builder
    1. Counting up while closing multiple orders.
    2. Not useing time in new bar detection.
    3. Not adjusting for 4/5 digit brokers, TP/SL and slippage. * 
    4. Not checking return codes.
    EATree Uses objects on chart to save values — not persistent storage (files or GV+Flush.) No recovery (crash/power failure.)
    ForexEAdvisor
    1. Non-updateing global variables.
    2. Compilation errors.
    3. Not checking return codes.
    4. Not reporting errors.
    FX EA Builder
    1. Not checking return codes.
    2. Loosing open tickets on terminal restart. No recovery (crash/power failure.)
    3. Not adjusting stops for the spread. * 
    4. Using OrdersTotal directly.
    5. Using the old event handlers.
    		 
  2.    double fastEMA = iMA(NULL, 0, 20, 0, MODE_EMA, PRICE_CLOSE, 0);

   double slowEMA = iMA(NULL, 0, 400, 0, MODE_EMA, PRICE_CLOSE, 0);

    Why did you post your MT4 question in the MT5 General section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. I have moved this thread.

  3. Check your return codes, and report your errors (including market prices and your variables). Don't look at GLE/LE unless you have an error. Don't just silence the compiler (MT5 / MT4+strict), it is trying to help you.
              What are Function return values ? How do I use them ? - MQL4 programming forum (2012)
              Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles (2014)

 

Hi

Chat GPT is not the best for coding yet as was mentioned above.
But regarding the problem only – 131 is the error with wrong lot size – so here you have wrong value of lot.  Here atr value was used wrong – ATR return decimal values- so you should rather divide by point (not multiple). But here you should also include the tick value and tick size to calculate lot properly and I would also recommend using some function to normalize lot value (by step and min/max allowed lot size – normalization to 2 decimal places is not enough. Try something like this:

double lotSize = normalizeLots(AccountBalance() * 0.001 / (2*atr * MarketInfo(Symbol(), MODE_TICKVALUE)/MarketInfo(Symbol(), MODE_TICKSIZE)));

double NormalizeLots(double lots){
   
    double  lotStep     = MarketInfo(Symbol(), MODE_LOTSTEP);
    lots  = MathRound(lots/ls) * ls;
    double  minLot      = MarketInfo(Symbol(), MODE_MINLOT);
    double  maxLot      = MarketInfo(Symbol(), MODE_MAXLOT);
    if (lots < minLot) lots = minLot;
    if(lots>maxLot) lots=maxLot;
    return(lots);
}
Best Regards
 
When hearing that you use ChatGPT, i understand - I learned by using it.
BUT I have a coding background. I understand design overview, logic flow, on-tick, subroutines, calls, handles, variables, condtitional and if/else statements.....

And ChatGPT can spew out some really nice looking code, sometimes it even compiles - but it is a talking machine, not a thinking one. It does not and cannot think ahead of you and go "I should make sure that my lot-size is the minimum allowable by the broker", for instance.
You "COULD" ask it what the error means instead of asking it to fix the error
then once you understand the error, you "Could" ask it if there is a function or call that solves that error....

ChatGPT is an awesome tool for understanding code syntax, but you still have to know how to code 'something' before taking something like this on, because it's still kinda 'stupid'.

ChatGPT is a good TRANSLATOR (think literal word-for-word) but a near useless "INTERPRETER" (think adapting what's said to be culturally appropriate)
what I mean is in America "what do you do for a job?" is a valid conversation point - in the Netherlands, translated literally SAYS the same thing, but asking that question is like a sarcastic way of saying "You're broke, useless and can't get a real job". An interpreter would rephrase the question to "what is the field you've chosen to work in at the moment?" This is a limitation of ChatGPT.


Without a solid understanding of how to code in the first place, you're going to have a rough time.
New comment