Need Help in Plotting 6 legs of Indicators - Beginner

Aryan Singh 2023.06.09 04:45

I need help in one of my project that is in MT5 using MQL5 language. I have started learning MQL5 recently. So, basic summary of task is; I need a custom indicator that incorporates 2 other standard indicators. For example, take the range of the SMA50H & SMA50L, and add/substract the SMA50Range to the SMA14Mid, plot it as an indicator on the chart.

Further Clarification:
Build a custom indicator that uses 2 other standard indicators, and then plots them
on a chart.
MT5
Variables;
BandHigh=SMA.High.14Bars (the number of bars should be defineable as a
parameter)
BandLow=SMA.Low.14Bars (the number of bars should be defineable as a
parameter)
BandRange=BandHigh-BandLow
Custom Indicator;
"TNJK ExtensionBands"

"CI-H3"=((BandRange3)+SMA.High.14Bars). Plot as RedColour
"CI-H2"=((BandRange2)+SMA.High.14Bars). Plot as OrangeColour
"CI-H1"=((BandRange1)+SMA.High.14Bars). Plot as YellowColour
"CI-L1"=((BandRange1)-SMA.Low.14Bars). Plot as YellowColour
"CI-L2"=((BandRange2)-SMA.Low.14Bars). Plot as OrangeColour
"CI-L3"=((BandRange3)-SMA.Low.14Bars). Plot as RedColour
The number of bars in each leg of the indicator should be defineable as a
parameter.
The SMA price point (High, Low, Mid, Weighted) in each leg of the indicators

BandRange =(SMA.14.High-SMA.14.Low), and BandRange1 =(SMA.14.High-
SMA.14.Low)+SMA.14.High, BandRange2 =((SMA.14.High-
SMA.14.Low)*2)+SMA.14.High,BandRange3 =((SMA.14.High-
SMA.14.Low)*3)+SMA.14.High

For the above requirement I have written the code for calculating the BandRange and SMA's but facing diffculty in plotting those 6 legs. Can anyone help me with that also some reading material that would help in long run. Below is my code:

#property indicator_chart_window
#property indicator_buffers 6
#property indicator_color1 clrRed
#property indicator_color2 clrOrange
#property indicator_color3 clrYellow
#property indicator_type1 DRAW_LINE
#property indicator_width1 5
// Define input parameters
input ENUM_APPLIED_PRICE price = PRICE_HIGH;
input int MA_Period = 14;
// ...
input int  bars_CI_H3 = 14;
input ENUM_APPLIED_PRICE price_CI_H3 = PRICE_HIGH;
input int  bars_CI_H2 = 14;
input ENUM_APPLIED_PRICE price_CI_H2 = PRICE_HIGH;
input int  bars_CI_H1 = 14;
input ENUM_APPLIED_PRICE price_CI_H1 = PRICE_HIGH;
//input Custom Low indicators
input int  bars_CI_L1 = 14;
input ENUM_APPLIED_PRICE price_CI_L1 = PRICE_LOW;
input int  bars_CI_L2 = 14;
input ENUM_APPLIED_PRICE price_CI_L2 = PRICE_LOW;
input int  bars_CI_L3 = 14;
input ENUM_APPLIED_PRICE price_CI_L3 = PRICE_LOW;
double CI_H3Buffer[];
double CI_H2Buffer[];
double CI_H1Buffer[];
double CI_L1Buffer[];
double CI_L2Buffer[];
double CI_L3Buffer[];
int OnInit()
{
      SetIndexBuffer(0, CI_H3Buffer, INDICATOR_DATA);
      SetIndexBuffer(1, CI_H2Buffer, INDICATOR_DATA);
      SetIndexBuffer(2, CI_H1Buffer, INDICATOR_DATA);
      SetIndexBuffer(3, CI_L1Buffer, INDICATOR_DATA);
      SetIndexBuffer(4, CI_L2Buffer, INDICATOR_DATA);
      SetIndexBuffer(5, CI_L3Buffer, INDICATOR_DATA);
      
      IndicatorSetString(INDICATOR_SHORTNAME, "TNJK ExtensionBands");
      
    
    return(INIT_SUCCEEDED);
}
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[]){
                
      
    int limit = rates_total - prev_calculated;
    ArrayResize(CI_H3Buffer, limit);
    ArrayResize(CI_H2Buffer, limit);
    ArrayResize(CI_H1Buffer, limit);
    ArrayResize(CI_L1Buffer, limit);
    ArrayResize(CI_L2Buffer, limit);
    ArrayResize(CI_L3Buffer, limit);
    
    double SMA14HBuffer[];
    double SMA14LBuffer[];
    ArrayResize(SMA14HBuffer, limit);
    ArrayResize(SMA14LBuffer, limit);
    
    int handleSMA14H = iMA(NULL, 0, MA_Period, 0, MODE_SMA, PRICE_HIGH);
    int handleSMA14L = iMA(NULL, 0, MA_Period, 0, MODE_SMA, PRICE_LOW);
    
    CopyBuffer(handleSMA14H, 0, 0, limit, SMA14HBuffer);
    CopyBuffer(handleSMA14L, 0, 0, limit, SMA14LBuffer);
    double SMA14RangeBuffer[];
    ArrayResize(SMA14RangeBuffer, limit);
    for (int i = 0; i < limit; i++) {
        SMA14RangeBuffer[i] = SMA14HBuffer[i] - SMA14LBuffer[i];
    }
    
    //input Custom High indicators
    
    
    
    for (int i = 0; i < limit; i++) {
      CI_H3Buffer[i] = (SMA14RangeBuffer[i] * 3) + iMA(NULL, 0, bars_CI_H3, 0, MODE_SMA, price_CI_H3);
      CI_H2Buffer[i] = (SMA14RangeBuffer[i] * 2) + iMA(NULL, 0, bars_CI_H2, 0, MODE_SMA, price_CI_H2);
      CI_H1Buffer[i] = SMA14RangeBuffer[i] + iMA(NULL, 0, bars_CI_H1, 0, MODE_SMA, price_CI_H1);
      CI_L1Buffer[i] = SMA14RangeBuffer[i] - iMA(NULL, 0, bars_CI_L1, 0, MODE_SMA, price_CI_L1);
      CI_L2Buffer[i] = (SMA14RangeBuffer[i]*2) - iMA(NULL, 0, bars_CI_L2, 0, MODE_SMA, price_CI_L2);
      CI_L3Buffer[i] = (SMA14RangeBuffer[i]*3) - iMA(NULL, 0, bars_CI_L3, 0, MODE_SMA, price_CI_L3);
   }
   // This plotIndicator function is my testing on how to plot you can ignore that
   /*PlotIndicator(limit, CI_H3Buffer, "CI_H3", clrRed);
   PlotIndicator(limit, CI_H2Buffer, "CI_H2", clrOrange);
   PlotIndicator(limit, CI_H1Buffer, "CI_H1", clrYellow);*/
   
   
   return rates_total;
}
/*void PlotIndicator(int limit, double &buffer[], string name, color linecolor)
{
    for (int i = 0; i < limit; i++) {
        
        PlotIndexSetInteger(0, PLOT_DRAW_TYPE, i, DRAW_LINE);
        PlotIndexSetInteger(0, PLOT_LINE_WIDTH, i, 1);
        PlotIndexSetString(0, PLOT_LABEL, name);
        PlotIndexSetInteger(0, PLOT_LINE_COLOR, i, linecolor);
        PlotIndexSetInteger(0, PLOT_LINE_STYLE, i, STYLE_SOLID);
    
   
    }
}*/

Carl Schreiber 2023.06.09 05:15 #1

Here is an example that plots 60 indicator lines use it an an example to set the initial part of your indicator: https://www.mql5.com/en/code/13031

Rainbow

www.mql5.com

Sixty Moving Averages with gradually changing period on a single chart.

Aryan Singh 2023.06.09 05:42 #2

Carl Schreiber #:
Here is an example that plots 60 indicator lines use it an an example to set the initial part of your indicator: https://www.mql5.com/en/code/13031

code is broken in that article can you see if my code meet the requirement and how to plot

William Roeder 2023.06.09 12:08 #3

int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[]){
   ⋮
    int handleSMA14H = iMA(NULL, 0, MA_Period, 0, MODE_SMA, PRICE_HIGH);
    int handleSMA14L = iMA(NULL, 0, MA_Period, 0, MODE_SMA, PRICE_LOW);

Perhaps you should read the manual, especially the examples.
   How To Ask Questions The Smart Way. (2004)
      How To Interpret Answers.
         RTFM and STFW: How To Tell You've Seriously Screwed Up.

They all (including iCustom) return a handle (an int). You get that in OnInit. In OnTick/OnCalculate (after the indicator has updated its buffers), you use the handle, shift and count to get the data.
          Technical Indicators - Reference on algorithmic/automated trading language for MetaTrader 5
          Timeseries and Indicators Access / CopyBuffer - Reference on algorithmic/automated trading language for MetaTrader 5
          How to start with MQL5 - General - MQL5 programming forum - Page 3 #22 (2020)
          How to start with MQL5 - MetaTrader 5 - General - MQL5 programming forum - Page 7 #61 (2020)
          MQL5 for Newbies: Guide to Using Technical Indicators in Expert Advisors - MQL5 Articles (2010)
          How to call indicators in MQL5 - MQL5 Articles (2010)

IMA indicator value of RSI EA iMA function handle returns

Fernando Carreiro 2023.06.09 12:09 #4

Your topic has been moved to the section: Technical Indicators — In the future, please consider which section is most appropriate for your query.

Aryan Singh 2023.06.09 13:02 #5

William Roeder #:

Can you checkout my code and tell me how to fix it also getting time out in 5sec for my private messages

Aryan Singh 2023.06.09 13:11 #6

Fernando Carreiro #:
Your topic has been moved to the section: Technical Indicators — In the future, please consider which section is most appropriate for your query.

Why I'm getting timeout in 5 sec for my private messages

Fernando Carreiro 2023.06.09 13:11 #7

Aryan Singh #: Can you checkout my code and tell me how to fix it

If you are here to learn, then follow up on the links in order to improve your coding skills.

If you are only here to have your code fixed for you, then please hire someone in the Freelance section to fix it for you.

Fernando Carreiro 2023.06.09 13:12 #8

Aryan Singh #: Why I'm getting timeout in 5 sec for my private messages

Read the following ... Messages Timed out Error

William Roeder 2023.06.09 13:42 #9

Aryan Singh #: Can you checkout my code and tell me how to fix it also getting time out in 5sec for my private messages

I already did. What part of “You get that in OnInit” was unclear? Did you move the creation of your handles there?

      CI_H3Buffer[i] = (SMA14RangeBuffer[i] * 3) + iMA(NULL, 0, bars_CI_H3, 0, MODE_SMA, price_CI_H3);

That is not a value. What part of "you use the handle, shift and count" was unclear?

Mixture of MT4 and MT5 code. Stop using ChatGPT.
Help needed to debug and fix an AI EA - Trading Systems - MQL5 programming forum #2 (2023)

If you don't learn MQL4/5, there is no common language for us to communicate. If we tell you what you need, you can't code it. If we give you the code, you don't know how to integrate it into your code.

'{' - function definition How to fix unexpected Help with error on

Aryan Singh 2023.06.12 10:20 #10

William Roeder #:

I already did. What part of “You get that in OnInit” was unclear? Did you move the creation of your handles there?
That is not a value. What part of "you use the handle, shift and count" was unclear?
Mixture of MT4 and MT5 code. Stop using ChatGPT.
Help needed to debug and fix an AI EA - Trading Systems - MQL5 programming forum #2 (2023)

If you don't learn MQL4/5, there is no common language for us to communicate. If we tell you what you need, you can't code it. If we give you the code, you don't know how to integrate it into your code.

oh, then how can I add another iMA with userinput period and Enum applied price to BandRange

1 2

New comment