The code executes without errors and handles error codes correctly.

Andrey Kaunov 2020.07.26 11:52 #81

Corrected the code and ran it in the tester

#property version   "1.00"
#property strict

int test_ticket[2]={0,0};
double   gl_lots,
         gl_ask,
         gl_bid;
string   gl_comm;         
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit() {
//---

//---
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason) {
//---

}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick() {
   gl_lots=SymbolInfoDouble(_Symbol,SYMBOL_VOLUME_MIN);
   gl_ask=NormalizeDouble(Ask,_Digits);
   gl_bid=NormalizeDouble(Bid,_Digits);
   gl_comm="test";
//---
   if(AccountFreeMarginCheck(_Symbol,OP_BUY,gl_lots)<=0 || GetLastError()==134) {
      printf("Not enough money for the minimum lot: %.4f",gl_lots); 
      return;
   }
   if(test_ticket[1]<8 && test_ticket[0]==0) {
      test_ticket[0]=OrderSend((StringCompare(_Symbol,"NZDUSD")==0?"NZDUSD":_Symbol),OP_BUY,gl_lots,gl_ask,30,0.0,0.0,gl_comm,33333,0,clrNONE);
      if(test_ticket[0]>0) test_ticket[1]++;
      else if(Fun_Error(GetLastError())==1) return; 
   }   
   if(test_ticket[0]>0)
      if(OrderSelect(test_ticket[0],SELECT_BY_TICKET)) {
         if(OrderCloseTime()==0 && OrderOpenTime()+300<TimeCurrent())
            if(OrderClose(test_ticket[0],OrderLots(),gl_bid,30,clrNONE)) {
               printf("Test order closed, ticket #%d",test_ticket[0]);
               test_ticket[0]=0;
            } else if(Fun_Error(GetLastError())==1) return;
      } else if(Fun_Error(GetLastError())==1) return;
}
//+-------------- ФУНКЦИЯ ОБРАБОТКИ ОШИБОК ---------------------------------+
int Fun_Error(int Error)
{  
   switch(Error)
   {
        case 0:      return (0);
        case 1:      Print("Trying to change already set values with the same values.");return(1);
        case 2:      Print("Common mistake. Stop all trading attempts until the circumstances are clarified.");return(0);
        case 3:      Print("Wrong parameters passed to the trading function.");return(1);
        case 4:      Print("The trading server is busy. Let's try again ..");Sleep(3000);return(1);
        case 5:      Print("Old version of the client terminal.");return(0);
        case 6:      Print("No connection to the trading server.");return(1);
        case 7:      Print("Not enough rights.");return(1);
        case 8:      Print("Too frequent requests.");return(1);
        case 9:      Print("Invalid operation disrupting server operation.");return(1);
        case 64:     Print("The account is blocked. It is necessary to stop all attempts at trading operations.");return(0);
        case 65:     Print("Invalid account number.");return(1);
        case 128:    Print("The transaction has expired.");return(1);
        case 129:    Print("Wrong bid or ask price, possibly not normalized price.");return(1);
        case 130:    Print("Stops that are too close or incorrectly calculated or abnormal prices in stops (or in the opening price of a pending order).");return(1);
        case 131:    Print("Wrong volume, error in granulation of volume.");return(1);
        case 132:    Print("The market is closed.");return(1);
        case 133:    Print("Trade is prohibited.");return(0);
        case 134:    Print("Not enough money to complete the operation.");return(0);
        case 135:    Print("The price has changed. We try again ..");RefreshRates();return(1);
        case 136:    Print("No price. We are waiting for a new tick ..");
                     while(RefreshRates()==false)// До нового тика
                     Sleep(1);
                     return(1);
        case 137:    Print("The broker is busy. Let's try again ..");Sleep(3000);return(1);
        case 138:    Print("The requested price is out of date, or bid and ask are confused.");return(1);
        case 139:    Print("The order is blocked and is already being processed.");return(1);
        case 140:    Print("Only purchase allowed. You cannot repeat the SELL operation.");return(1);
        case 141:    Print("Too many requests.");return(1);
        case 142:    Print("The order is queued.");return(1);
        case 143:    Print("The order has been accepted by the dealer for execution.");return(1);
        case 144:    Print("The order is canceled by the client upon manual confirmation of the transaction.");return(1);
        case 145:    Print("Modification is prohibited, because the order is too close to the market and is blocked due to possible early execution.");return(1);
        case 146:    Print("The trading subsystem is busy. Let's try again ..");Sleep(500);return(1);
        case 147:    Print("Using the expiration date of the order is prohibited by the broker.");return(1);
        case 148:    Print("The number of open and pending orders has reached the limit set by the broker.");return(1);
        case 149:    Print("An attempt to open an opposite position to an existing one if hedging is prohibited.");return(1);
        case 4000:   return (0);
        case 4001:   Print("Invalid function pointer.");return(1);
        case 4002:   Print("Array index is out of range.");return(1);
        case 4003:   Print("No memory for function stack.");return(1);
        case 4004:   Print("Stack overflow after recursive call.");return(1);
        case 4005:   Print("There is no memory on the stack for passing parameters.");return(1);
        case 4006:   Print("There is no memory for the string parameter.");return(1);
        case 4007:   Print("There is no memory for the time line.");return(1);
        case 4008:   Print("Uninitialized string.");return(1);
        case 4009:   Print("An uninitialized string in an array.");return(1);
        case 4010:   Print("There is no memory for the string array.");return(1);
        case 4011:   Print("Line is too long.");return(1);
        case 4012:   Print("The remainder of division by zero.");return(1);
        case 4013:   Print("Division by zero.");return(1);
        case 4014:   Print("Unknown team.");return(1);
        case 4015:   Print("Wrong transition.");return(1);
        case 4016:   Print("Uninitialized array.");return(1);
        case 4017:   Print("DLL calls are not allowed.");return(1);
        case 4018:   Print("Unable to load library.");return(1);
        case 4019:   Print("Unable to call function.");return(1);
        case 4020:   Print("Calls to external library functions are not allowed.");return(1);
        case 4021:   Print("There is not enough memory for the string returned from the function.");return(1);
        case 4022:   Print("The system is busy.");return(1);
        case 4050:   Print("Incorrect number of function parameters.");return(1);
        case 4051:   Print("Invalid function parameter value.");return(1);
        case 4052:   Print("Internal error of string function.");return(1);
        case 4053:   Print("Array error.");return(1);
        case 4054:   Print("Misuse of timeseries array.");return(1);
        case 4055:   Print("Custom indicator error.");return(1);
        case 4056:   Print("Arrays are incompatible.");return(1);
        case 4057:   Print("Error processing global variables.");return(1);
        case 4058:   Print("Global variable not detected.");return(1);
        case 4059:   Print("Function not allowed in test mode.");return(1);
        case 4060:   Print("Enter the HTTP address !!!.");return(1);
        case 4061:   Print("Error sending mail.");return(1);
        case 4062:   Print("A parameter of type string is expected.");return(1);
        case 4063:   Print("A parameter of type integer is expected.");return(1);
        case 4064:   Print("A parameter of type double is expected.");return(1);
        case 4065:   Print("An array is expected as a parameter.");return(1);
        case 4066:   Print("The requested historical data is in an update state.");return(1);
        case 4067:   Print("An error occurred while performing a trading operation.");return(1);
        case 4099:   Print("End of file.");return(1);
        case 4100:   Print("An error occurred while working with the file.");return(1);
        case 4101:   Print("Invalid file name.");return(1);
        case 4102:   Print("Too many open files.");return(1);
        case 4103:   Print("Unable to open file.");return(1);
        case 4104:   Print("Incompatible file access mode.");return(1);
        case 4105:   Print("No order has been selected.");return(1);
        case 4106:   Print("Unknown character.");return(1);
        case 4107:   Print("Incorrect price parameter for the trading function.");return(1);
        case 4108:   Print("Invalid ticket number.");return(1);
        case 4109:   Print("Trading is not permitted. You must enable the option Allow Expert Advisor to trade in the expert properties.");return(1);
        case 4110:   Print("Long positions are not allowed. It is necessary to check the properties of the expert.");return(1);
        case 4111:   Print("Short positions are not allowed. It is necessary to check the properties of the expert.");return(1);
        case 4200:   Print("The object already exists.");return(1);
        case 4201:   Print("An unknown property of the object was requested.");return(1);
        case 4202:   Print("The object does not exist.");return(1);
        case 4203:   Print("Unknown object type.");return(1);
        case 4204:   Print("No object name.");return(1);
        case 4205:   Print("Error coordinates of the object.");return(1);
        case 4206:   Print("The specified subwindow was not found.");return(1);
        case 4207:   Print("An error occurred while working with the object.");return(1);
        return(0);
   }
   return(0);
}
//+---------------------------------------------------------------

No errors.

And why would there be any. Only if the deposit does not allow to open with minimal lot.

Artyom Trishkin 2020.07.26 11:53 #82

Renat Akhtyamov:

10 years with this

I can't complain.

I don't care if it's a hundred years old. How can you complain about just describing the error code?

The function should not only be able to describe the error code (you don't have to do anything at all - just copy it from the help), but it should output the code for the handler. You have either 0 or 1 code everywhere.

Why is the function type int instead of bool?

And you don't have a handler. But your processing means that if a function outputs code 1 to absolutely any server response, you simply execute return. Where from and where to - nobody knows.

So where's the processing? return is not processing, it's escaping from the problem of having to handle the error code returned by the server.

Документация по MQL5: Константы, перечисления и структуры / Коды ошибок и предупреждений

www.mql5.com

Константы, перечисления и структуры / Коды ошибок и предупреждений - справочник по языку алгоритмического/автоматического трейдинга для MetaTrader 5

Any rookie question, so "Not all control paths Modifying Orders Question

Artyom Trishkin 2020.07.26 11:54 #83

Andrey Kaunov:

Corrected the code and ran it in the tester

No errors.

And why would there be any. If the deposit does not allow you to open with a minimum lot.

In such a situation, display a message in the journal and continue working with the Expert Advisor.

Renat Akhtyamov 2020.07.26 11:55 #84

Andrey Kaunov:

Corrected the code and ran it in the tester

No errors.

And why would there be any. You have to open with a minimum lot if your deposit does not allow it.

I've been struggling with it too.

until I set the minimum lot to 0.1

i couldn't understand why i couldn't trade because the MarketInfo() of the validator didn't answer 0.1 as a minimum, it answered 0(zero) or 0.01, i don't remember it ;)

From theory to practice Any questions from newcomers Full-featured robot for MT5

Andrey Kaunov 2020.07.26 11:57 #85

Artem, we're talking about completely different things. The code is transparent. Tell me, where there can be an error there? Show me the exact place and the situation in which it will occur.

I see only one situation,if the deposit does not allow to open with minimal lot . But this is the fault of the tester, why set conditions that do not allow opening a deal with the minimum lot.

Does he do it all the time only on NZDUSD?

[Archive!] Any rookie question, EURUSD - Trends, Forecasts Well working Trading System

Andrey Kaunov 2020.07.26 12:00 #86

There are no external parameters at all in this simple code, as everyone has hopefully noticed. It stupidly opens a trade with the minimum lot offered by the information environment.

Renat Akhtyamov 2020.07.26 12:01 #87

Andrey Kaunov:
This rudimentary code has no parameters at all, as everyone has hopefully noticed. It stupidly opens a trade with the minimum lot offered by the information environment.

What if they have a minlot of 0.1?

personally i'm sure of it.

;)

Maxim Kuznetsov 2020.07.26 12:02 #88

by the way, sure there is never a ticket #0 ? :-)

Andrey Kaunov 2020.07.26 12:06 #89

Renat Akhtyamov:

What if they have a minlot of 0.1?

personally i'm sure of it.

;)

No luck renat, 0.2))) Here's a test, where I haven't checked the possibility of opening with a min lot yet

All described in previous posts.

Maxim Kuznetsov:

by the way, sure there is never a ticket #0 ? :-)

I am not sure of anything anymore ))))

Any questions from newcomers Discussion of article "Library Bill Williams and his

Renat Akhtyamov 2020.07.26 12:07 #90

Andrey Kaunov:

I guessed wrong, Renat, 0.2))) Here's a test, where I haven't checked the possibility of opening with a min lot yet

All described in previous posts.

that's it

tough it for min lot if tester and start trading on margin, of course taking into account the cost of the spread

like: if free margin*0.9 > lot*margin, then trade

Troubled by the error there are no trading operations - page 9