forLoop Misunderstanding stalking multiple opened Orders... - page 2
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Please show relevant code
AND SO ON...
is not any use.
for(int j=0; j<OrdersTotal(); j++)
{
if(OrderSelect(j,SELECT_BY_POS,MODE_TRADES)==true)
{
tip=OrderType();
if((which_MagicNumber_to_trail==OrderMagicNumber() || which_MagicNumber_to_trail==-1)
&& (which_Comment_to_trail==OrderComment() || which_Comment_to_trail=="ALL")
&& OrderSymbol()==Symbol()
&&(includeManualTrades==true||OrderMagicNumber()!=0))
{
OSL = OrderStopLoss();
OOP = OrderOpenPrice();
Ticket = OrderTicket();
n++;
if(tip==OP_BUY)
{
if(GeneralNoLossBackup==false)
{
SLKlein=SlLastBarKlein(OP_BUY,BID,NLb);
if(SLKlein<NLb) continue;
}
else
{
SLKlein=SlLastBarKlein(OP_BUY,BID,OOP);
}
//if (OSL >= OOP && only_NoLoss) continue;
if(SLKlein>=OSL+StepTrall*Point && (BID-SLKlein)/Point>STOPLEVEL)
{
if(VirtualTrailingStopOn)
{
if(SLBKlein<SLKlein) SLBKlein=SLKlein;
if(OrderSymbol()==Symbol()) LineTrailingBuyKlein(DoubleToString(OrderTicket())+" StopProfitBuy",SLBKlein,SafeProfitLine_ColourKlein);
if(SLBKlein!=0 && BID<=SLBKlein)
{
if((WinBackup==true&&OrderProfit()>0)||(LooseBackup==true&&OrderProfit()<0)){
if(OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippageClose,Blue)) {
ObjectsDeleteAll(ChartID(),0,OBJ_HLINE);
if (OrderProfit()>0 && PlaySounds==true) PlaySound("work.wav");
if (OrderProfit()<0 && PlaySounds==true) PlaySound("alert.wav");}
continue;
}};
}
else
{
error=OrderModify(Ticket,OOP,SLKlein,OrderTakeProfit(),0,White);
if(!error) Comment("TrailingStopGross Error ",GetLastError()," order ",Ticket," SLKlein ",SLKlein);
else Comment("TrailingStopGross ",Ticket," ",TimeToStr(TimeCurrent(),TIME_MINUTES));
}
}
}
if(tip==OP_SELL)
{
if(GeneralNoLossBackup==false)
{
SLKlein=SlLastBarKlein(OP_SELL,ASK,NLs);
if(SLKlein>NLs) continue;
}
else
{
SLKlein=SlLastBarKlein(OP_SELL,ASK,OOP);
}
//if (OSL <= OOP && only_NoLoss) continue;
if((SLKlein<=OSL-StepTrall*Point || OSL==0) && (SLKlein-ASK)/Point>STOPLEVEL)
{
if(VirtualTrailingStopOn)
{
if(SLSKlein==0 || SLSKlein>SLKlein) SLSKlein=SLKlein;
if(OrderSymbol()==Symbol()) LineTrailingSellKlein(DoubleToString(OrderTicket())+" StopProfitSell",SLSKlein,SafeProfitLine_ColourKlein);
if(SLSKlein!=0 && ASK>=SLSKlein)
{
if((WinBackup==true&&OrderProfit()>0)||(LooseBackup==true&&OrderProfit()<0)){
if(OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippageClose,Red)) {
ObjectsDeleteAll(ChartID(),0,OBJ_HLINE);
if (OrderProfit()>0 && PlaySounds==true) PlaySound("work.wav");
if (OrderProfit()<0 && PlaySounds==true) PlaySound("alert.wav");}
continue;
}};
}
else
{
error=OrderModify(Ticket,OOP,SLKlein,OrderTakeProfit(),0,White);
if(!error) Comment("TrailingStopGross Error ",GetLastError()," order ",Ticket," SLKlein ",SLKlein);
else Comment("TrailingStopGross ",Ticket," ",TimeToStr(TimeCurrent(),TIME_MINUTES));
}
}
}
}
}
} // if BackupTrailingStop == true
}} Good Morning Keith....
Forum on trading, automated trading systems and testing trading strategies
When you post code please use the CODE button (Alt-S)!
I know that the variable names that you use are meaningful to you, but they are meaningless to me and that makes it very difficult for me to try to follow your code. Also the fact that you have function calls but don't include the functions means that I have no idea what you are trying to do.
I will be unable to help you, especially as you haven't even described your problem.
I know that the variable names that you use are meaningful to you, but they are meaningless to me and that makes it very difficult for me to try to follow your code. Also the fact that you have function calls but don't include the functions means that I have no idea what you are trying to do.
I will be unable to help you, especially as you haven't even described your problem.
Hello, Keith, i hope my next try, will make it clearer...i am so sad :-((
That's an example of a Trailing. You can easily change it to virtual.
Separate trailing based on order's ticket number.
So you have to set your criteria to check each order by magic number and close only this order.
Thank You, i will have a look at it right now, didnt knew PositionsTotal() :-)
Thank You, i will have a look at it right now, didnt knew PositionsTotal() :-)
You are most welcome Tim. Hope it makes it clearer. At your disposal if you need further help.
Hello, Keith, i hope my next try, will make it clearer...i am so sad :-((
Sorry, that doesn't make it any clearer. Maybe I am missing something.
Why all the nested loops? I simply can't see what you are trying to achieve.
You want to calculate with each order separately, so deal with them separately.
You can't calculate with more than one order at a time. They must be checked one after the other.
Like Keith says, it's very unclear what you want to do. I think this is a case of when a person knows what they want to do in their head, but cannot clearly articulate it in writing... What is very clear is that this code is trying to do way too much and should be broken down to easier steps (functions).
Also, this thread had gone into MT5 examples for an MT4 problem...