Coding help - page 156
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Dear MLaden,
Next indi I can get on chart in my Live account and on demo of Markets.com (CFD's). Either there is a problem to get it on chart at Liquid Markets on demo. Because Liquid offers severall options of instruments (particularly Futures in MT4) I would like to have it on chart in that platform. Can you see a problem rising this issue, because I cannot find.
Thx MarcoIt is probably due to the fact that that indicator is a decompiled indicator. From build 500 metarader prevents such indicators to be compiled
It is probably due to the fact that that indicator is a decompiled indicator. From build 500 metarader prevents such indicators to be compiled
Hello MLaden,
Thx, but strange because all the MT4 platforms from brokers I use, are the 500 version.
Regards Marco
I have an EA in which I would like to use partial take profit function. I coded this function in and once it works well, other times it does not. I was not able to figure out what is the problem...
Dear Mladen or MrTools, Would you be kind enough to look into the code and give me an advice on how I could find the bug and resolve the partial taking function?
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
int signal;
CheckOrders();
int numTrades = GetNumTickets();
signal = CheckSignal();
if (signal == OP_BUY)
{
OpenBuy();
lasttime = TimeCurrent();
}
if (signal == OP_SELL)
{
OpenSell();
lasttime = TimeCurrent();
}
return;
}
// +----------------------------------------------------------------------------+
// | Order checking function
// +----------------------------------------------------------------------------+
void CheckOrders()
{
int typ,i,cnt,ticket;
int Mv1 = 0;
int SL1 = 0;
int Mv2 = 0;
int SL2 = 0;
int Mv3 = 0;
int id;
double PipDist, CLots, buy_nextTP, sell_nextTP;
cnt = OrdersTotal();
for (i=cnt-1; i>=0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
{
typ = OrderType();
//
if (typ == OP_BUY)
{
if (TrailingStopLoss)
{
if (AdjTrailOnAllOrders(2, buy_Trailpips, Magic, typ, Mv1, SL1, Mv2, SL2, Mv3) == false)
Alert("Scalp_RSI: Modifying BUY order failed!");
}
PipDist = (NormalizeDouble(Bid,Digits) - NormalizeDouble(OrderOpenPrice(),Digits));
PipDist = MathFloor(PipDist/myPoint);
}
if (typ == OP_SELL)
{
if(TrailingStopLoss)
{
if (AdjTrailOnAllOrders(2, sell_Trailpips, Magic, typ, Mv1, SL1, Mv2, SL2, Mv3) == false)
Alert("Scalp_RSI: Modifying SELL order failed!");
}
PipDist = (NormalizeDouble(OrderOpenPrice(),Digits) - NormalizeDouble(Ask,Digits));
PipDist = MathFloor(PipDist/myPoint);
}
if (TakePartialProfit == true && PartCloseLots > 0)
{
if (UseMoneyMgmt != 1) Lotsi = Lots;
CLots = NormalizeDouble(Lotsi * PartCloseLots/100,Decimals); // Computing lots to close
if (CLots < MarketInfo(Symbol(), MODE_MINLOT))
CLots = MarketInfo(Symbol(), MODE_MINLOT);
PartialTP(PipDist,OrderTicket(),CLots);
}
}
}
}
}
//+------------------------------------------------------------------+
//| PartialTP - i.e. TakePartialProfit function
//+------------------------------------------------------------------+
void PartialTP(int pipsval, int ticket, double CLots) //
{
int gle;
int loopcount = 0;
string bER;
string myInfo = "PartialTP";
if(OrderSelect(ticket, SELECT_BY_TICKET)==true)
{
if (OrderType() == OP_BUY)
{
if ((pipsval >= buy_PartialTP) && (pipsval < buy_TakeProfit+1)) //
{
while(true)
{
OrderClose(ticket,CLots,Bid,3,YellowGreen);
gle=GetLastError();
bER=" error="+gle+" "+ErrorDescription(gle);
if(gle==0 || gle==1)
{
logwrite(TradeComment,"CLOSE BUY "+myInfo+ " " + CLots + " at Bid= " + Bid);
buy_PartialTP = buy_TakeProfit+1; //
break;
}
else
{
logwrite(TradeComment,"---ERROR--- CLOSE BUY "+myInfo+bER+ " " + CLots + " at Bid= " + Bid);
RefreshRates();
Sleep(500);
}
loopcount++;
if(loopcount>maxloop)
{
logwrite(TradeComment,"---ERROR--- Giving up on closing BUY order");
return(gle);
}
}
}
}
if (OrderType() == OP_SELL) //
{
if ((pipsval >= sell_PartialTP) && (pipsval < sell_TakeProfit)) //
{
while(true)
{
OrderClose(ticket,CLots,Ask,3,YellowGreen);
gle=GetLastError();
bER=" error="+gle+" "+ErrorDescription(gle);
if(gle==0 || gle==1)
{
logwrite(TradeComment,"CLOSE SELL "+myInfo+ " " + CLots + " at Ask= " + Ask);
sell_PartialTP = sell_TakeProfit; //
break;
}
else
{
logwrite(TradeComment,"---ERROR--- CLOSE SELL "+myInfo+bER+ " " + CLots + " at Ask= " + Ask);
RefreshRates();
Sleep(500);
}
loopcount++;
if(loopcount>maxloop)
{
logwrite(TradeComment,"---ERROR--- Giving up on closing SELL order");
return(gle);
}
}
}
}
} else {
gle=GetLastError();
bER=" Error="+gle+" "+ErrorDescription(gle);
if (gle != 0 || gle!=1)
{
logwrite(TradeComment,"---ERROR--- in selecting order in PartialTP function "+bER);
}
}
}
//+------------------------------------------------------------------+
//| Get number of open trades
//+------------------------------------------------------------------+
int GetNumTickets()
{
int i;
int typ;
numTickets = 0;
for (i = OrdersTotal()-1; i >= 0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
{
typ = OrderType();
if (typ == OP_BUY || typ == OP_SELL)
{
numTickets ++;
}
}
}
}
return (numTickets);
}
//+------------------------------------------------------------------+
//| Get signal
//+------------------------------------------------------------------+
int CheckSignal()
{
return (SignalScalp());
}
//+------------------------------------------------------------------+
//| Get scalp signal
//+------------------------------------------------------------------+
int SignalScalp()
{
int signal=6; //
if (enable_buy){
// Buy-Condition
{
signal = OP_BUY;
}
}
//
//
if (enable_sell){
// Sell-Condition
{
signal = OP_SELL;
}
}
//
//
//
return(signal);
}
//-----
// +----------------------------------------------------------------------------+
// | Buy Order
// +----------------------------------------------------------------------------+
void OpenBuy()
{
int gle = 0;
int ticket = 0;
double SL = 0;
double TP = 0;
double LotsB = Lots; //GetLots();
int loopcount = 0;
while(true)
{
ticket=OrderSend(Symbol(),OP_BUY,LotsB,Ask,Slippage,0,0,TradeComment,Magic,White);
}
}
// +----------------------------------------------------------------------------+
// | Sell Order
// +----------------------------------------------------------------------------+
void OpenSell()
{
int gle = 0;
int ticket = 0;
double SL = 0;
double TP = 0;
double LotsS = Lots;
int loopcount = 0;
while(true)
{
ticket=OrderSend(Symbol(),OP_SELL,LotsS,Bid,Slippage,0,0,TradeComment,Magic,Red);
}
}
bool AdjTrailOnAllOrders(
int TrailType,
int TrailPips,
int Magic,
int Direction,
int FirstMove,
int FirstStopLoss,
int SecondMove,
int SecondStopLoss,
int ThirdMove)
{
double retValue;
return(retValue);
}
//+------------------------------------------------------------------+
//| SetComment function
//+------------------------------------------------------------------+
void SetComment(string s) { TradeComment = s; }
// +----------------------------------------------------------------------------+
// | Pip setting
// +----------------------------------------------------------------------------+
double SetPoint()
{
double mPoint;
return(mPoint);
}
// +----------------------------------------------------------------------------+
// | Log write function
// +----------------------------------------------------------------------------+
void logwrite (string filename, string mydata)
{
int myhandle;
}
I have an EA in which I would like to use partial take profit function. I coded this function in and once it works well, other times it does not. I was not able to figure out what is the problem...
Dear Mladen or MrTools, Would you be kind enough to look into the code and give me an advice on how I could find the bug and resolve the partial taking function?
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
int signal;
CheckOrders();
int numTrades = GetNumTickets();
signal = CheckSignal();
if (signal == OP_BUY)
{
OpenBuy();
lasttime = TimeCurrent();
}
if (signal == OP_SELL)
{
OpenSell();
lasttime = TimeCurrent();
}
return;
}
// +----------------------------------------------------------------------------+
// | Order checking function
// +----------------------------------------------------------------------------+
void CheckOrders()
{
int typ,i,cnt,ticket;
int Mv1 = 0;
int SL1 = 0;
int Mv2 = 0;
int SL2 = 0;
int Mv3 = 0;
int id;
double PipDist, CLots, buy_nextTP, sell_nextTP;
cnt = OrdersTotal();
for (i=cnt-1; i>=0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
{
typ = OrderType();
//
if (typ == OP_BUY)
{
if (TrailingStopLoss)
{
if (AdjTrailOnAllOrders(2, buy_Trailpips, Magic, typ, Mv1, SL1, Mv2, SL2, Mv3) == false)
Alert("Scalp_RSI: Modifying BUY order failed!");
}
PipDist = (NormalizeDouble(Bid,Digits) - NormalizeDouble(OrderOpenPrice(),Digits));
PipDist = MathFloor(PipDist/myPoint);
}
if (typ == OP_SELL)
{
if(TrailingStopLoss)
{
if (AdjTrailOnAllOrders(2, sell_Trailpips, Magic, typ, Mv1, SL1, Mv2, SL2, Mv3) == false)
Alert("Scalp_RSI: Modifying SELL order failed!");
}
PipDist = (NormalizeDouble(OrderOpenPrice(),Digits) - NormalizeDouble(Ask,Digits));
PipDist = MathFloor(PipDist/myPoint);
}
if (TakePartialProfit == true && PartCloseLots > 0)
{
if (UseMoneyMgmt != 1) Lotsi = Lots;
CLots = NormalizeDouble(Lotsi * PartCloseLots/100,Decimals); // Computing lots to close
if (CLots < MarketInfo(Symbol(), MODE_MINLOT))
CLots = MarketInfo(Symbol(), MODE_MINLOT);
PartialTP(PipDist,OrderTicket(),CLots);
}
}
}
}
}
//+------------------------------------------------------------------+
//| PartialTP - i.e. TakePartialProfit function
//+------------------------------------------------------------------+
void PartialTP(int pipsval, int ticket, double CLots) //
{
int gle;
int loopcount = 0;
string bER;
string myInfo = "PartialTP";
if(OrderSelect(ticket, SELECT_BY_TICKET)==true)
{
if (OrderType() == OP_BUY)
{
if ((pipsval >= buy_PartialTP) && (pipsval < buy_TakeProfit+1)) //
{
while(true)
{
OrderClose(ticket,CLots,Bid,3,YellowGreen);
gle=GetLastError();
bER=" error="+gle+" "+ErrorDescription(gle);
if(gle==0 || gle==1)
{
logwrite(TradeComment,"CLOSE BUY "+myInfo+ " " + CLots + " at Bid= " + Bid);
buy_PartialTP = buy_TakeProfit+1; //
break;
}
else
{
logwrite(TradeComment,"---ERROR--- CLOSE BUY "+myInfo+bER+ " " + CLots + " at Bid= " + Bid);
RefreshRates();
Sleep(500);
}
loopcount++;
if(loopcount>maxloop)
{
logwrite(TradeComment,"---ERROR--- Giving up on closing BUY order");
return(gle);
}
}
}
}
if (OrderType() == OP_SELL) //
{
if ((pipsval >= sell_PartialTP) && (pipsval < sell_TakeProfit)) //
{
while(true)
{
OrderClose(ticket,CLots,Ask,3,YellowGreen);
gle=GetLastError();
bER=" error="+gle+" "+ErrorDescription(gle);
if(gle==0 || gle==1)
{
logwrite(TradeComment,"CLOSE SELL "+myInfo+ " " + CLots + " at Ask= " + Ask);
sell_PartialTP = sell_TakeProfit; //
break;
}
else
{
logwrite(TradeComment,"---ERROR--- CLOSE SELL "+myInfo+bER+ " " + CLots + " at Ask= " + Ask);
RefreshRates();
Sleep(500);
}
loopcount++;
if(loopcount>maxloop)
{
logwrite(TradeComment,"---ERROR--- Giving up on closing SELL order");
return(gle);
}
}
}
}
} else {
gle=GetLastError();
bER=" Error="+gle+" "+ErrorDescription(gle);
if (gle != 0 || gle!=1)
{
logwrite(TradeComment,"---ERROR--- in selecting order in PartialTP function "+bER);
}
}
}
//+------------------------------------------------------------------+
//| Get number of open trades
//+------------------------------------------------------------------+
int GetNumTickets()
{
int i;
int typ;
numTickets = 0;
for (i = OrdersTotal()-1; i >= 0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
{
typ = OrderType();
if (typ == OP_BUY || typ == OP_SELL)
{
numTickets ++;
}
}
}
}
return (numTickets);
}
//+------------------------------------------------------------------+
//| Get signal
//+------------------------------------------------------------------+
int CheckSignal()
{
return (SignalScalp());
}
//+------------------------------------------------------------------+
//| Get scalp signal
//+------------------------------------------------------------------+
int SignalScalp()
{
int signal=6; //
if (enable_buy){
// Buy-Condition
{
signal = OP_BUY;
}
}
//
//
if (enable_sell){
// Sell-Condition
{
signal = OP_SELL;
}
}
//
//
//
return(signal);
}
//-----
// +----------------------------------------------------------------------------+
// | Buy Order
// +----------------------------------------------------------------------------+
void OpenBuy()
{
int gle = 0;
int ticket = 0;
double SL = 0;
double TP = 0;
double LotsB = Lots; //GetLots();
int loopcount = 0;
while(true)
{
ticket=OrderSend(Symbol(),OP_BUY,LotsB,Ask,Slippage,0,0,TradeComment,Magic,White);
}
}
// +----------------------------------------------------------------------------+
// | Sell Order
// +----------------------------------------------------------------------------+
void OpenSell()
{
int gle = 0;
int ticket = 0;
double SL = 0;
double TP = 0;
double LotsS = Lots;
int loopcount = 0;
while(true)
{
ticket=OrderSend(Symbol(),OP_SELL,LotsS,Bid,Slippage,0,0,TradeComment,Magic,Red);
}
}
bool AdjTrailOnAllOrders(
int TrailType,
int TrailPips,
int Magic,
int Direction,
int FirstMove,
int FirstStopLoss,
int SecondMove,
int SecondStopLoss,
int ThirdMove)
{
double retValue;
return(retValue);
}
void SetComment(string s) { TradeComment = s; }
double SetPoint()
{
double mPoint;
return(mPoint);
}
void logwrite (string filename, string mydata)
{
int myhandle;
}
christoff
I can not see what value are you using for "Decimals" variable, but probably that is the cause of your problem. The resulting part of the order has to be in accordance with the lot step value too (meaning : if the lot step is 0.1 for example, you can not try to close 0.11 lots). Check what is the last error after the partical close that is not suceeding (you can do it by simply adding a comment after lines that go like this one :
bER=" error="+gle+" "+ErrorDescription(gle);
if (gle>1) Comment(bER);
since the logwrite function in the code is not operative
Mladen,
Thank you for the reply.
Well, I shortened the code because there is no possibility for a post to be longer than 10,000 characters. So, in the original code the Decimals variable is in the init() as follows:
LotStep = MarketInfo(Symbol(),MODE_LOTSTEP);
if(LotStep == 0.01) {Decimals = 2;}
if(LotStep == 0.1) {Decimals = 1;}
if(LotStep == 1) {Decimals = 0;}[/PHP]
Yes, logwrite function is not functionable in the code posted, also because of the shortening. Normally it looks like:
[PHP]
void logwrite (string filename, string mydata)
{
int myhandle;
string wcalend=TimeToStr(CurTime(),TIME_DATE|TIME_SECONDS);
Print(mydata+" "+wcalend);
if(IsTesting()) return(0);
myhandle=FileOpen(Symbol()+"_"+filename, FILE_CSV|FILE_WRITE|FILE_READ, ";");
if(myhandle>0)
{
FileSeek(myhandle,0,SEEK_END);
FileWrite(myhandle, mydata+" "+wcalend);
FileClose(myhandle);
}
}So, I do not think the problem emerges because of the Decimals variable.
Mladen,
Thank you for the reply.
Well, I shortened the code because there is no possibility for a post to be longer than 10,000 characters. So, in the original code the Decimals variable is in the init() as follows:
LotStep = MarketInfo(Symbol(),MODE_LOTSTEP);
if(LotStep == 0.01) {Decimals = 2;}
if(LotStep == 0.1) {Decimals = 1;}
if(LotStep == 1) {Decimals = 0;}[/PHP]
Yes, logwrite function is not functionable in the code posted, also because of the shortening. Normally it looks like:
[PHP]
void logwrite (string filename, string mydata)
{
int myhandle;
string wcalend=TimeToStr(CurTime(),TIME_DATE|TIME_SECONDS);
Print(mydata+" "+wcalend);
if(IsTesting()) return(0);
myhandle=FileOpen(Symbol()+"_"+filename, FILE_CSV|FILE_WRITE|FILE_READ, ";");
if(myhandle>0)
{
FileSeek(myhandle,0,SEEK_END);
FileWrite(myhandle, mydata+" "+wcalend);
FileClose(myhandle);
}
}Christoff
That way Decimals variable should be OK
In any case, check what error code are you getting in a case of unsuccessful order (partial) close
I see you are not using magic number, so the assumption is that it does not matter what is the magic number or symbol. In that case first check if there is already an opened order - like this :
{
ticket=OrderSend(Symbol(), OP_BUY, lots, Ask, 3, 0, 0);
stop=(Ask-stopsize*Point);
prof=(Ask+profsize*Point);
OrderModify( ticket, OrderOpenPrice(), stop, prof, 0, Blue);
}
Thanks mladen.
if (OrdersTotal()<1
It had solve my problem.
It Total can order one, but I want each pair currencies can open.
I'm sorry to misunderstand.
But I meaning is in each pair execute one order and stop.Example:
Now I open order in EURUSD execute one order only.Then other currencies also can open in same time execute one order.I'm sorry with my poor English.
-----------------------------------------------------------------
Thanks.
Thanks mladen.
if (OrdersTotal()<1
It had solve my problem.
It Total can order one, but I want each pair currencies can open.
I'm sorry to misunderstand.
But I meaning is in each pair execute one order and stop.Example:
Now I open order in EURUSD execute one order only.Then other currencies also can open in same time execute one order.I'm sorry with my poor English.
-----------------------------------------------------------------
Thanks.
hock87
Add this :
for (int i=0; i <= OrdersTotal(); i++)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
if (OrderSymbol() == Symbol())
TotalOrders++;
}
before the if (OrdersTotal()<1) line and replace that line with if (TotalOrders<1). That way only one opened order per symbol will be allowed
Thank you so much, mladen.
I try it now.
Thanks mladen.
if (OrdersTotal()<1
It had solve my problem.
It Total can order one, but I want each pair currencies can open.
I'm sorry to misunderstand.
But I meaning is in each pair execute one order and stop.Example:
Now I open order in EURUSD execute one order only.Then other currencies also can open in same time execute one order.I'm sorry with my poor English.
-----------------------------------------------------------------
Thanks.
hock87
Please read the post above your post for a solution of that problem
The complete code for that is the following :
int TotalOrders = 0;
for (int i=0; i <= OrdersTotal(); i++)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
if (OrderSymbol() == Symbol())
TotalOrders++;
}
if (TotalOrders<1)
{
ticket=OrderSend(Symbol(), OP_BUY, lots, Ask, 3, 0, 0);
stop=(Ask-stopsize*Point);
prof=(Ask+profsize*Point);
OrderModify( ticket, OrderOpenPrice(), stop, prof, 0, Blue);
}