I'm working on how to improve the strategy for a stock market - Articles, Library comments

willgart 2014.03.01 18:55 #21

I think the initial strategy is good... I'm working on it to see what can I do to improve it.

I also have found minor code issues.

1 cause a lot of ordermodify error if the SL is fixed but not the TP (set to auto), which cause an error when the broker required that both the TP and SL to be set.

there is no magicnumber used, so I'll add one.

the other is on the trade logic...

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Upward=false;}
so if the combination of the indicators is not a up trend this is a down trend... which is false.

I add a dwward variable and set it to true if its a down trend

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Dwward=true;}

and

if (Upward==true && wprmb) {SignalBuy=true;}
//---
if (Dwward==true && wprms) {SignalSell=true;}

finally... what's the purpose of the code in the deinit() function? why the SL has to be modified when you close the EA?

Setting margin rates Turning timer on and Group of OnTester events

willgart 2014.03.01 18:55 #22

I think the initial strategy is good... I'm working on it to see what can I do to improve it.

I also have found minor code issues.

1 cause a lot of ordermodify error if the SL is fixed but not the TP (set to auto), which cause an error when the broker required that both the TP and SL to be set.

there is no magicnumber used, so I'll add one.

the other is on the trade logic...

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Upward=false;}
so if the combination of the indicators is not a up trend this is a down trend... which is false.

I add a dwward variable and set it to true if its a down trend

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Dwward=true;}

and

if (Upward==true && wprmb) {SignalBuy=true;}
//---
if (Dwward==true && wprms) {SignalSell=true;}

finally... what's the purpose of the code in the deinit() function? why the SL has to be modified when you close the EA?

[WARNING CLOSED!] Any newbie How to get data Embedded TRUE/FALSE options -

Roberto Jacobs 2014.03.01 20:49 #23

willgart:

I think the initial strategy is good... I'm working on it to see what can I do to improve it.

I also have found minor code issues.

1 cause a lot of ordermodify error if the SL is fixed but not the TP (set to auto), which cause an error when the broker required that both the TP and SL to be set.

there is no magicnumber used, so I'll add one.

the other is on the trade logic...

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Upward=false;}
so if the combination of the indicators is not a up trend this is a down trend... which is false.

I add a dwward variable and set it to true if its a down trend

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Dwward=true;}

and

if (Upward==true && wprmb) {SignalBuy=true;}
//---
if (Dwward==true && wprms) {SignalSell=true;}

finally... what's the purpose of the code in the deinit() function? why the SL has to be modified when you close the EA?

Hi willgart,

It's up to you, if you like to make modification or optimization and improve that EA for your purpose only.
But, Are you don't know that magicnumber, deviation, color,
or something like it, will not be accepted by MT4 ECN server?

If you don't know that in MT4 ECN, OrderSend function () should not be put TP and SL,
MagicNumber, Deviation and Color? But TP and SL should be done through OrderModify function ()?

Hence, why on the EA SmartAssTrade I make lot of command OrderModify ().

If you try the script that you modified on MT4 ECN, I am sure that EA will not make a trade at all.

For your information, when I trading on my broker server (2 and 4 digits or 3 and 5 digits after the decimal points) is not an error at all as you say.

In deinit function (), I made an command for modification of the order,
because if it is not modified, when the computer is turned off
(on the set TP=true or SL=true), then the orders are still open
(floating loss) that currently do not have TP or SL.

Hope you can understand.

Regards.

Modifying a Position - Modifying a Position - Managing Pending Orders -

Roberto Jacobs 2014.03.01 20:49 #24

willgart:

I think the initial strategy is good... I'm working on it to see what can I do to improve it.

I also have found minor code issues.

1 cause a lot of ordermodify error if the SL is fixed but not the TP (set to auto), which cause an error when the broker required that both the TP and SL to be set.

there is no magicnumber used, so I'll add one.

the other is on the trade logic...

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Upward=false;}
so if the combination of the indicators is not a up trend this is a down trend... which is false.

I add a dwward variable and set it to true if its a down trend

if (osb==3 && upm>=2) {Upward=true;}

if (oss==3 && dnm>=2) {Dwward=true;}

and

if (Upward==true && wprmb) {SignalBuy=true;}
//---
if (Dwward==true && wprms) {SignalSell=true;}

finally... what's the purpose of the code in the deinit() function? why the SL has to be modified when you close the EA?

Hi willgart,

It's up to you, if you like to make modification or optimization and improve that EA for your purpose only.
But, Are you don't know that magicnumber, deviation, color,
or something like it, will not be accepted by MT4 ECN server?

If you don't know that in MT4 ECN, OrderSend function () should not be put TP and SL,
MagicNumber, Deviation and Color? But TP and SL should be done through OrderModify function ()?

Hence, why on the EA SmartAssTrade I make lot of command OrderModify ().

If you try the script that you modified on MT4 ECN, I am sure that EA will not make a trade at all.

For your information, when I trading on my broker server (2 and 4 digits or 3 and 5 digits after the decimal points) is not an error at all as you say.

In deinit function (), I made an command for modification of the order,
because if it is not modified, when the computer is turned off
(on the set TP=true or SL=true), then the orders are still open
(floating loss) that currently do not have TP or SL.

Hope you can understand.

Regards.

how can i modify Need Help With Modify Meaning: ECN Account

schimbo 2014.03.02 20:04 #25

hey :)

thx for ur EA.looks really nice on backtest.will start forward test tonight.

nice greetz

schimbo

schimbo 2014.03.02 20:04 #26

hey :)

thx for ur EA.looks really nice on backtest.will start forward test tonight.

nice greetz

schimbo

danhei 2014.03.03 11:59 #27

Hello mate,

What time frames do you use to make the most out of this strategy?

Thanks in advance!

danhei 2014.03.03 11:59 #28

Hello mate,

What time frames do you use to make the most out of this strategy?

Thanks in advance!

Roberto Jacobs 2014.03.03 12:50 #29

danhei:

Hello mate,

What time frames do you use to make the most out of this strategy?

Thanks in advance!

Hello danhei,

I use TF between M15 to H1, but the more I use the TF M15

You're welcome, mate.

Roberto Jacobs 2014.03.03 12:50 #30

danhei:

Hello mate,

What time frames do you use to make the most out of this strategy?

Thanks in advance!

Hello danhei,

I use TF between M15 to H1, but the more I use the TF M15

You're welcome, mate.

Experts: EA SmartAssTrade. - page 3