Experts: ZigZag EA - page 3

[Rodrigo Silva]

tks a lot.

[Jackery]

I don't see anything when I put it on a chart. The parameters are in Russian (i think), making it difficult for me adjust. I was expecting to see the zigzag line and fibo levels when I but it on a chart. I used the default settings.

[Vladimir Karputov]

Jackery:

I can't see anything when I put it in the graph. The parameters are in Russian (I think) which makes it difficult to set up. I was expecting to see the zigzag line and Fibonacci levels when I charted it. I used the default settings.

That's correct. If the EA uses indicators, these indicators:

• in the strategy tester: these indicators will be visible
• in the terminal: these indicators will not be visible.

To display the indicators used by the Expert Advisor in the terminal, you need to use the ChartIndicatorAdd command.

[BRIAN AVERY SINCLAIR]

I am getting these errors when loading this EA

'INIT_FAILED' - expression not boolean ZigZag EA.mq5 Line 427 Comment 20

'INIT_FAILED' - expression not boolean ZigZag EA.mq5 Line 433 Comment 17

Also don't see the Fibo fix stated above..

can you add the Fibo fix and fix these errors and upload again?

[Vladimir Karputov]

Brian Sinclair :

I am getting these errors when loading this EA

'INIT_FAILED' - expression not boolean ZigZag EA.mq5 Line 427 Comment 20

'INIT_FAILED' - expression not boolean ZigZag EA.mq5 Line 433 Comment 17

Also don't see the Fibo fix stated above..

can you add the Fibo fix and fix these errors and upload again?

Please download version 1.003 from the Russian part of the forum: https://www.mql5.com/ru/code/21452

[lippmaje]

Vladimir Karputov:

Please download version 1.003 from the Russian part of the forum: https://www.mql5.com/ru/code/21452

This line of code is still not fixed:

   TakeProfit=(int)(((size_corridor/100.0*Fibo_TakeProfit)-size_corridor)/m_symbol.Point());

The Fibo_TakeProfit is an enum, and supposed to be translated into a percentage value by the function GetFibo(), which is missing here.

Fixed line should read like this:

   TakeProfit=(int)(((size_corridor/100.0*GetFibo(Fibo_TakeProfit))-size_corridor)/m_symbol.Point());

[Vladimir Karputov]

lippmaje :

This line of code is still not fixed:

The Fibo_TakeProfit is an enum, and supposed to be translated into a percentage value by the function GetFibo(), which is missing here.

Fixed line should read like this:

Thanks.

But you can always fix the code yourself or download version 1.005 from the Russian part of the forum: https://www.mql5.com/ru/code/21452

[lippmaje]

Vladimir Karputov:

Thanks.

But you can always fix the code yourself or download version 1.005 from the Russian part of the forum: https://www.mql5.com/ru/code/21452

Of course, thanks for your work.

[Vladimir Karputov]

lippmaje :
Of course. Thanks for your work. Of course, thanks for your work.

In version 1.005, I also added insurance: checking the current price and the price of a pending order.

[lippmaje]

The inputs ExtDepth, ExtDeviation, ExtBackstep are not evaluated. This line should be changed:

   handle_iCustom=iCustom(m_symbol.Name(),Period(),"Examples\\ZigZag");

to

   handle_iCustom=iCustom(m_symbol.Name(),Period(),"Examples\\ZigZag",ExtDepth,ExtDeviation,ExtBackstep);

Furthermore, the start/stop time inputs are not evaluated, except for a validity check in OnInit(). So the user has no control over trading time although the inputs suggest otherwise.