Coding help - page 473

New comment
 
zigflip:
Please help fix this indicator, because it keeps alerting even when every alert option is set to "false"

is mr Tools version i think...

sincerely,

it's trying to say something...unfortunately...no one listens...

 
Pava:
it's trying to say something...unfortunately...no one listens...

Who's calling ???

Every one 's listening.

Just a matter of jet lag...

Here is it nmc, no alert should come anymore, otherwise alert Mladen !!!

Sincerely.

Tomcat98

 

What to change to replace location arrow ?

Files:
arow.jpg  180 kb
 
popej30:
What to change to replace location arrow ?

Change price for the low dots from Low[nnn] to High[nnn]

And change the price for the upper dots from High[nnn] to Low[nnn]

 
Tomcat98:
Who's calling ???

Every one 's listening.

Just a matter of jet lag...

Here is it nmc, no alert should come anymore, otherwise alert Mladen !!!

Sincerely.

Tomcat98

good stuff thank you

 

how about this indicator... it may use some same code as some ZUP harmonic indicators, but anyway if used together with ZUPs and some other indicators, it removes some rays and other stuff, like removing the triangles or lines used for the gartley,etc shapes.

Wonder if it could be fixed? Seems like the "Complet" function is not working that should allow layering, but just me guessing. If it is too lenghty to fix, not to worry. (I just made a few cosmetic modifications to the original version but has same problem.)

sincerely,

Files:
gann_sq9_mxi.mq4  14 kb
 
zigflip:
how about this indicator... it may use some same code as some ZUP harmonic indicators, but anyway if used together with ZUPs and some other indicators, it removes some rays and other stuff, like removing the triangles or lines used for the gartley,etc shapes.

Wonder if it could be fixed? Seems like the "Complet" function is not working that should allow layering, but just me guessing. If it is too lenghty to fix, not to worry. (I just made a few cosmetic modifications to the original version but has same problem.)

sincerely,

There was one error that could cause problems. Check it now : gann_sq9_mxi_nmc.mq4

Files:
gann_sq9_mxi_nmc.mq4  14 kb
 
mladen:
Change price for the low dots from Low[nnn] to High[nnn] And change the price for the upper dots from High[nnn] to Low[nnn]

Show me where ......

#property indicator_buffers 4

#property indicator_chart_window

#property indicator_color1 Turquoise

#property indicator_color2 Red

#property indicator_color3 Turquoise

#property indicator_color4 Red

double ExtMapBuffer1[];

double ExtMapBuffer2[];

double ExtMapBuffer3[];

double ExtMapBuffer4[];

//================================================================

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

//================================================================

int init()

{

IndicatorBuffers(4);

SetIndexStyle(0,DRAW_ARROW,STYLE_SOLID,2);

SetIndexStyle(1,DRAW_ARROW,STYLE_SOLID,2);

SetIndexArrow(0, 233);

SetIndexArrow(1, 234);

SetIndexBuffer(0,ExtMapBuffer1);

SetIndexBuffer(1,ExtMapBuffer2);

SetIndexStyle(2,DRAW_LINE);

SetIndexBuffer(2,ExtMapBuffer3);

SetIndexStyle(3,DRAW_LINE);

SetIndexBuffer(3,ExtMapBuffer4);

return(0);

}

void DrawVertical( int bar , double value, color clr)

{

static int cnt = 0;

cnt++;

string dv = "Signal" + cnt;

ObjectCreate(dv, OBJ_VLINE, 0, Time, 0);

ObjectSet(dv, OBJPROP_COLOR, clr);

ObjectsRedraw();

}

void DrawThumb( int bar , int thumb , double value, color clr)

{

static int cnt = 0;

cnt++;

string dv = "thumb" + cnt;

ObjectCreate(dv, OBJ_ARROW, 0, Time, value);

if(thumb == 1)

{

ObjectSet(dv, OBJPROP_ARROWCODE, 67);

}

if(thumb == 2)

{

ObjectSet(dv, OBJPROP_ARROWCODE, 68);

}

ObjectSet(dv, OBJPROP_COLOR, clr);

ObjectSet(dv, OBJPROP_STYLE , STYLE_SOLID);

ObjectSet(dv, OBJPROP_WIDTH , 3);

ObjectsRedraw();

}

int deinit()

{

int I = WindowsTotal();

for (int count = 0; count < WindowsTotal(); count++)

{

int nObjects = ObjectsTotal();

for (int i=nObjects; i>=0; i--)

{

string objName = ObjectName(i);

if(StringFind(objName, "Signal", 0) >= 0)

ObjectDelete(objName);

if(StringFind(objName, "signal", 0) >= 0)

ObjectDelete(objName);

}

}

return(0);

}

int start()

{

int counted_bars=IndicatorCounted();

//----

int pos = Bars - counted_bars;//-1

static int right = 0 ;

static int wrong = 0 ;

while (pos>=0)

{

Signal1=0;

Signal2=0;

Previous_Bar=0;

//================================================================

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

//================================================================

if (Open[pos+1] > Close[pos+1]) Previous_Bar = 1;

if (Open[pos+1] < Close[pos+1]) Previous_Bar = 2;

int confirm = 0;

if(confirm == 1)

{

if (EmaShortPrevious>EmaLongPrevious && EmaShortCurrent<EmaLongCurrent && Previous_Bar == 1) Signal1=High[pos-1];

if (EmaShortPreviousEmaLongCurrent && Previous_Bar == 2) Signal2=Low[pos-1];

}

else

{

if (EmaShortPrevious>EmaLongPrevious && EmaShortCurrent<EmaLongCurrent ) Signal1=High[pos-1];

if (EmaShortPreviousEmaLongCurrent ) Signal2=Low[pos-1];

}

ExtMapBuffer1[pos-1]= Signal1+5*Point;

ExtMapBuffer2[pos-1]= Signal2-5*Point;

if(Vertical_Lines)

{

if(Signal1>0) DrawVertical(pos,0,Blue);

if(Signal2>0) DrawVertical(pos,0,Red);

}

if (Show_Thumbs)

{

if(Signal1>0 && Open[pos-1] > Close[pos-1])

{

DrawThumb(pos-1,1,Signal1+20*Point,Gold);

right=right+1;

}

if(Signal1>0 && Open[pos-1] < Close[pos-1])

{

DrawThumb(pos-1,2,Signal1+20*Point,Green);

wrong=wrong+1;

}

if(Signal2>0 && Open[pos-1] < Close[pos-1])

{

DrawThumb(pos-1,1,Signal2-10*Point,Gold);

right=right+1;

}

if(Signal2>0 && Open[pos-1] > Close[pos-1])

{

DrawThumb(pos-1,2,Signal2-10*Point,Green);

wrong=wrong+1;

}

}

if(Draw_Lines)

{

ExtMapBuffer3[pos]= EmaLongCurrent;

ExtMapBuffer4[pos]= EmaShortCurrent;

}

pos--;

}

return(0);

}

 
popej30:
Show me where ......

#property indicator_buffers 4

#property indicator_chart_window

#property indicator_color1 Turquoise

#property indicator_color2 Red

#property indicator_color3 Turquoise

#property indicator_color4 Red

double ExtMapBuffer1[];

double ExtMapBuffer2[];

double ExtMapBuffer3[];

double ExtMapBuffer4[];

//================================================================

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

//================================================================

int init()

{

IndicatorBuffers(4);

SetIndexStyle(0,DRAW_ARROW,STYLE_SOLID,2);

SetIndexStyle(1,DRAW_ARROW,STYLE_SOLID,2);

SetIndexArrow(0, 233);

SetIndexArrow(1, 234);

SetIndexBuffer(0,ExtMapBuffer1);

SetIndexBuffer(1,ExtMapBuffer2);

SetIndexStyle(2,DRAW_LINE);

SetIndexBuffer(2,ExtMapBuffer3);

SetIndexStyle(3,DRAW_LINE);

SetIndexBuffer(3,ExtMapBuffer4);

return(0);

}

void DrawVertical( int bar , double value, color clr)

{

static int cnt = 0;

cnt++;

string dv = "Signal" + cnt;

ObjectCreate(dv, OBJ_VLINE, 0, Time, 0);

ObjectSet(dv, OBJPROP_COLOR, clr);

ObjectsRedraw();

}

void DrawThumb( int bar , int thumb , double value, color clr)

{

static int cnt = 0;

cnt++;

string dv = "thumb" + cnt;

ObjectCreate(dv, OBJ_ARROW, 0, Time, value);

if(thumb == 1)

{

ObjectSet(dv, OBJPROP_ARROWCODE, 67);

}

if(thumb == 2)

{

ObjectSet(dv, OBJPROP_ARROWCODE, 68);

}

ObjectSet(dv, OBJPROP_COLOR, clr);

ObjectSet(dv, OBJPROP_STYLE , STYLE_SOLID);

ObjectSet(dv, OBJPROP_WIDTH , 3);

ObjectsRedraw();

}

int deinit()

{

int I = WindowsTotal();

for (int count = 0; count < WindowsTotal(); count++)

{

int nObjects = ObjectsTotal();

for (int i=nObjects; i>=0; i--)

{

string objName = ObjectName(i);

if(StringFind(objName, "Signal", 0) >= 0)

ObjectDelete(objName);

if(StringFind(objName, "signal", 0) >= 0)

ObjectDelete(objName);

}

}

return(0);

}

int start()

{

int counted_bars=IndicatorCounted();

//----

int pos = Bars - counted_bars;//-1

static int right = 0 ;

static int wrong = 0 ;

while (pos>=0)

{

Signal1=0;

Signal2=0;

Previous_Bar=0;

//================================================================

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

// =============== HIDDEN CODE

//================================================================

if (Open[pos+1] > Close[pos+1]) Previous_Bar = 1;

if (Open[pos+1] < Close[pos+1]) Previous_Bar = 2;

int confirm = 0;

if(confirm == 1)

{

if (EmaShortPrevious>EmaLongPrevious && EmaShortCurrent<EmaLongCurrent && Previous_Bar == 1) Signal1=High[pos-1];

if (EmaShortPreviousEmaLongCurrent && Previous_Bar == 2) Signal2=Low[pos-1];

}

else

{

if (EmaShortPrevious>EmaLongPrevious && EmaShortCurrent<EmaLongCurrent ) Signal1=High[pos-1];

if (EmaShortPreviousEmaLongCurrent ) Signal2=Low[pos-1];

}

ExtMapBuffer1[pos-1]= Signal1+5*Point;

ExtMapBuffer2[pos-1]= Signal2-5*Point;

if(Vertical_Lines)

{

if(Signal1>0) DrawVertical(pos,0,Blue);

if(Signal2>0) DrawVertical(pos,0,Red);

}

if (Show_Thumbs)

{

if(Signal1>0 && Open[pos-1] > Close[pos-1])

{

DrawThumb(pos-1,1,Signal1+20*Point,Gold);

right=right+1;

}

if(Signal1>0 && Open[pos-1] < Close[pos-1])

{

DrawThumb(pos-1,2,Signal1+20*Point,Green);

wrong=wrong+1;

}

if(Signal2>0 && Open[pos-1] < Close[pos-1])

{

DrawThumb(pos-1,1,Signal2-10*Point,Gold);

right=right+1;

}

if(Signal2>0 && Open[pos-1] > Close[pos-1])

{

DrawThumb(pos-1,2,Signal2-10*Point,Green);

wrong=wrong+1;

}

}

if(Draw_Lines)

{

ExtMapBuffer3[pos]= EmaLongCurrent;

ExtMapBuffer4[pos]= EmaShortCurrent;

}

pos--;

}

return(0);

}

Check what values are assigned to Signal1 and Signal2 variables (the High and the Low at lines 130, 131, 135 and 136). Invert it

_____________

Btw: that indicator assignes values to future values

 
mladen:
Check what values are assigned to Signal1 and Signal2 variables (the High and the Low at lines 130, 131, 135 and 136). Invert it

_____________

Btw: that indicator assignes values to future values

Changed ... Thank you

1...466467468469470471472473474475476477478479480...790
New comment
Reason: