Discussion of article "Using Layouts and Containers for GUI Controls: The CBox Class" - page 2

New comment
 

This code doesn't compile. Build 1702.

'pipvaluecalculator.mq5' pipvaluecalculator.mq5 1 1

...

'm_client_area' - private member access error PipValueCalculator.mqh 118 60

'm_client_area' - private member access error PipValueCalculator.mqh 118 91

'm_client_area' - private member access error PipValueCalculator.mqh 129 72

'm_client_area' - private member access error PipValueCalculator.mqh 148 75

'm_client_area' - private member access error PipValueCalculator.mqh 168 77

'm_client_area' - private member access error PipValueCalculator.mqh 187 72

6 error(s), 0 warning(s) 7 1

As a side note, unless I missed it, you should specify where to place the files. We need to try and look at the code to know we need to create a "Layouts" folder in Include and to place Box.mqh file inside it.


 

I am using the build 1755.

Now the member m_client_area on class CDialog on Controls\Dialog.mqh is private and new methods were created to get Width and Height properties.

For me it works after the following changes.
a) replaced CDialog::m_client_area.Width()  by CDialog::ClientAreaWidth()
b) replaced CDialog::m_client_area.Height() by CDialog::ClientAreaHeight()
 
Alain Verleyen :

Kode ini tidak dikompilasi Bangun 1702

'pipvaluecalculator.mq5' pipvaluecalculator.mq5 1 1

...

'm_client_area' - kesalahan akses anggota pribadi PipValueCalculator.mqh 118 60

'm_client_area' - kesalahan akses anggota pribadi PipValueCalculator.mqh 118 91

'm_client_area' - kesalahan akses anggota pribadi PipValueCalculator.mqh 129 72

'm_client_area' - kesalahan akses anggota pribadi PipValueCalculator.mqh 148 75

'm_client_area' - kesalahan akses anggota pribadi PipValueCalculator.mqh 168 77

'm_client_area' - kesalahan akses anggota pribadi PipValueCalculator.mqh 187 72

6 error (s), 0 warning (s) 7 1

Jadi catatan, kecuali jika saya melewatkannya, anda harus menentukan di mana tempat file-file tersebut. Sebagai catatan, kecuali jika saya melewatkannya, Anda harus menentukan di mana menempatkan file-file tersebut. Kita perlu mencoba dan melihat kode untuk mengetahui bahwa kita perlu membuat folder "Layouts" di Include dan menempatkan file Box.mqh di dalamnya.Kita perlu mencoba dan melihat kode untuk mengetahui bahwa kita perlu membuat folder "Layouts" di Include dan menempatkan file Box.mqh di dalamnya.


 

I have encountered a problem with this useful add-on.

I ask for advice from those who know about standard controls.

Since this add-in with panels uses standard classes CWnd, CWndClient, I assume that knowledge of their internal structure may be enough to understand where the "dog is in the fight".

The essence of the problem. We take the Controls2.mq5 programme from the article (for compilation we also need ControlsDialog2.mqh and Box.mqh), compile it, run it.

Almost everything works fine except for the "datapicker". It only opens and closes, but in the open state it does not react to clicks, skipping events to the underlying controls.

The original similar demo from MQ (Experts/Examples/Controls.mq5) works with "datapicker" normally.

 
Stanislav Korotky:

Almost everything works fine except for the "datapicker". It only opens and closes, but in the open state it doesn't react to presses, skipping events to underlying controls.

The original similar demo from MQ (Experts/Examples/Controls.mq5) works with "datapicker" normally.

The question is removed. In CDatePicker there is no BringToTop call when the dropdown is expanded, as is done in CComboBox, for example. In the standard example, the CDatePicker works due to the fact that its initialisation was moved (intentionally or accidentally) after the creation of the "leafbox", which is topologically below it. And the controls in CWndContainer::OnMouseEvent are bypassed from the last added to the first.

To fix it normally, it would be necessary to override CDatePicker::ListShow, but it is not virtual. We have to redefine CDatePicker::OnClickButton and add BringToTop there. However, we cannot do it correctly as well as with any virtual method in the standard library, because all member variables are declared private. In particular, it is impossible to write:

bool MyDatePicker::OnClickButton(void) // override
{
    return ((m_drop.Pressed()) ? BringToTop() && ListShow() : ListHide());
}

because m_drop is not available. We have to call BringToTop both when opening and collapsing.

#include <Controls/DatePicker.mqh>

class CDatePickerFixed: public CDatePicker
{
  protected:
    virtual bool OnClickButton() override
    {
      BringToTop();
      return CDatePicker::OnClickButton();
    }
};
 

and there's a few mistakes:


 
Thank you for sharing
12
New comment