My script successfully compiles without any errors but won't submit a trade in the strategy tester, and my print function doesn't return a value. - page 3

New comment
 
Colin Kimble #: I assume that it's probably a very small issue that can get fixed without the dramatic effects .....

No, it is not a small issue. I am trying to be respectful, but it seems that you will not understand if I am soft with my words.

So, I will have to be harsh so that you can understand it ... Your code is a TOTAL MESS! Even a script kiddy could do better.

I am not trying to offend you, but it seems to be the only way for you to understand the reality of the situation.

So, please, follow my advice and learn your ABCs first. Learn the basics. Start small. Study other peoples code and read the book.

... Study the examples in the CodeBase, and read the MQL5 book already mentioned, while referencing the documentation.

Or ... hire someone in the Freelance section to code it for you.

 
Fernando Carreiro #:

No, it is not a small issue. I am trying to be respectful, but it seems that you will not understand if I am soft with my words.

So, I will have to be harsh so that you can understand it ... Your code is a TOTAL MESS! Even a script kiddy could do better.

I am not trying to offend you, but it seems to be the only way for you to understand the reality of the situation.

So, please, follow my advice and learn your ABCs first. Learn the basics. Start small. Study other peoples code and read the book.

... Study the examples in the CodeBase, and read the MQL5 book already mentioned, while referencing the documentation.

Or ... hire someone in the Freelance section to code it for you.

Can you name one error or warning on compiling from the script you took down (ie the most recent script I uploaded)? Are you here to actually help people or to fan your tiny ego?
 
Colin Kimble #:
Can you name one error or warning on compiling from the script you took down (ie the most recent script I uploaded)? Are you here to actually help people or to fan your tiny ego?

you, very badly -- NEED TO WATCH THE VIDEO AGAIN.

I watched part of the video, and he describes in great details about handles and copybuffer. This is the last comment that I will make on this thread. It is waste of our time to spend on a newbie that only wants to argue.

 
Colin Kimble #: Can you name one error or warning on compiling from the script you took down (ie the most recent script I uploaded)? Are you here to actually help people or to fan your tiny ego?

You are being argumentative and arrogant. You are the one that does not want to learn.

The post that violated the forum rules, was duplicated in post #16, and includes the the attached source code.

I have already indicated one of the major errors in your code in my post #12. In a follow-up post and code, you stated that you fixed it, but unfortunately the changes you carried out were only artificial and did not correct the main issue.

You are still committing the same mistakes ..

// This is the calculations for the moving averages for the 0 index (daily time frame)
   if(iMA(NULL,PERIOD_CURRENT,10,0,MODE_SMA,PRICE_CLOSE) < iOpen(NULL,PERIOD_CURRENT,0))
if(iADX(NULL, PERIOD_CURRENT, 14) > 20 && ADX_PlusDIPrevious < ADX_MinusDIPrevious && ADX_PlusDICurrent > ADX_MinusDICurrent)

In other places where you tried to correct it, you are totally messing up the logic of the functions ...

if((CopyBuffer(RSI1,0,1,5,RSI_Array1)) > (CopyBuffer(RSI1,0,2,5,RSI_Array1)))
if((CopyBuffer(CCI1,0,1,5,CCI_Array_1)) > (CopyBuffer(CCI1,0,2,5,CCI_Array_1)))

In general, your code is very "stringy" and the logic very "messy". It is really bad.

I have tried to point you in the correct direction, but you have done everything to resist. It seems you are not ready to accept the advice, so this will be my last post to you.

Any further disruption, will have this whole topic removed and your account temporarily banned.

Follow the advice given ...

Study the examples in the CodeBase, and read the MQL5 book, while referencing the documentation, or hire someone in the Freelance section to code it for you.

 
Colin Kimble #:
I assume that it's probably a very small issue that can get fixed without the dramatic effects .....

As Fernando pointed out, there are very many logic errors in your code. The one that sticks out most to me is that you assume that CopyBuffer returns data, whilst it actually returns a count of the number of bytes returned by the indicator - this assumption messes up all logic where you use CopyBuffer.

For instance:

   double Stochastic1_Array[];
   double Stochastic_MainLineCurrent1, Stochastic_SignalLineCurrent1;
   double Stochastic_MainLinePrevious1, Stochastic_SignalLinePrevious1;
   
  
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
   Stochastic_MainLineCurrent1 = CopyBuffer(Stochastic_handle1,MAIN_LINE,0,0,Stochastic1_Array);
   Stochastic_SignalLineCurrent1 = CopyBuffer(Stochastic_handle1,SIGNAL_LINE,0,0,Stochastic1_Array);
   Stochastic_MainLinePrevious1 = CopyBuffer(Stochastic_handle1,MAIN_LINE,1,0,Stochastic1_Array);
   Stochastic_SignalLinePrevious1 = CopyBuffer(Stochastic_handle1,SIGNAL_LINE,1,0,Stochastic1_Array);

   if(Stochastic_MainLinePrevious1 < Stochastic_SignalLinePrevious1 && Stochastic_MainLineCurrent1 > Stochastic_SignalLineCurrent1 && Stochastic_MainLineCurrent1 < 20)
     {
      GetTotalResultNineteen1 = 1; // Buy: Main line crossed above signal line and is below 20
     }
   else
      if(Stochastic_MainLinePrevious1 > Stochastic_SignalLinePrevious1 && Stochastic_MainLineCurrent1 < Stochastic_SignalLineCurrent1 && Stochastic_MainLineCurrent1 > 80)
        {
         GetTotalResultNineteen1 = -1; // Sell: Main line crossed below signal line and is above 80
        }

Could be done like this, with two buffers and two calls to CopyBuffer.

   double Stochastic_Main[];
   double Stochastic_Signal[];
   ArraySetAsSeries(Stochastic_Main, true);
   ArraySetAsSeries(Stochastic_Signal, true);
   
   if(CopyBuffer(Stochastic_handle1, MAIN_LINE, 0, 2, Stochastic_Main) < 2 || 
      CopyBuffer(Stochastic_handle1, SIGNAL_LINE, 0, 2, Stochastic_Signal) < 2)
   {
      Print("Failed to read Stochastic indicator buffer");
      return;
   }
   
   if(Stochastic_Main[1] < Stochastic_Signal[1] && 
      Stochastic_Main[0] > Stochastic_Signal[0] && 
      Stochastic_Main[0] < 20)
   {
      GetTotalResultNineteen1 = 1; // Buy: Main line crossed above signal line and is below 20
   }
   else if(Stochastic_Main[1] > Stochastic_Signal[1] && 
           Stochastic_Main[0] < Stochastic_Signal[0] && 
           Stochastic_Main[0] > 80)
   {
      GetTotalResultNineteen1 = -1; // Sell: Main line crossed below signal line and is above 80
   }
 
ceejay1962 #:

As Fernando pointed out, there are very many logic errors in your code. The one that sticks out most to me is that you assume that CopyBuffer returns data, whilst it actually returns a count of the number of bytes returned by the indicator - this assumption messes up all logic where you use CopyBuffer.

For instance:

Could be done like this, with two buffers and two calls to CopyBuffer.

Thank you for helping me
 

The OP has been banned for one day and their most recent post has been removed with the message: "Abusive, insulting or offensive language or imagery will not be tolerated."

I encourage the OP to consider being less argumentative, if they truely want to learn to properly program in MQL5.

 
ceejay1962 #:

As Fernando pointed out, there are very many logic errors in your code. The one that sticks out most to me is that you assume that CopyBuffer returns data, whilst it actually returns a count of the number of bytes returned by the indicator - this assumption messes up all logic where you use CopyBuffer.

For instance:

Could be done like this, with two buffers and two calls to CopyBuffer.

Hey Dude! Thanks for the previous assistance, do you know what usually causes the 4804, "The indicator cannot be applied to another indicator" error?

My EA I designed compiles successfully without any errors or warning, when I tested it in the strategy tester, all the other indicators loaded expected for the MA, RSI, CCI and Momentum indicators. Does anyone know what might have caused the, "Cannot load indicator[4804] error?

Thanks for everything.

Files:
Trendfollowing.mq5  38 kb
Screenshot_77y.png  170 kb
 
Colin Kimble #:

Hey Dude! Thanks for the previous assistance, do you know what usually causes the 4804, "The indicator cannot be applied to another indicator" error?

My EA I designed compiles successfully without any errors or warning, when I tested it in the strategy tester, all the other indicators loaded expected for the MA, RSI, CCI and Momentum indicators. Does anyone know what might have caused the, "Cannot load indicator[4804] error?

Thanks for everything

I ran your code, and didn't see that error. I think it means that the parameters in the indicator call are wrong.

However, I did see a couple of array access issues:

In two places the call to copybuffer reads 2 buffers, when it should read 4 according to how you access the array (AOOneMinute[3] causes an array access error).

Personally, when I write an EA, I prefer to separate the indicator mechanics from the trading logic. I usually have  a ReadIndicators() function in the OnTick() loop that does all the CopyBuffer calls. It is easier for debugging and maintenance.

For example - there is another block of code that does the same. 

if(CopyBuffer(AwesomeOS1, MAIN_LINE, 0, 
2 , AOOneMinute) < 
2 )
     {
      Print("Failed to read AO indicator buffer");
      return;
     }
   if((AOOneMinute[0] > 0) && (AOOneMinute[1] < 0) && (AOOneMinute[2] < AOOneMinute[3]))
     {
      GetTotalResultTwentyTwo1 = 1;
     }
   else
      if((AOOneMinute[0] < 0) && (AOOneMinute[1] > 0) && (AOOneMinute[2] > AOOneMinute[3]))
        {
         GetTotalResultTwentyTwo1 = -1;
        }
 
ceejay1962 #:

I ran your code, and didn't see that error. I think it means that the parameters in the indicator call are wrong.

However, I did see a couple of array access issues:

In two places the call to copybuffer reads 2 buffers, when it should read 4 according to how you access the array (AOOneMinute[3] causes an array access error).

Personally, when I write an EA, I prefer to separate the indicator mechanics from the trading logic. I usually have  a ReadIndicators() function in the OnTick() loop that does all the CopyBuffer calls. It is easier for debugging and maintenance.

For example - there is another block of code that does the same.

You are an absolute blessing, thank you so much!

1234
New comment