Write more than 300 lines to csv file

[Robin Jones]

I am trying to write to a csv file, but can't write past 280 lines. I am trying to write upto 2400 or more lines, only one double per line. 

The lines in the file are scores related to same  line number in another file the same size.

I read in the scores, modify them then write them all back in. As far as I can tell I can read the whole file, I assume I am writing

the whole file back in as the file is replaced (overwritten) each time. I write the array then the array is written to the file

using a loop. Lines below 280 are updated fine, after that they remain unchanged at 0.07, the default  number in the file.

Buy_Pattern_score[2400][1]  and var_arrayB00[2400][1]  are both  int and declared in global scope.

Before you ask the array is a 2D array because I want one score per line in the scv file as they must correspond with the other csv file line number.

             //------------------------------------------------------------------------ 
             // Read the Pattern Scores into a array
             int Handle_5 = FileOpen("Buy_Pattern_score.csv",FILE_CSV|FILE_READ, ',');           
                for (int col = 0; col < 2400; col++)
                    {
                    Buy_Pattern_score[col][0] = FileReadString(Handle_5);          
                    }                                                 
                FileClose(Handle_5);

               int next_c;
               for (int dt = 0 ;dt < 2400; dt++)
                    {  
                    for (int jk = 0 ;jk < 32; jk++)
                       {                                                  
                       int B_cur = hist_state_b[jk];
                       int B_his = buy_line_read[dt][jk];
                         
                  if  ((B_cur == B_his) ||
                       (B_cur + 16 == B_his) || (B_cur - 16 ==  B_his) ||
                       (B_cur + 32 == B_his) || (B_cur - 32 ==  B_his))
                          {
                           next_c++;
                          }
                        }
                        if (next_c >= threshold) // 30 
                          {   
                           line_no_b = dt;
                          }
                           next_c = 0;
                    }
                             
             
             // write the pattern score
             Handle_5 = FileOpen("Buy_Pattern_score.csv",FILE_CSV|FILE_WRITE, ',');
             double tmp = 0;
             double var = 0; 
             for (int mk = 0; mk < 2400; mk++) // row 1
                 {         
                    var = Buy_Pattern_score[mk][0];                                                                    
                    if (profit_b == 1) {w_l = 0.2*win_factor;} else if (profit_b == 0) {w_l = 0.05*-1;}                   
                    if (line_no_b == mk){tmp = NormalizeDouble((var+w_l)*1*1*0.97,3);} else tmp = var;                                                                                 
                    var_arrayB00[mk][0] = tmp;
                    FileWrite(Handle_5,var_arrayB00[mk][0]);                               
                 }                                
                    FileClose(Handle_5);
             //----------------------------------------------------------------------

An example of six lines of the Buy_Pattern_score.csv file

0.828
0.141
-0.13
0.04
0.27
0.07 

I would really appreciate some help or advice. I have scoured the forum, searched the documentation, not understood some things.

I'm sure there is always an answer , mostly simple explanation and a solution to this.

I would like to read and write all 2400 lines in the file. I do this again in the EA a few times, different files.

Thanks in advance.

[lippmaje]

When you are dealing with doubles in your array and the csv file, you should use FileReadNumber instead of FileReadString.

You are probably not reading enough values from the file. You don't check for end of file and are trying to access 2400 elements in your array regardless of its size.

I'd add a '#property strict' before going on.

By the way your code is poorly formatted and variables are not named consistently. You're probably having a lot of issues elsewhere.

[Robin Jones]

Thanks for your reply.

I tried FileReadNumber() elsewhere in my code with no difference, but will try it here. I have also used FileIsEnding(), this never works for me, I've also read it has some bug.

I should mention that it reads fine as I can Print() any line number no problem, also when you Write, it deletes the file and overwrites, the file file is the same as before except

for a few updated scores below line 300. You are right there is a lot of room for improvement, but everything else works fine.

The thing is that everything works fine upto line 300, but not further, so that is the real issue.

[lippmaje]

Did you notice you never initialized next_c?

               int next_c;

Use property strict and fix all warnings before going on.

[Robin Jones]

If you don't initialize then next_c is 0 by default. Anyway Strict does not seem to care.  It counts fine. That is not where my issue is.

[Keith Watford]

Robin:
If you don't initialize then next_c is 0 by default. Anyway Strict does not seem to care.  It counts fine. That is not where my issue is.

Where do you get that idea from?

https://www.mql5.com/en/docs/basis/variables/initialization

Any variable can be initialized during definition. If a variable is not initialized explicitly, the value stored in this variable can be any. Implicit initialization is not used.

[Robin Jones]

Thanks Keith, "Missed initializing sequences are considered equal to 0." I did'nt read properly... relates to arrays!

Appreciate the advice. As far as I can tell this wont affect my actual problem, but will no doubt improve my code.