Discussion of article "Indicator for Renko charting" - page 4

 
I suggest that in articles: STRICTLY FORBID code fragments over 15 lines and LIMIT the total length of copypaste from code to article to 50 lines. Including comments on the line

all the same code in pieces is not considered and is attached to the article as an archive. Unobvious things can be underlined, but you should have a conscience - initialisation of an Expert Advisor/Inducer in an article is something with something....
 

Speaking of which, the other pictures in the article are also confusing. For example, here


how some boxes have formed shadows in the same direction with the length exceeding the box size? According to the renko definition, if the price has passed more than the box size, the next box should be formed. Well, the boxes, in principle, were formed on the chart, but the shadows can be "cast" only in the direction opposite to the direction of the box - and here they all go the other way round.

 
Stanislav Korotky:

Speaking of which, the other pictures in the article are also confusing. For example, here


how some boxes have formed shadows in the same direction with the length exceeding the box size? According to the renko definition, if the price has passed more than the box size, the next box should be formed. Well, the boxes, in principle, were formed on the chart, but the shadows can only be "cast" in the direction opposite to the direction of the box - and here they all go the other way round.

If you look at the parameters, the shadows are:

input bool             shadow_print=true;                       // Whether to show shadows (prices that create multiple bricks at once)

That is, if one candle is very large, its size is indicated in the shadow. This is only necessary to know which boxes are formed by one candle (one period).

 
Maxim Kuznetsov:
I suggest that in articles: STRICTLY FORBID code fragments over 15 lines and LIMIT the total length of copypaste from code to article to 50 lines. Including comments on the line

all the same code in pieces is not considered and is attached to the article as an archive. Unobvious things can be underlined, but you should have a conscience - initialisation of an EA/instrument in an article is something with something....
In my opinion, this question should be asked to moderators, or in the appropriate thread on various improvements, as well as you can create a poll on this topic and see how it will be to everyone's liking.
 
Stanislav Korotky:

Why are the up (crimson) and down (orange) squares marked with question marks below not formed? There the price has passed the size of the box in the previous direction.

In this figure from the article, I don't remember what the parameters were for the plotting, but most likely default.

That is :

input type_price_renko type_price=close;                        // Type of price to be built

This means that the plotting will only be done at closing prices, that is, regardless of the highest price.

Yes, I agree that this is not quite correct with respect to the classical theory, but it can be corrected by changing the calculation period, i.e. take the H1 chart and in the time_frame settings (see below), set M1.

input ENUM_TIMEFRAMES  time_frame=PERIOD_CURRENT;               // Calculation period
 
Dmitriy Zabudskiy:

That is, if one candle is very large, its size is indicated in the shadow. It is necessary only to know which boxes are formed by one candle (one period).

I see. So this is a special modification of renko.
 

Hello guy:

I downloaded your indicator, but it seems to work not well, you can see from the picture what was happening.



I run this indicator at Roboforex's MT5, but it can not display like the picture that you uploaded, I mean I wanna wanna see the renko box on the charting of a timeframe just like this .

图例.4. 参数对 "zig_zag_shadow" 的影响 EURUSD, H1, 10 点。


Can you tell me how to make this indicator works normally ? Thank you very much .

 
This is not displaying properly.
 

ABCR works perfectly on MT5. I'm currently using it with the WINV17 mini index. The only change I made was to recompile and change the start date from 2013 to 2017, so it loaded faster.

 

The indicator is working perfectly. But I can't change the colour of the levels to None (clrNONE / -1), even if I change it directly in the code. I think the function would be this:

IndicatorSetInteger(INDICATOR_LEVELCOLOR,z,level_colour);