Coding is actually about applying logic and "creating a solution" - Expert Advisors and Automated Trading

Fernando Carreiro 2018.10.04 11:58 #31

Bostock58: I would have thought this was really simple coding problem to solve and yet I can find nothing on how it could be done...?

Coding is not actually about "finding" a solution, but rather about applying logic and "creating" a solution. Coding is not about copy/pasting "pieces" of code.

Think about it as "painting", where you first lean the basics of the craft (the code language structure) and the various tools (functions and libraries) that you can use. Then with practice and research you slowly learn how to apply that knowledge in a step-by-step method in order to "paint" (define the logic) of the what you want to achieve.

That is why many times, the questions that newbie coders ask here on the forum are not easy to answer, because it requires that the one that decides to answer, to actually do the work of thinking out the logic that is required in order to achieve the solution.

The original poster then receives a completed "picture" but does not understand how the "picture" was constructed or what the steps where that coder used to get to that answer. And so, the poster gets his answer, but learns very little about the process, and then has to come back with yet another request for another problem, because he has still not learned the process, the logic, of how to "create" solutions on his own, nor has he taken the time to learn the basic structure of the language nor does he understand what every available function does nor what libraries he has at his disposal.

EA Move sl to $600-$800 week ? Questions from Beginners MQL5

Bostock58 2018.10.04 13:09 #32

I am still unable to start my picture as I cannot get clarification on simple coding logic. I am not looking for anyone to develop my 'logic path' or provide code, only how the code functions. I think I already have enough MQL4 language skills to complete the finished picture except I am missing one very small piece. I am happy to be pointed at a suitable resource but it must be relevant to my problem, suggestions of looking in the 'code base' dont help at all, I have already done that, how do you look up something you dont know?

I have researched every suggestion I have been give but have found nothing on how to code multiple logic gates (if statements), I have no idea why this is such a secret.

memory leak in build Counting Partial Close for Fire EA: Can you

Fernando Carreiro 2018.10.04 13:39 #33

Bostock58:

I am still unable to start my picture as I cannot get clarification on simple coding logic. I am not looking for anyone to develop my 'logic path' or provide code, only how the code functions. I think I already have enough MQL4 language skills to complete the finished picture except I am missing one very small piece. I am happy to be pointed at a suitable resource but it must be relevant to my problem, suggestions of looking in the 'code base' dont help at all, I have already done that, how do you look up something you dont know?

I have researched every suggestion I have been give but have found nothing on how to code multiple logic gates (if statements), I have no idea why this is such a secret.

Then what specifically are you having trouble with? Which functionality or logic are you stuck on? Be precise and be detailed!

Its not a secret! We just don't understand what it is you want to know! An "if" statement is quite basic, so we don't understand what your difficulty is with it.

Moving Average Capturing a lagging indicator [Archive!] Pure mathematics, physics,

Bostock58 2018.10.04 15:07 #34

OK I will try again,

I have several "if" statements that must run in sequence to get to the desired end function if all true OR move on if false.

What I dont want is every "if" statement read and end function completed regardless of any true or false conditions on every tick.

Multiple OR statements Precedence under MQL5 is a new variable/constant

Fernando Carreiro 2018.10.04 16:03 #35

Bostock58: OK I will try again, I have several "if" statements that must run in sequence to get to the desired end function if all true OR move on if false.

What I dont want is every "if" statement read and end function completed regardless of any true or false conditions on every tick.

Sorry. but you will have to be more clear about what it is you mean. It may be easier if show the code with lots of comments to try explain what it is you are trying to achieve.

Anthony Garot 2018.10.04 16:34 #36

Bostock58:

I have several "if" statements that must run in sequence to get to the desired end function if all true OR move on if false.

What I dont want is every "if" statement read and end function completed regardless of any true or false conditions on every tick.

It may help if you break your conditionals down into boolean variables.

For example:

bool condition1 = (high[i] > high[i-1]);
bool condition2 = (low[i] > low[i-1]);
bool condition3 = (ATR[i] > ATR[i-1]);
bool condition4 = (volume[i] > volume[i-1]);

Then you can see the encompassing conditional more easily:

if ( condition1 && condition2 && condition3 && condition4 )
{
    // true: do something
}
else
{
    // false: move on
}

Bostock58 2018.10.04 19:09 #37

OK

I have an indicator which I will call from the EA, it produces an up or down arrow output.

When an up arrow signal is received at the close of a candle.

1) I am looking at the next candle building

2) If the price moves up by 4 points I enter a trade.

3) If the price doesn't move by 4 points but is more than 2 points up at close of candle I enter a trade.

4) I need to add something to confirm the close of the candle.

5) If neither occur I look at the next candle in the same way

6) If the price moves up by 4 points I enter a trade.

7) If the price doesn't move by 4 points but is more than 2 points up at close of candle I enter a trade.

8) If neither happens again, the signal is dead and I wait for another.

(The same for a down arrow signal)

So

if(Close[i]-Close[i+1]>=4)

{take trade}

if(rates_total!=prev_calculated)//new candle 1

if(Close[i+1]-Close[i+2]>=2)//closed candle 1

{take trade}

if(Close[i]-Close[i+2]>=4)//new candle 2

{take trade}

if(rates_total!=prev_calculated)//new candle 2

if(Close[i+1]-Close[i+2]>=2)//closed candle 2

{take trade}

wait for next signal.

Daily high/low reversal EA Using iCustom in Strategy Daily high/low reversal EA

Fernando Carreiro 2018.10.04 19:38 #38

Bostock58:

OK

I have an indicator which I will call from the EA, it produces an up or down arrow output.

When an up arrow signal is received at the close of a candle.

1) I am looking at the next candle building

2) If the price moves up by 4 points I enter a trade.

3) If the price doesn't move by 4 points but is more than 2 points up at close of candle I enter a trade.

4) I need to add something to confirm the close of the candle.

5) If neither occur I look at the next candle in the same way

6) If the price moves up by 4 points I enter a trade.

7) If the price doesn't move by 4 points but is more than 2 points up at close of candle I enter a trade.

8) If neither happens again, the signal is dead and I wait for another.

(The same for a down arrow signal)

So

if(Close[i]-Close[i+1]>=4)

{take trade}

if(rates_total!=prev_calculated)//new candle 1

if(Close[i+1]-Close[i+2]>=2)//closed candle 1

{take trade}

if(Close[i]-Close[i+2]>=4)//new candle 2

{take trade}

if(rates_total!=prev_calculated)//new candle 2

if(Close[i+1]-Close[i+2]>=2)//closed candle 2

{take trade}

wait for next signal.

EDIT: I just realised that I am unsure if you describing the logic for an Indicator or for a Expert Advisor, because you mixing concepts of both.

So, we need to establish this. You cannot mix Indicator an EA code. They must be coded separately. An Indicator cannot have any trading functions.

Please ignore the following until we separate things and decide what is part of the Indicator and what is part of the Expert advisor.

...

Lets take things one step at a time. The first, is how to detect when a new bar has opened (or the previous one closed) in an Expert Advisor. Here is the code which you can place at the beginning of the OnTick() event handler in your EA:
void OnTick()
{
   // Check for New Bar (Compatible with both MQL4 and MQL5)
   static datetime dtBarCurrent = WRONG_VALUE;
   datetime dtBarPrevious = dtBarCurrent;
   dtBarCurrent = (datetime) SeriesInfoInteger( _Symbol, _Period, SERIES_LASTBAR_DATE );
   boolNewBarFlag = ( dtBarCurrent != dtBarPrevious );

   if( boolNewBarFlag )
   {
      // Do something ...
   }
   else
   {
      // Do something else ...
   }

   // Do things ...
}
Now use the above code and adjust your requirements in your previous post. Show real code and not pseudo code so that we can detect when you do something incorrectly.

PS! Lookup the functions used in the above code in the documentation so that you understand what it does and how it works.

Automatically log all account Object Text Delete Unable to load product

Bostock58 2018.10.05 15:13 #39

Although I am ultimately writing an EA I was trying to get the logic to work in an indicator first which provides outputs to test. So in this case the 'take trade' could be an arrow on the chart or a comment.

With regards to the new candle indication, my attempt was,

int time1=TimeMinute(TimeCurrent());
double Min=(0);
Min=time1%=5;
if(Min<1)//new candle formed.

The problem is having it in the right place to be effective.

Of course this only works on the 5min time scale, so your solution would be fool proof.

How to only open iVolume Question How to stop repainting

Fernando Carreiro 2018.10.05 16:00 #40

Bostock58:

Although I am ultimately writing an EA I was trying to get the logic to work in an indicator first which provides outputs to test. So in this case the 'take trade' could be an arrow on the chart or a comment.

With regards to the new candle indication, my attempt was,

int time1=TimeMinute(TimeCurrent());
double Min=(0);
Min=time1%=5;
if(Min<1)//new candle formed.

The problem is having it in the right place to be effective.

Of course this only works on the 5min time scale, so your solution would be fool proof.

Indicators and EAs work completely differently, so we need to separate things.

In Indicators, we should not use the "New Bar" functionality at all, because of the why the OnCalculate() works.

In EAs you can use my method of the new bar. Don't use your method because bars do not necessarily always form based on time. If there is no activity, bars will be skipped and the current bar will remain open until a new tick arrives.

In Indicators, values are kept in running buffers, which can be recalculated at any time the system triggers a new recalculation cycle, so you have to think in those terms.

The arrows for the Up or Down will also be stored in these buffers.

So, I ask you to show your complete code as you have at the moment. Attach your Indicator ".mq4" file so we can see what you have done till now.

Simple green bar testing How to recalculate indicator Yet again: iCustom returns

Candle Indication - page 4