Working with Historical Trades for MQL5 - Post any problem ?

[Young Ho Seo]

Dear Coder

Since the migrants to MQL5 language, there are many differences in the coding structure to work with historical trades in mql5 language.

Here I would like to discuss any problem related to Historical Trades.

I just simply feel this is necessary because the History Deal structure from MQL5 language is quite confusing.

I am little scared to use it because some simple works in mql4 seems not straight forwards any more in mql5.

For example, I want find out the profit for buy trades.

In MQL4, this can be done like this. Profit for sell trades can be done easily just changing orderType == 1.

   
   double profit = 0.0;

   for (int i=0; i<OrdersHistoryTotal(); i++)
   {
       if(OrderSelect(i, SELECT_BY_POS, MODE_HISTORY))
       {
             int      orderTicket = (int)OrderTicket();
             string   orderSymbol = OrderSymbol();
             int      orderType  = (int) OrderType();
             
             if(orderType == 0)
             {
                 profit = profit + OrderProfit();          
             }

        }
    }

 

In mql5 language, it seems even difficult to deal with this simple task.

What is the best way to safely get profit for buy or sell trades only ?

I can think of something like this. But there is too much risk of using HistoryDealGetInteger structure.

Because there are chances, DEAL_ENTRY can be DEA_ENTRY_INOUT or DEAL_ENTRY_OUYBY, etc.

Plus orderType is also opposite in mql5.com ?

What would be developer's mind to migrate the absolutely easy historical trades structure mql4 language to something less safe and more difficult to use.

I am really curious on this.

Sharing your thought on this issue will be really appreciated.

Kind regards.

   
   for (int i=0; i<HistoryDealsTotal(); i++)
   {
  
      {
      
         int      orderTicket = (int)HistoryDealGetTicket(i);
         string   orderSymbol = HistoryDealGetString(orderTicket,DEAL_SYMBOL);
         int      orderEntry  = (int)HistoryDealGetInteger(orderTicket, DEAL_ENTRY);
         int      orderType  = (int)HistoryDealGetInteger(orderTicket, DEAL_TYPE);

         
         if(orderType == 0) ??

      }

   }

[fxsaber]

#include <MT4Orders.mqh> // https://www.mql5.com/en/code/16006

   double profit = 0.0;

   for (int i=0; i<OrdersHistoryTotal(); i++)
   {
       if(OrderSelect(i, SELECT_BY_POS, MODE_HISTORY))
       {
             int      orderTicket = (int)OrderTicket();
             string   orderSymbol = OrderSymbol();
             int      orderType  = (int) OrderType();
             
             if(orderType == 0)
             {
                 profit = profit + OrderProfit();          
             }

        }
    }

Now it will work on MQL5.

[Young Ho Seo]

fxsaber:
Now it will work on MQL5.

Looks quite convenient though.

Thanks for your link.

[fxsaber]

https://www.mql5.com/en/blogs/post/689072

https://www.mql5.com/en/blogs/post/681230

https://www.mql5.com/ru/articles/3068

[Young Ho Seo]

fxsaber:

https://www.mql5.com/en/blogs/post/689072

https://www.mql5.com/en/blogs/post/681230

https://www.mql5.com/ru/articles/3068

Great stuffs. :)