Download MetaTrader 5
To add comments, please log in or register
Post web links to other trader's signals and make profit
MeVsRacoon
39
MeVsRacoon 2014.01.31 12:13 
#define SIGNAL_NONE 0
#define SIGNAL_BUY   1
#define SIGNAL_SELL  2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

#property copyright "Yo, What's up"
#property link      "Yo, What's up?"

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 1.0;
extern int Slippage = 3;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 60;
extern bool UseTrailingStop = True;
extern int TrailingStop = 30;

int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init() {
   BarCount = Bars;

   if (EachTickMode) Current = 0; else Current = 1;

   return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit() {
   return(0);
}
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() {
   int Order = SIGNAL_NONE;
   int Total, Ticket;
   double StopLossLevel, TakeProfitLevel;



   if (EachTickMode && Bars != BarCount) TickCheck = False;
   Total = OrdersTotal();
   Order = SIGNAL_NONE;

   //+------------------------------------------------------------------+
   //| Variable Begin                                                   |
   //+------------------------------------------------------------------+

double Var1 = So=iClose(Symbol(), PERIOD_H1,1);
double Var2 = ExD=So*0.9;
double Var3 = ExU=So*2;

double Buy1_1 = ExD;
double Buy1_2 = iOpen(NULL, 0, Current + 0);

double Sell1_1 = ExU;
double Sell1_2 = iOpen(NULL, 0, Current + 0);

double CloseBuy1_1 = ExU;
double CloseBuy1_2 = iOpen(NULL, 0, Current + 0);

double CloseSell1_1 = ExD;
double CloseSell1_2 = iOpen(NULL, 0, Current + 0);

   
   //+------------------------------------------------------------------+
   //| Variable End                                                     |
   //+------------------------------------------------------------------+

   //Check position
   bool IsTrade = False;

   for (int i = 0; i < Total; i ++) {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if(OrderType() <= OP_SELL &&  OrderSymbol() == Symbol()) {
         IsTrade = True;
         if(OrderType() == OP_BUY) {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Buy)                                           |
            //+------------------------------------------------------------------+

                     if (CloseBuy1_1 < CloseBuy1_2 && False) Order = SIGNAL_CLOSEBUY;


            //+------------------------------------------------------------------+
            //| Signal End(Exit Buy)                                             |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if(Bid - OrderOpenPrice() > Point * TrailingStop) {
                  if(OrderStopLoss() < Bid - Point * TrailingStop) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         } else {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Sell)                                          |
            //+------------------------------------------------------------------+

                     if (CloseSell1_1 > CloseSell1_2) Order = SIGNAL_CLOSESELL;


            //+------------------------------------------------------------------+
            //| Signal End(Exit Sell)                                            |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
                  if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         }
      }
   }

   //+------------------------------------------------------------------+
   //| Signal Begin(Entry)                                              |
   //+------------------------------------------------------------------+

   if (Buy1_1 > Buy1_2) Order = SIGNAL_BUY;

   if (Sell1_1 < Sell1_2) Order = SIGNAL_SELL;


   //+------------------------------------------------------------------+
   //| Signal End                                                       |
   //+------------------------------------------------------------------+

   //Buy
   if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                                Print("BUY order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
                        } else {
                                Print("Error opening BUY order : ", GetLastError());
                        }
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   //Sell
   if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                                Print("SELL order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
                        } else {
                                Print("Error opening SELL order : ", GetLastError());
                        }
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   if (!EachTickMode) BarCount = Bars;

   return(0);
}

Currently, I am testing this EA.

There is one issue that either Buy or Sell, need to place base upon current price movement not only open price.

And also could you add that how to ignore same place order

ex) current order is Buy, then ignore next Buy signal but activate next Sell signal.

I will really appreciate that your help.

-Racoon.

Keith Watford
Moderator
7906
Keith Watford 2014.01.31 12:59  

I do not know what you are asking.

There is one issue that either Buy or Sell, need to place base upon current price movement not only open price.

Everyone has different ideas of how to interpret current price movement, you need to explain what YOU mean.

And also could you add that how to ignore same place order

This is gibberish. I don't understand.

ex) current order is Buy, then ignore next Buy signal but activate next Sell signal.

Check that there is not a buy trade currently open before opening a new buy trade

Tjipke de Vries
6277
Tjipke de Vries 2014.01.31 13:27  
MeVsRacoon:

Currently, I am testing this EA.

There is one issue that either Buy or Sell, need to place base upon current price movement not only open price.

And also could you add that how to ignore same place order

ex) current order is Buy, then ignore next Buy signal but activate next Sell signal.

I will really appreciate that your help.

-Racoon.


does it compile ???

guess not ..... what testing result will you have ??

what i see here is that you don't know what you're doing how can we help ??

if you haven't learned the basics...

MeVsRacoon
39
MeVsRacoon 2014.02.07 11:11  

Thanks for your comments. I figured it out and updated.

It is simple strategy but, this EA needs some advice.

Because it does not open any trade.

Any ideas?

//+------------------------------------------------------------------+
//|                                                   Inquiry.mq4 |
//|                               Copyright 2014, Yo |
//|                                                                  |
//+------------------------------------------------------------------+

#property copyright "Copyright 2014, Yo"
#property link      ""


extern double Lots = 0.05;
extern double MA_PERIOD=15;

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
double So=iClose(Symbol(), PERIOD_H1,1);
double Highbid=High[iHighest(NULL,0,MODE_HIGH,15,0)];
double Lowbid =Low [iLowest(NULL,0,MODE_LOW,15,0)];
double a=Highbid/Lowbid;
double ExD=So*0.9+a;
double ExU=So*1.1+a;


double ask=MarketInfo(Symbol(),MODE_ASK);
double bid=MarketInfo(Symbol(),MODE_BID);                      
int cnt, ticket, total;
if(Bars<100)
{
Print("bars less than 100");
return(0);
}


//----
total=OrdersTotal();
if(total<1)
{
if(AccountFreeMargin()<(1000*Lots))
{
Print("We have insufficent fund.Free Margin=",AccountFreeMargin());
return(0);

//Buy Order
if(ExD>bid)
{
ticket=OrderSend(Symbol(),OP_BUY, Lots, Ask, 50,0,0,"Exp_UP",16384,Green);
  if(ticket>0)
  {
  if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
  Print("Buy order opened:",OrderOpenPrice());
  }
  else
  Print("Error opening BUY order:",GetLastError());
  return(0);
  
  
  //Sell Order
  if(ExU<ask)
  {
  ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,50,0,0,"Exp_DOWN",16384,0,Red);
  if(ticket>0)
  {
  if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
  Print("Sell order opened:",OrderOpenPrice());
  }
  else Print("Error opening Sell order:", GetLastError());
  return(0);
  }
 }
 }
 
 
 //Close Buy order 
  for(cnt=0;cnt<total;cnt++)
  {
  OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
  if(OrderType()<=OP_SELL &&OrderSymbol()==Symbol())
  {
  if(OrderType()==OP_BUY)
 {
  if(ExU<MODE_ASK)
  {
  OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
  return(0);
  }
  }
  }
  else{
  if(ExD>MODE_BID)
  {
  OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet);
  return(0);
  }
  }
  }
  }
    
   return(0);
  }
//+------------------------------------------------------------------+
MeVsRacoon
39
MeVsRacoon 2014.02.07 11:11  

Oh, and also the purpose of EA is only for Gold trading.

Thanks.

Keith Watford
Moderator
7906
Keith Watford 2014.02.07 12:36  

I have difficulty following the logic of your code, does it actually compile without errors?

First of all

if(AccountFreeMargin()<(1000*Lots))

Why are you comparing a currency amount with a multiplication of lot size?

As your Extern Lots is 0.05, this will only be true if free margin is less than 50 units of the account currency.

Try to follow this section of your code

if(AccountFreeMargin()<(1000*Lots))
{
Print("We have insufficent fund.Free Margin=",AccountFreeMargin());
return(0);

// WHEN if(AccountFreeMargin()<(1000*Lots))IS TRUE, THE CODE WILL return(0) AND THE FOLLOWING CODE WILL BE IGNORED
// WHEN if(AccountFreeMargin()<(1000*Lots))IS FALSE, THE FOLLOWING CODE WILL BE IGNORED UNTIL AFTER IT FINDS A } TO MATCH THE {

//Buy Order
if(ExD>bid)
{
ticket=OrderSend(Symbol(),OP_BUY, Lots, Ask, 50,0,0,"Exp_UP",16384,Green);
  if(ticket>0)
  {
  if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
  Print("Buy order opened:",OrderOpenPrice());
  }
  else
  Print("Error opening BUY order:",GetLastError());
  return(0);
/
To add comments, please log in or register