Having Trouble With My EA

 

I am having a little trouble with my EA, it performs well beyond what I would have imagined when I have back tested in MT4.

Once in a demo account with a high amount on funds it can go either way, in one it performed very well and in another it lost a lot. I am now going mad trying to work out where the issue is, I am also having an issue in getting the order modifications to run in the background. Every single trade from opening, modifying and then closing is all sent back and forth which is causing an issue with demo accounts and hyperactivity.

If anyone can help with what I can do about these issues that would be great, I have optimised this version for trading on XAUUSD but I know if I can sort the issue it can be optimised for use on most if not all other forex / commodities parings.

For the testing images and attachments the initial funds were £500 and the test was from 1.1.2024 to 24.1.2025. The .txt file only has the first 2 trades to show how much its modifying

⚠️ Don't request help with code originating from decompiled program. Decompilation violates the terms and conditions, copyright laws and intellectual property rights

All attachments removed by moderator.
 
Your topic has been moved to the section: MQL4 and MetaTrader 4
Please consider which section is most appropriate — https://www.mql5.com/en/forum/172166/page6#comment_49114893
 

This is not your EA. Most of the code is the result of decompilation from someone else's EA.

⚠️ Don't request help with code originating from decompiled program. Decompilation violates the terms and conditions, copyright laws and intellectual property rights

 
Attention @Aaron Bull — After you have read and reacted to this post, I will be applying a temporary ban of one week on your account and removing this topic.
 
Fernando Carreiro #:
Attention @Aaron Bull — After you have read and reacted to this post, I will be applying a temporary ban of one week on your account and removing this topic.
@Fernando Carreiro I dont really get what you mean about a decompiled program, I am not a full time coder and I have picked up bits here and there as well as trying to learn more online. I have it all on MetaEditor and have been working on it for months, not sure what decompilation I have done
 
Aaron Bull #: @Fernando Carreiro I dont really get what you mean about a decompiled program, I am not a full time coder and I have picked up bits here and there as well as trying to learn more online. I have it all on MetaEditor and have been working on it for months, not sure what decompilation I have done

I repeat, the majority of the code is not your own, even if you "tinkered" with it. You obtained it from somewhere else.

Did you not realise the strange variable names that made no "human" sense? What kind of person would name their variables with non-sensical, numbered names?

double Gd_208;
double Gd_216;
double Gd_224;
double Gd_232;
double Gd_240;
double Gd_248;
double Gd_256;
Gi_204 = MathLog(lotstep_0) / MathLog(0.1);
Gd_208 = MathMax(MinLots, MarketInfo(Symbol(), MODE_MINLOT));
Gd_216 = MathMin(MaxLots, MarketInfo(Symbol(), MODE_MAXLOT));
Gd_224 = Risk / 100.0;

The source code was obtained via a mechanised method of decompilation, that was very "popular" back when MQL4 was still quite new and had no safeguards against these practices.

Ignorance is not an excuse. If someone were to publish credit card numbers on the internet and you made use of them, you would be just as guilty as the criminal who published them.

Malice and ignorance is indistinguishable from the results they produce. In fact, ignorance is much more damaging and dangerous than malice.

Take the down time to familiarise yourself about this and not making use of "stolen" code. Do a search here on the forum about "decompiled" code too.

EDIT: You even "stamped" the header with your name, which is also a copyright violation. Do some research and learn about code copyrights.

 
Fernando Carreiro #:

I repeat, the majority of the code is not your own, even if you "tinkered" with it. You obtained it from somewhere else.

Did you not realise the strange variable names that made no "human" sense? What kind of person would name their variables with non-sensical, numbered names?

The source code was obtained via a mechanised method of decompilation, that was very "popular" back when MQL4 was still quite new and had no safeguards against these practices.

Ignorance is not an excuse. If someone were to publish credit card numbers on the internet and you made use of them, you would be just as guilty as the criminal who published them.

Malice and ignorance is indistinguishable from the results they produce. In fact, ignorance is much more damaging and dangerous than malice.

Take the down time to familiarise yourself about this and not making use of "stolen" code. Do a search here on the forum about "decompiled" code too.

EDIT: You even "stamped" the header with your name, which is also a copyright violation. Do some research and learn about code copyrights.

👍

 

⚠️ On second thoughts, I will be leaving this topic up, to serve as a reference and example for any others that are "ignorant" about decompilation.

And don't take this to the Freelance section either. You will be banned again there too, as stated in the Freelance rules and the Terms and Conditions.