Code doesn't work on tester

New comment
 

The below function is supposed to count orders whose open price is same as the fapPrice variable. It doesn't seem to work on mt4 strategy tester for pending borders. What could be the issue or is it a bug in the tester?

//+------------------------------------------------------------------+
//|   Counts orders by entry price  and type                    |
//+------------------------------------------------------------------+
int FindAtPrice(double fapPrice,int fapMode)
  {
   int retval=0;
   
   for(int tc=0; tc<OrdersTotal(); tc++)
     {

      if(OrderSelect(tc,SELECT_BY_POS)==true&&OrderSymbol()==Symbol()&&OrderMagicNumber()==MagicNumber)
        {
         if(fapMode==1&&(OrderType()==OP_BUY||OrderType()==OP_BUYLIMIT)&&OrderOpenPrice()==fapPrice)  // fapMode 1 for buys
           {
            retval++;         
           
           }
         if(fapMode==2&&(OrderType()==OP_SELL||OrderType()==OP_SELLLIMIT)&&OrderOpenPrice()==fapPrice) // fapMode 2 for sells
           {
            retval++;
          
           }
        }
       
     }

   return(retval);
  }
//+------------------------------------------------------------------+
 

  1. Why did you post your MT4 question in the MT5 EA section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. The moderators will likely move this thread there soon.

  2. &OrderOpenPrice()==fapPrice
    Has fapPrice been rounded to ticksize?

    1. Floating point has an infinite number of decimals, it's you were not understanding floating point and that some numbers can't be represented exactly. (like 1/10.)
                Double-precision floating-point format - Wikipedia, the free encyclopedia

      See also The == operand. - MQL4 programming forum (2013)

    2. Print out your values to the precision you want with DoubleToString - Conversion Functions - MQL4 Reference.

    3. SL/TP (stops) need to be normalized to tick size (not Point) — code fails on non-currencies.
                On 5Digit Broker Stops are only allowed to be placed on full pip values. How to find out in mql? - MQL4 programming forum #10 (2011)

      And abide by the limits Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial and that requires understanding floating point equality Can price != price ? - MQL4 programming forum (2012)

    4. Open price for pending orders need to be adjusted. On Currencies, Point == TickSize, so you will get the same answer, but it won't work on non-currencies. So do it right.
                Trailing Bar Entry EA - MQL4 programming forum (2013)
                Bid/Ask: (No Need) to use NormalizeDouble in OrderSend - MQL4 programming forum (2012)

    5. Lot size must also be adjusted to a multiple of LotStep and check against min and max. If that is not a power of 1/10 then NormalizeDouble is wrong. Do it right.
                (MT4 2013)) (MT5 2022))

    6. MathRound() and NormalizeDouble() are rounding in a different way. Make it explicit.
                MT4:NormalizeDouble - MQL5 programming forum (2017)
                How to Normalize - Expert Advisors and Automated Trading - MQL5 programming forum (2017)

    7. Prices you get from the terminal are already correct (normalized).

    8. PIP, Point, or Tick are all different in general.
                What is a TICK? - MQL4 programming forum (2014)

  3. Use the debugger or print out your variables, including _LastError and prices and find out why. Do you really expect us to debug your code for you?
              Code debugging - Developing programs - MetaEditor Help
              Error Handling and Logging in MQL5 - MQL5 Articles (2015)
              Tracing, Debugging and Structural Analysis of Source Code - MQL5 Articles (2011)
              Introduction to MQL5: How to write simple Expert Advisor and Custom Indicator - MQL5 Articles (2010)


 
William Roeder #:

  1. Why did you post your MT4 question in the MT5 EA section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. The moderators will likely move this thread there soon.

  2. Has fapPrice been rounded to ticksize?

  3. Use the debugger or print out your variables, including _LastError and prices and find out why. Do you really expect us to debug your code for you?
              Code debugging - Developing programs - MetaEditor Help
              Error Handling and Logging in MQL5 - MQL5 Articles (2015)
              Tracing, Debugging and Structural Analysis of Source Code - MQL5 Articles (2011)
              Introduction to MQL5: How to write simple Expert Advisor and Custom Indicator - MQL5 Articles (2010)


Yes it is mt4 code. Always returns 0 and if I use a fixed value it works only once the pending order opens. I mainly want it to work for pending orders.

New comment
Reason: