Custom indicator shows up blank or returns 2147483647

New comment
 

Sometimes this indicator works, and other times it show up blank or returns 2147483647. Any ideas how to fix it? Thanks!


#property indicator_separate_window
#property indicator_minimum 1
#property indicator_maximum 99
#property indicator_buffers 1
#property indicator_color1 SkyBlue
//---- input parameters
extern int MAShort=23;
extern int MALong=50;
extern double Cycle=10;
extern int CountBars=1000;
//---- buffers
double MA[2];
double ST[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
//   string short_name; 
//---- indicator line
   IndicatorBuffers(2);
   SetIndexBuffer(0, MA);
   SetIndexBuffer(1, ST);
   SetIndexStyle(1,DRAW_LINE,STYLE_SOLID,2,indicator_color1);
//----
   return(0);
  }

int start()
  {
   SetIndexDrawBegin(0,Bars-CountBars+MALong+MAShort+1);
   int shift,counted_bars=IndicatorCounted();
   double MCD, LLV, HHV, MA_Short, MA_Long ,prev, smconst;
   int n, i, s;
   bool check_begin=false, check_begin_MA=false;
   double MCD_Arr[100];
//----
   if(Bars<=MALong) return(0);
   if (CountBars==0) CountBars=Bars;
//---- initial zero
   if(counted_bars<MALong+MAShort)
     {
      for(i=1;i<=MALong;i++) MA[Bars-i]=0.0;
      for(i=1;i<=MALong;i++) ST[Bars-i]=0.0;
     }
//----
   shift=CountBars-MALong-1;
   //   if(counted_bars>=MALong) shift=Bars-counted_bars-1;
//----
   check_begin=false;
   check_begin_MA=false;
   n=1;
   s=1;
   smconst=2/(1 + Cycle/2);
//----
   while(shift>=0)
     {
      MA_Short=iMA(NULL,0,MAShort,0, MODE_EMA, PRICE_TYPICAL, shift);
      MA_Long=iMA(NULL,0,MALong,0, MODE_EMA, PRICE_TYPICAL, shift);
      MCD_Arr[n]=MA_Short - MA_Long;
      MCD=MA_Short - MA_Long;
//----
      if (n>=Cycle)
        {
        n=1; check_begin=true;   
        } 
        else {n=n + 1;}
      if (check_begin)
        {
         for(i=1; i<=Cycle; i++)
           {
            if (i==1) {LLV=MCD_Arr[i];}
              else 
              {
               if (LLV > MCD_Arr[i]) LLV=MCD_Arr[i];
              }
            if (i==1) {HHV=MCD_Arr[i];}
              else 
              {
               if (HHV < MCD_Arr[i]) HHV=MCD_Arr[i];
              }
           }
         if((HHV - LLV) == 0) return false;
         ST[shift]=((MCD - LLV)/(HHV - LLV))*100 + 0.01;
         s=s + 1;
         if (s>=(Cycle)/2)
           {
            s=1;
            check_begin_MA=true;
           }
        }   
         else {ST[shift]=0;
        }
        if (check_begin_MA) 
        {
         prev=MA[shift + 1];
        double yoyoGo=(smconst * (ST[shift] - prev) + prev);   
        if(yoyoGo<indicator_minimum)yoyoGo=indicator_minimum;   
        else if(yoyoGo>indicator_maximum)yoyoGo=indicator_maximum;   
        MA[shift]=yoyoGo;   
        }
      shift--;
     }
   return(0);
  }
 
hknight555: other times it show up blank or returns 2147483647.

  1. Why did you post your MT4 question in the MT5 Indicators section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. The moderators will likely move this thread there soon.

  2. That number is EMPTY_VALUE. Of course, using that value should result in a blank.

  3.         if(yoyoGo<indicator_minimum)yoyoGo=indicator_minimum;   
        else if(yoyoGo>indicator_maximum)yoyoGo=indicator_maximum;  
    INDICATOR_MINIMUM is the constant value 2 (MAX is 3).
New comment