[SERVICE DESK] Error in getting the time of the senior TF in the timer!

[Deleted] 2018.09.21 06:41

Objective: When starting the indicator, get the current data in the timer: the opening time of the weekly, daily and hourly bar. Then write them in global variables for further use. The current timeframe is М1.

Implementation: We obtain the bar times using the SeriesInfoInteger() function.

#property version   "1.00"
#property strict
#property indicator_chart_window
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
//--- Время открытия текущего часа, дня и недели
datetime _weekOpenTime = 0;
datetime _hourOpenTime = 0;
datetime _dayOpenTime=0;
//--- Вести лог журнала
const bool inpFileLog=true;
//--- Количество секунд в одном дне
const int SEC_PER_DAY=86400;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- Запускаем таймер
   if(!EventSetMillisecondTimer(20))
     {
      Print(__FUNCTION__,": ОШИБКА #",GetLastError(),": таймер с частотой 20 ms не установлен!");
      return( INIT_FAILED );
     }
//--- Сбрасываем время открытия текущего часа, дня и недели
   _weekOpenTime= 0;
   _dayOpenTime = 0;
   _hourOpenTime= 0;
//---
   return( INIT_SUCCEEDED );
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {

   return( rates_total );
  }
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
  {
//--- Проверяем, записано ли время открытия текущей недели
   if(!CheckCurrentWeekOpenTime())                        // Если время не записано
      return;                                                // Выходим
//--- Проверяем, записано ли время открытия текущего дня
   if(!CheckCurrentDayOpenTime())                        // Если время не записано
      return;                                                // Выходим
//--- Проверяем, записано ли время открытия текущего часа
   if(!CheckCurrentHourOpenTime())                        // Если время не записано
      return;                                                // Выходим
  }
//+------------------------------------------------------------------+
//| Проверяем, записано ли время открытия текущей недели             |
//+------------------------------------------------------------------+
bool CheckCurrentWeekOpenTime()
  {
//--- Проверяем, записано ли время
   if(_weekOpenTime==0) // Если время не записано
     {
      //--- Получаем время открытия недельного бара
      ResetLastError();
      const datetime weekBarOpenTime=(datetime)SeriesInfoInteger(_Symbol,PERIOD_W1,SERIES_LASTBAR_DATE);
      const int err=GetLastError();
      //---
      if(inpFileLog)
        {
         Print(__FILE__,": Время открытия недельного бара = "+TimeToString(weekBarOpenTime)+". Ошибка #",err);
         //Print( __FILE__,": Время открытия текущей недели через iTime = "+TimeToString( weekOpenTime2 )+". Ошибка #",err2 );
        }
      //ResetLastError();
      //const datetime weekBarOpenTime2 = iTime( _Symbol, PERIOD_W1, 0 );
      //const int err2 = GetLastError();
      //--- Проверяем, получено ли время открытия недельного бара
      if(weekBarOpenTime==0 || err!=0) // Если время бара не получено или история обновляется
         return(false);                              // Возвращаем ложь
      //--- Запоминаем время открытия текущей недели (время открытия недельного бара - воскресенье)
      _weekOpenTime=weekBarOpenTime+SEC_PER_DAY;
      //const datetime weekOpenTime2 = weekBarOpenTime2+SEC_PER_DAY;
      //---
      if(inpFileLog)
        {
         Print(__FILE__,": Актуальное время открытия текущей недели = "+TimeToString(_weekOpenTime)+". Ошибка #",err);
         //Print( __FILE__,": Время открытия текущей недели через iTime = "+TimeToString( weekOpenTime2 )+". Ошибка #",err2 );
        }
      //--- Возвращаем истину
      return( true );
     }
//--- Время открытия недели ранее записано. Возвращаем истину
   return( true );
  }
//+------------------------------------------------------------------+
//| Проверяем, записано ли время открытия текущего дня                  |
//+------------------------------------------------------------------+
bool CheckCurrentDayOpenTime()
  {
//--- Проверяем, записано ли время
   if(_dayOpenTime==0) // Если время не записано
     {
      //--- Получаем время открытия дневного бара
      ResetLastError();
      const datetime tempDayOpenTime=(datetime)SeriesInfoInteger(_Symbol,PERIOD_D1,SERIES_LASTBAR_DATE);
      const int err=GetLastError();
      //ResetLastError();
      //const datetime dayOpenTime2 = iTime( _Symbol, PERIOD_D1, 0 );
      //const int err2 = GetLastError();
      //---
      if(inpFileLog)
        {
         Print(__FILE__,": Время открытия текущего дня = "+TimeToString(tempDayOpenTime)+". Ошибка #",err);
         //Print( __FILE__,": Время открытия текущего дня iTime = "+TimeToString( dayOpenTime2 )+". Err2 #",err2 );
        }
      //--- Проверяем, получено ли время открытия дневного бара
      if(tempDayOpenTime==0 || err!=0) // Если время бара не получено
         return(false);                                 // Возвращаем ложь
      //--- Сохраняем в глобальную переменную значение открытия текущего дня
      _dayOpenTime=tempDayOpenTime;
      //---
      if(inpFileLog)
        {
         Print(__FILE__,": Актуальное время открытия текущего дня = "+TimeToString(_dayOpenTime)+". Ошибка #",err);
         //Print( __FILE__,": Время открытия текущей недели через iTime = "+TimeToString( weekOpenTime2 )+". Ошибка #",err2 );
        }
      //--- Возвращаем истину
      return( true );
     }
//--- Время открытия дня ранее записано. Возвращаем истину
   return( true );
  }
//+------------------------------------------------------------------+
//| Проверяем, записано ли время открытия текущего часа              |
//+------------------------------------------------------------------+
bool CheckCurrentHourOpenTime()
  {
//--- Проверяем, записано ли время
   if(_hourOpenTime==0) // Если время не записано
     {
      //--- Получаем время открытия часового бара
      ResetLastError();
      const datetime tempHourOpenTime=(datetime)SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE);
      const int err=GetLastError();
      //const datetime hourOpenTime2 = iTime( _Symbol, PERIOD_H1, 0 );
      //---
      if(inpFileLog)
        {
         Print(__FILE__,": Время открытия текущего часа = "+TimeToString(tempHourOpenTime)+". Ошибка #",err);
         //Print( __FILE__,": Время открытия текущего часа iTime = "+TimeToString( hourOpenTime2 ) );
        }
      //--- Проверяем, получено ли время открытия часового бара
      if(tempHourOpenTime==0 || err!=0) // Если время бара не получено
         return(false);                                 // Возвращаем ложь
      //---
      _hourOpenTime=tempHourOpenTime;
      //---
      if(inpFileLog)
        {
         Print(__FILE__,": Актуальное время открытия текущего часа = "+TimeToString(_hourOpenTime)+". Ошибка #",err);
         //Print( __FILE__,": Время открытия текущего часа iTime = "+TimeToString( hourOpenTime2 ) );
        }
      //--- Возвращаем истину
      return( true );
     }
//--- Время открытия часа ранее записано. Возвращаем истину
   return( true );
  }

Result: As a result, if the terminal LASTED running for several hours, for example, it was off for the night, we get such a result at its first (one day) start:

2018.09.21 11:11:27.306 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Актуальное время открытия текущего часа = 2018.09.20 16:00. Ошибка #0
2018.09.21 11:11:27.306 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Время открытия текущего часа = 2018.09.20 16:00. Ошибка #0
2018.09.21 11:11:27.280 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Время открытия текущего часа = 2018.09.20 16:00. Ошибка #4066
2018.09.21 11:11:27.279 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Актуальное время открытия текущего дня = 2018.09.20 00:00. Ошибка #0
2018.09.21 11:11:27.279 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Время открытия текущего дня = 2018.09.20 00:00. Ошибка #0
2018.09.21 11:11:27.265 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Время открытия текущего дня = 2018.09.20 00:00. Ошибка #4066
2018.09.21 11:11:27.264 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Актуальное время открытия текущей недели = 2018.09.17 00:00. Ошибка #0
2018.09.21 11:11:27.264 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Время открытия недельного бара = 2018.09.16 00:00. Ошибка #0
2018.09.21 11:11:27.233 test_isNewDayInTimer USDCHF.e,M1: test_isNewDayInTimer.mq4: Время открытия недельного бара = 2018.09.16 00:00. Ошибка #4066
2018.09.21 11:11:27.066 test_isNewDayInTimer USDCHF.e,M1: initialized
2018.09.21 11:11:27.055 Custom indicator test_isNewDayInTimer USDCHF.e,M1: loaded successfully

As you can see, the data retrieval time is 2018.09.21 11:11, and for that time we get the opening time of the day = 2018.09.20 (although it should be 2018.09.21) and the opening time of the hour = 2018.09.20 16:00 (although it should be 2018.09.21 11:00). And the time returned by the terminal is nothing but the data at the time it was last closed. I.e. the data is cached and returned regardless of the fact that the terminal was shut down. And I understand if error #4066 would be returned every time (requested historical data in update state) until the data is updated, but no, it is ERROR data that is returned! This error is only returned once and then you can live with it. There is a clear caching error. I ask developers(@Slava) to pay attention to it!

I repeat. Erroneous data will appear if it is requested in the timer!

Terminal version: x64, 1090.

Vitaly Gorbunov 2018.09.21 06:53 #1

So the 4066 error is a typical problem for MTF indices, the terminal has not fed the data of other TFs, you need to check the integrity of the data of other TFs.

[Deleted] 2018.09.21 07:10 #2

Vitaly Gorbunov:
Well so error 4066 is a typical problem for MTF indusers, the terminal has not pumped the data of other TFs need to check for integrity of other TFs data.

Take a closer look at the code and what I have written before giving advice.

The code has a check for errors and a check for empty data. And when a function returns incorrect data without an error, it is an error!

Vitaly Gorbunov 2018.09.21 07:16 #3

Alexey Kozitsyn:

Take a closer look at the code and what I have written before giving advice.

The code has a check for errors and a check for empty data. And when a function returns incorrect data without an error, it is an error!

Maybe I missed something, show me where you check the integrity of history, for example, in theCheckCurrentHourOpenTime() procedure

[Deleted] 2018.09.21 07:19 #4

Vitaly Gorbunov:
Maybe I missed something and show me where you check integrity of history, for example, inCheckCurrentHourOpenTime() procedure

What do you mean by story integrity?

I'm talking about the fact that there is a check for errors when retrieving history values. There is a check in every function. Here it is:

//--- Проверяем, получено ли время открытия часового бара
      if(tempHourOpenTime==0 || err!=0) // Если время бара не получено
         return(false);                                 // Возвращаем ложь

I.e. if zero value or error is received - time is not written to global variable. Do you think it's not enough?

The point is that the SeriesInfoInteger() function first returns an error but on the next run it returns NO! And it does not return the correct value either!

Any rookie question, so OrderSend error with Pepperstone Get in touch with

Vitaly Gorbunov 2018.09.21 07:38 #5

SeriesInfoInteger() returns only information for a certain query, in this case we are asking to return the last known bar open time in the history by symbol and period. There is no error here, what was the latest at the moment is what it returned. I will show you how to check the integrity of the history.

Analogue to iBarShift Im having a issue Errors, bugs, questions

[Deleted] 2018.09.21 07:45 #6

Vitaly Gorbunov:

SeriesInfoInteger() returns only information for a certain query, in this case we are asking to return the last known bar opening time in the history by symbol and period. There is no error here, what was the latest at the moment is what it returned. I will get to the PC and show you how to check the history integrity.

You mean there's no error here!? Then why's it giving out "fake" error codes? It says the history is OK where it's not...

Vitaly Gorbunov 2018.09.21 07:52 #7

Alexey Kozitsyn:

What do you mean there's no error here!? Then why is it giving out 'fake' error codes? It says the history is OK where it's not...

Once again, this function doesn't check the integrity of the history! It returns the information it could find in it. In this particular case, it found the hour bar that was requested when the terminal was shut down. The rest of the history has not been loaded yet.

MetaTrader 4 Build 529 Any questions from newcomers Coding help

Ihor Herasko 2018.09.21 08:01 #8

To check if the history of a given TF is paging in completely, just use a function:

bool IsTFDataReady(ENUM_TIMEFRAMES eTF)
{
   ResetLastError();
   iTime(NULL, eTF, 1);
   return GetLastError() == ERR_NO_ERROR;
}

If the function returns false, the data for the requested TF is incomplete. Otherwise it is complete.

[Deleted] 2018.09.21 08:05 #9

Vitaly Gorbunov:

Once again, this function does not check the integrity of the story! It returns the information it was able to find in it. In this case, it found the hour bar that was requested when the terminal was switched off. The rest of the history has not been loaded yet.

Once again. It's not mentioned anywhere. That's first of all. Secondly, then why is it misleading by first showing error code 4066 and then not?

[Deleted] 2018.09.21 08:06 #10

Ihor Herasko:

To check if the history of a given TF is paging in completely, just use a function:

If the function returns false, the data for the requested TF is incomplete. Otherwise it is complete.

Have you checked it in the timer? Do you see I have commented out lines? I checked this function, it didn't show any errors at all and also showed incorrect data. I'll check it again.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16

New comment