Define SL and TP mt5

yaser.amini67 2021.07.19 07:35

hi guys,

I'm trying to write an EA. I have a problem with setting fixed sl and tp on my code. here's me code

      double tp=300.00000;
      double sl=100.00000;
      double norm_tp=NormalizeDouble(tp, _Digits);  
      double norm_sl=NormalizeDouble(sl, _Digits);
      TradeRequest.action=TRADE_ACTION_DEAL;
      TradeRequest.price=Tick.ask;
      TradeRequest.symbol=_Symbol;
      TradeRequest.volume=0.01;
      TradeRequest.type=ORDER_TYPE_BUY;
      TradeRequest.magic=65245;
      TradeRequest.type_filling=SYMBOL_FILLING_IOC;
      TradeRequest.tp=norm_tp;
      TradeRequest.sl=norm_sl;

I want to set TP at 300 pipets and SL at 100 pipet. I used NormalizeDouble function but it does'nt work.

any ideas?

rrocchi 2021.07.19 12:02 #1

yaser.amini67:

hi guys,

I'm trying to write an EA. I have a problem with setting fixed sl and tp on my code. here's me code

I want to set TP at 300 pipets and SL at 100 pipet. I used NormalizeDouble function but it does'nt work.

any ideas?

SL and TP must be PRICE values, not pips/points.

You are passing the wrong information.

For BUY orders TP, you need the get the current ASK Price, add the desired 300 points to the ASK Price respecting its decimal digits and normalize it.

The resulting Price is the TP price.

Example: you want TP to be 300 points. Considering EURUD as an example. Considering an Ask Price of 1.87654

300 must be converted to the correct decimal digits, which will be: 0.00300

Then add: 0.00300 + 1.87654 = 1.87954

Since TP parameter must be PRICE, in this example, TP will be 1.87954

Here is a code to get you started, which does the decimal adjust, sum, and normalization.

int TP_Points = 300;
double norm_tp;

norm_tp = NormalizeDouble(Symbol.Ask() + (TP_Points * _Point), _Digits);

Ea order correct tp Discussion on MQL4 documentation Questions from Beginners MQL5

William Roeder 2021.07.19 13:21 #2

TP/SL are prices as @rrocchi says.
You buy at the Ask and sell at the Bid. Pending Buy Stop orders become market orders when hit and open at the Ask.
1. Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid / OrderClosePrice reaches it. Using Ask±n, makes your SL shorter and your TP longer, by the spread. Don't you want the specified amount used in either direction?
2. Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask / OrderClosePrice reaches it. To trigger close to a specific Bid price, add the average spread.
  MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25
3. The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (control+O) → charts → Show ask line.)
  Most brokers with variable spreads widen considerably at end of day (5 PM ET) ± 30 minutes. My GBPJPY (OANDA) shows average spread = 26 points, but average maximum spread = 134 (your broker will be similar).

I don't understand this. The Same stoploss and Take Profit Order Achieved

yaser.amini67 2021.07.19 13:30 #3

rrocchi:

SL and TP must be PRICE values, not pips/points.

You are passing the wrong information.

For BUY orders TP, you need the get the current ASK Price, add the desired 300 points to the ASK Price respecting its decimal digits and normalize it.

The resulting Price is the TP price.

Example: you want TP to be 300 points. Considering EURUD as an example. Considering an Ask Price of 1.87654

300 must be converted to the correct decimal digits, which will be: 0.00300

Then add: 0.00300 + 1.87654 = 1.87954

Since TP parameter must be PRICE, in this example, TP will be 1.87954

Here is a code to get you started, which does the decimal adjust, sum, and normalization.

Thank you for your reply but i'm getting the same error from before: failed instant sell [Invalid request]

I'm new with mql5 so maybe you can help me a little more. here is my code:

//+------------------------------------------------------------------+
//|                                                       NewExp.mq5 |
//|                                                      Yaser Amini |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Yaser Amini"
#property link      "https://www.mql5.com"
#property version   "1.00"

int RSIH;
double RSI[];

int STOCH;
double Stoch[];
double DPer[];  // d%

int MACDH;
double MACD[];
double SIGNAL[];
double histogram_before;
double histogram_now;

bool firstBuy=1;

int tp_points=300;
double norm_tp;

int sl_points=100;
double norm_sl;

//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//---
   
   RSIH=iRSI(_Symbol, _Period, 14, PRICE_CLOSE);
   STOCH=iStochastic(_Symbol, _Period, 21, 5, 7, MODE_SMA, STO_CLOSECLOSE);
   MACDH=iMACD(_Symbol, _Period, 12, 26, 9, PRICE_CLOSE);
   
   ArraySetAsSeries(RSI, 1);
   ArraySetAsSeries(Stoch, 1);
   ArraySetAsSeries(DPer, 1);
   ArraySetAsSeries(MACD, 1);
   ArraySetAsSeries(SIGNAL, 1);
   
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//---
   
   
  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
   
   MqlTick Tick;
   MqlRates Rates[];
   MqlTradeRequest TradeRequest;
   MqlTradeResult TradeResult;
   
   CopyRates(_Symbol, _Period, 0, 2, Rates);
   ArraySetAsSeries(Rates, 1);
   SymbolInfoTick(_Symbol, Tick);
   
   CopyBuffer(RSIH, 0, 0, 5, RSI);
   
   CopyBuffer(STOCH, 0, 0, 5, Stoch);
   CopyBuffer(STOCH, 1, 0, 5, DPer);
   
   CopyBuffer(MACDH, 0, 0, 5, MACD);
   CopyBuffer(MACDH, 1, 0, 5, SIGNAL);
   
   histogram_before=MACD[2]-SIGNAL[2];
   histogram_now=MACD[0]-SIGNAL[0];
   
   bool BuyPos=false;
   bool SellPos=false;
   
   if(PositionSelect(_Symbol)){
      
      if(PositionGetInteger(POSITION_TYPE)==POSITION_TYPE_BUY){
         
         BuyPos=true;
         
      } else if(PositionGetInteger(POSITION_TYPE)==POSITION_TYPE_SELL){
         
         SellPos=true;
      }  
   }
   
   bool BuyStoch=Stoch[2]<DPer[2] && Stoch[0]>DPer[0];
   bool BUYRSI=RSI[0]>55;
   bool BUYMACD=MACD[2]<SIGNAL[2] && MACD[0]>SIGNAL[0];
   
   if(BuyStoch && BUYRSI && BUYMACD) {
   
      if(BuyPos){
         
        return;
      }
        
      norm_tp=NormalizeDouble(Tick.ask + (tp_points* _Point), _Digits);
      //norm_sl=NormalizeDouble(Tick.ask - (sl_points* _Point), _Digits);
      
      TradeRequest.action=TRADE_ACTION_DEAL;
      TradeRequest.price=Tick.ask;
      TradeRequest.symbol=_Symbol;
      TradeRequest.volume=0.01;
      TradeRequest.type=ORDER_TYPE_BUY;
      TradeRequest.magic=65245;
      TradeRequest.type_filling=SYMBOL_FILLING_IOC;
      TradeRequest.tp=norm_tp;
      //TradeRequest.sl=norm_sl;
      
      OrderSend(TradeRequest, TradeResult); 
      
      if(TradeResult.retcode==10009 || TradeResult.retcode==10008){
         Print("Order Done!");
         if(firstBuy){
            
            firstBuy=0;
         }
      } else{
         Print(TradeResult.retcode);
      }
   }
   
   if(!firstBuy){
      bool SellStoch=Stoch[2]>DPer[2] && Stoch[0]<DPer[0];
      bool SellRSI=RSI[0]<=48;
      bool SellMACD=MACD[2]>SIGNAL[2] && MACD[0]<SIGNAL[0];
      
      if(SellStoch && SellRSI && SellMACD){
         if(SellPos){
            
            return;
         }
         
         norm_sl=NormalizeDouble(Tick.ask - (sl_points* _Point), _Digits);
         
         TradeRequest.action=TRADE_ACTION_DEAL;
         TradeRequest.price=Tick.bid;
         TradeRequest.symbol=_Symbol;
         TradeRequest.volume=0.01;
         TradeRequest.type=ORDER_TYPE_SELL;
         TradeRequest.magic=65246;
         TradeRequest.type_filling=SYMBOL_FILLING_IOC;
         //TradeRequest.tp=300;
         TradeRequest.sl=norm_sl;
         
         OrderSend(TradeRequest, TradeResult); 
         
         if(TradeResult.retcode==10009 || TradeResult.retcode==10008){
            Print("Order Done!");
         } else{
            Print(TradeResult.retcode);
         }
      }
   
   }
  }
//+------------------------------------------------------------------+

As you can see i'm using ordersend() to my buy and sell executions. I'm not quite sure how to use sl and tp in this code. should I use sl and tp in both types of orders(buy and sell)?

OrderSend Error 130??? Help me please about Some part of my

rrocchi 2021.07.19 13:39 #4

yaser.amini67:

Thank you for your reply but i'm getting the same error from before: failed instant sell [Invalid request]

I'm new with mql5 so maybe you can help me a little more. here is my code:

As you can see i'm using ordersend() to my buy and sell executions. I'm not quite sure how to use sl and tp in this code. should I use sl and tp in both types of orders(buy and sell)?

Hmm.. your are doing it raw, via the hardest way to program. :)

I Suggest you use Ctrade to do everything. It facilitates a lot, and it does the hard job of validating and making sure everything is done correctly.

Since you are new on MQL5, start by learn how to use CTrade functions, because this is the best road ahead for programming EAs.

And its a lot more easy to program.

Link below:

ctrade

Documentation on MQL5: Standard Library / Trade Classes / CTrade

www.mql5.com

CTrade - Trade Classes - Standard Library - MQL5 Reference - Reference on algorithmic/automated trading language for MetaTrader 5

countdown candle any one know pending could any one please

yaser.amini67 2021.07.19 14:13 #5