Going short isn't working please help...

[ranisfaris]

Hi There

Simple piece of code that I can't get to work ->

   #include<Trade\Trade.mqh>

   CTrade trade;

    


void OnTick()

{

   double Bid = NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_BID),_Digits);

   double Ask = NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_ASK),_Digits);

     

   double open0 = iOpen(NULL,0,0);        //the open price of the latest bar





if (Bid > open0)

trade.Buy(0.30,NULL,Ask,Bid-2* _Point,Bid+5* _Point,NULL);

else if (Bid < open0)

trade.Sell(0.30,NULL,Ask,Bid+2* _Point,Bid-5* _Point,NULL);



}





// trade.buy.... works, whenever the Bid is bigger than the open0 it buys but the trade.sell is not working when price goes below open0 I also don't get any errors when I compile so what's wrong?

// is there a different way to go long or short ? Please help and a million thanks to you my friend

[William Roeder]

1. Please edit your (original) post and use the CODE button (Alt-S)! (For large amounts of code, attach it.)
             General rules and best pratices of the Forum. - General - MQL5 programming forum 2019.05.06
             Messages Editor

2. trade.Buy( 0.30,NULL,Ask,Bid-2* _Point,Bid+5* _Point,NULL);
   trade.Sell(0.30,NULL,Ask,Bid+2* _Point,Bid-5* _Point,NULL);

   You buy at the Ask and sell at the Bid. Pending Buy Stop orders become market orders when hit and open at the Ask.

   1. Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid / OrderClosePrice reaches it. Using Ask±n, makes your SL shorter and your TP longer, by the spread. Don't you want the specified amount used in either direction?

   2. Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask / OrderClosePrice reaches it. To trigger close to a specific Bid price, add the average spread.
                MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25

   3. The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (control+O) → charts → Show ask line.)
      Most brokers with variable spreads widen considerably at end of day (5 PM ET) ± 30 minutes. My GBPJPY (OANDA) shows average spread = 26 points, but average maximum spread = 134 (your broker will be similar).

3. You can't move stops (or pending prices) closer to the market than the minimum: MODE_STOPLEVEL * _Point or SymbolInfoInteger(SYMBOL_TRADE_STOPS_LEVEL).
             Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial

   On some ECN type brokers the value might be zero (broker doesn't know.) Use a minimum of two (2) PIPs.

[ranisfaris]

William Roeder:

1. Please edit your (original) post and use the CODE button (Alt-S)! (For large amounts of code, attach it.)
             General rules and best pratices of the Forum. - General - MQL5 programming forum 2019.05.06
             Messages Editor

2. You buy at the Ask and sell at the Bid. Pending Buy Stop orders become market orders when hit and open at the Ask.

   1. Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid / OrderClosePrice reaches it. Using Ask±n, makes your SL shorter and your TP longer, by the spread. Don't you want the specified amount used in either direction?

   2. Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask / OrderClosePrice reaches it. To trigger close to a specific Bid price, add the average spread.
                MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25

   3. The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (control+O) → charts → Show ask line.)
      Most brokers with variable spreads widen considerably at end of day (5 PM ET) ± 30 minutes. My GBPJPY (OANDA) shows average spread = 26 points, but average maximum spread = 134 (your broker will be similar).

3. You can't move stops (or pending prices) closer to the market than the minimum: MODE_STOPLEVEL * _Point or SymbolInfoInteger(SYMBOL_TRADE_STOPS_LEVEL).
             Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial

   On some ECN type brokers the value might be zero (broker doesn't know.) Use a minimum of two (2) PIPs.

Wow thanks alot I see why I wasn't getting instant fill its because I'm selling to the ask instead of the bid thanks alot!!

Also one more thing, are the orders getting sent out market orders? How can I change that to a limit order ?

agains thanks alot :)