void OnTick() { //--- double SlowMovingAverage = iMA(NULL ,0 ,100,0,MODE_EMA,PRICE_CLOSE,0); double LastSlowMovingAverage = iMA(NULL ,0 ,100,0,MODE_EMA,PRICE_CLOSE,1); double FastMovingAverage = iMA(NULL ,0 ,10,0,MODE_EMA,PRICE_CLOSE,0); double LastFastMovingAverage = iMA(NULL ,0 ,10,0,MODE_EMA,PRICE_CLOSE,1); if(OrdersTotal() ==0 ) { if( (LastFastMovingAverage<LastSlowMovingAverage)&& (FastMovingAverage>=SlowMovingAverage) ) { OrderSend(_Symbol ,OP_BUY , 1 , Ask , 1 ,Ask-200*_Point ,Ask+800*Point,NULL,0,0,Green); } if( (LastFastMovingAverage>LastSlowMovingAverage)&& (FastMovingAverage<=SlowMovingAverage) ) { OrderSend(_Symbol ,OP_SELL , 1 , Bid , 1 ,Bid+200*_Point ,Bid-800*Point,NULL,0,0,Red); } } }
forexsender: ,next open order happen multiple times(around 100 orders)
- When you post code please use the CODE button (Alt-S)!
(For large amounts of code, attach it.)
Please edit
your (original) post.
General rules and best pratices of the Forum. - General - MQL5 programming forum
Messages Editor -
Why did you post your MT4 question in the
Root /
MT5 General section
instead of the MQL4 section,
(bottom of the Root page?)
General rules and best pratices of the Forum. - General - MQL5 programming forum
Next time post in the correct place. The moderators will likely move this thread there soon.
double SlowMovingAverage = iMA(NULL ,0 ,100,0,MODE_EMA,PRICE_CLOSE,0); double FastMovingAverage = iMA(NULL ,0 ,10,0,MODE_EMA,PRICE_CLOSE,0);
You are using the current bar (zero.) The MA could cross and uncross multiple times as price fluctuates. Do you wish to enter when there is no real cross?-
OrderSend(_Symbol ,OP_BUY , 1 , Ask , 1 ,Ask-200*_Point ,Ask+800*Point,NULL,0,0,Green); OrderSend(_Symbol ,OP_SELL , 1 , Bid , 1 ,Bid+200*_Point ,Bid-800*Point,NULL,0,0,Red);
You buy at the Ask and sell at the Bid. (Your stops have 20 PIP minus spread for buys and 20 PIP plus spread for sells.)- Your buy order's TP/SL are triggered when the Bid reaches it. Not the Ask.
-
Your sell order's TP/SL will be triggered when the Ask reaches it. To trigger at
a specific Bid price, add the average spread.
MODE_SPREAD (Paul) - MQL4 and MetaTrader 4 - MQL4 programming forum - Page 3 - The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools -> Options {control-O} -> charts -> Show ask line.)
-
Check your return codes for errors, and report them including GLE/LE.
Don't look at it unless you have an error. You should be using strict - don't just silence the compiler, it is trying to help you.
Always use strict. Fixing the warnings will save you hours of debugging.
Program Properties (#property) - Preprocessor - Language Basics - MQL4 Reference
What are Function return values ? How do I use them ? - MQL4 and MetaTrader 4 - MQL4 programming forum
Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles
Only those functions that return a value (e.g. iClose, MarketInfo, etc.) must you call ResetLastError before in order to check after.
- Your if(OrdersTotal() == 0) only applied to the buys, you had no check on the sell, combined with № 3 and you get an open sell per tick. Compare your code to @Marco vd Heijde's:
if(OrdersTotal() ==0 ) { if( (LastFastMovingAverage< … if( (LastFastMovingAverage> … }
-
Using OrdersTotal directly and/or no Magic number filtering on your
OrderSelect loop means your code is incompatible with every EA (including itself on other charts and manual
trading.)
Symbol Doesn't equal Ordersymbol when another currency is added to another seperate chart . - MQL4 and MetaTrader 4 - MQL4 programming forum
MagicNumber: "Magic" Identifier of the Order - MQL4 Articles
thanks you sir very much
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
I coded MA crossover EA .After one order successful opened and get take profit,next open order happen multiple times(around 100 orders)
in each bar.What wrong with that.Someone help me.
void OnTick(){
//---
double SlowMovingAverage = iMA(NULL ,0 ,100,0,MODE_EMA,PRICE_CLOSE,0);
double LastSlowMovingAverage = iMA(NULL ,0 ,100,0,MODE_EMA,PRICE_CLOSE,1);
double FastMovingAverage = iMA(NULL ,0 ,10,0,MODE_EMA,PRICE_CLOSE,0);
double LastFastMovingAverage = iMA(NULL ,0 ,10,0,MODE_EMA,PRICE_CLOSE,1);
if (OrdersTotal() ==0 )
if( (LastFastMovingAverage<LastSlowMovingAverage)&& (FastMovingAverage>=SlowMovingAverage) )
{
OrderSend(_Symbol ,OP_BUY , 1 , Ask , 1 ,Ask-200*_Point ,Ask+800*Point,NULL,0,0,Green);
}
if( (LastFastMovingAverage>LastSlowMovingAverage)&& (FastMovingAverage<=SlowMovingAverage) )
{
OrderSend(_Symbol ,OP_SELL , 1 , Bid , 1 ,Bid+200*_Point ,Bid-800*Point,NULL,0,0,Red);
}
}