Libraries: BestInterval - page 29

[Dmitrii Verevkin]

Hi!

An error appears during compilation. Has anyone encountered it?

I searched the forum, I don't think it's been discussed.

[fxsaber]

Dmitrii Verevkin #:

an error appears during compilation.

Add these lines to Deal.mqh.

#include "Deal_Base.mqh"

struct DEAL : public DEAL_BASE
{
  int Index;

  void ToNull( DEAL &Deals[] ) const
  {
  #ifdef __MQL5__
    Deals[this.Index].DEAL_BASE::ToNull();
  #else // __MQL5__ - https://www.mql5.com/ru/forum/322209#comment_13314616
    Deals[this.Index].ToNull();
  #endif // __MQL5__

    return;
  }
  
  void operator =( const DEAL_BASE &bDeal )
  {
    /*this.*/ DEAL_BASE::operator=(bDeal); // https://www.mql5.com/ru/forum/1111/page3368#comment_48437633
    
    return;
  }  
};

[Dmitrii Verevkin]

Dmitrii Verevkin #:

Hi!

I get an error when compiling. Has anyone encountered it?

I searched the forum, I don't think it's been discussed.

It helped.

thanks!

[1005829945]

Please help How can I solve this problem? There are errors after compilation.

[fxsaber]

1005829945 #:
Please help How can I solve this problem? There are errors after compilation.

OnTick function is missing.

[fxsaber]

https://www.mql5.com/ru/blogs/post/771302

[fxsaber]

fxsaber #:
https://www.mql5.com/ru/blogs/post/771302

Calculations have been significantly accelerated.

#include <fxsaber\Benchmark\Benchmark.mqh> // https://www.mql5.com/en/code/31279

#define  ORDER_COMMISSION 0
#include <fxsaber\Virtual\Virtual.mqh> // https://www.mql5.com/en/code/22577
#include <fxsaber\BestInterval\BestInterval.mqh> // https://www.mql5.com/en/code/22710

// Benchmark script
void OnStart()
{
  if (VIRTUAL::SelectByHandle(VIRTUAL::Create("BestInterval.mqh.virt"))) // https://c.mql5.com/3/492/BestInterval_mqh.zip
  {
    BESTINTERVAL_INPUT Inputs;

    Inputs.AmountDeleteIntervals = 5;
    Inputs.MinPF = 1.0;
    Inputs.OnlyDelete = false;
    Inputs.Method = METHOD_WEEK;
    
    Inputs.Length = 0.8;
    Inputs.Amount = 10;
            
    BESTINTERVAL BestInterval;
    
    _B(BestInterval.FullCalculate(Inputs), 1);
    Print(BestInterval.ToStringConst());
  }  
}

It was.

Alert: Bench_Stack = 0, 1 <= Time[Test6.mq5 174 in OnStart: BestInterval.FullCalculate(Inputs)] = 6724116 mcs.

Now.

Alert: Bench_Stack = 0, 1 <= Time[Test6.mq5 174 in OnStart: BestInterval.FullCalculate(Inputs)] = 394778 mcs.

Optimisation speeds up several times over.

[hini]

Which files have been updated?

[fxsaber]

hini #:
Which files have been updated?

Holiday.mqh
Deal_Base.mqh
Deal.mqh
Interval.mqh
BestInterval.mqh

[HimOrik]

fxsaber #:

Compilation error.

Advisor

 #include <MT4Orders.mqh> // https://www.mql5.com/en/code/16006
 
 //#include <fxsaber\Virtual\Virtual.mqh> // https://www.mql5.com/en/code/22577

#define  BESTINTERVAL_ONTESTER // Optimisation criterion: the profit of the best interval.
#include <fxsaber\BestInterval\BestInterval.mqh> // Calculating the best trading range

 //#include <..\Experts\Examples\MACD\MACD Sample.mq5> // Any expert advisor
long tiket = -1;

void OnTick()
{    
MqlTick t;

if(SymbolInfoTick(_Symbol, t))
    {
    if(tiket < 0)
        {
        double lot = ::NormalizeDouble(SymbolInfoDouble(_Symbol, SYMBOL_VOLUME_MIN), 2);
        double price = ::NormalizeDouble(t.ask, _Digits); 
              
        ResetLastError();
        
        tiket = OrderSend(_Symbol, 0, lot, price, 0, 0, 0, "666", 666); 
        
        if(tiket > -1)
           {
            Sleep(1000);
            return;
           }
        else
           {
           Print("\nopenSL:  BUY trade request error  Error ", (string)_LastError);
           }        
        }
    else
        {
        
        for(int i = OrdersTotal() - 1; (bool)i--; )    
           {
            if(OrderSelect(i, SELECT_BY_POS) && OrderMagicNumber() == 666 && OrderType() == 0)
                {

                ResetLastError();
                
                if(OrderClose(OrderTicket(), OrderLots(), ::NormalizeDouble(t.bid, _Digits), 0))
                    ExpertRemove();
                
                else
                    {
                    Print("\ncloseB: Error in BUY close trade request  Error ", (string)_LastError);
                    }                    

                } 
           }            
        }
    }
}  

I don’t know how to minimise everything, so it’s a bit of a faff

Thanks.