Libraries: mt4R for new MQL4 - page 2

New comment
 

Thanks for fixing it! Works great! One more minor change is required though:

// assign string to variable given by name
procedure RAssignString(AHandle: LongInt; AVariable: PWideChar; AValue: PChar (should also be PWideChar?)); stdcall;
begin
  if isValid(AHandle) then
    TRConsole(AHandle).AssignString(WideStringToString(AVariable, CP_ACP), WideStringToString(AValue, CP_ACP));
end;
 

Thanks for fixing it! Works great! One more minor change is required though:

// assign string to variable given by name
procedure RAssignString(AHandle: LongInt; AVariable: PWideChar; AValue: PChar (should also be PWideChar?)); stdcall;
begin
  if isValid(AHandle) then
    TRConsole(AHandle).AssignString(WideStringToString(AVariable, CP_ACP), WideStringToString(AValue, CP_ACP));
end;
 
TJmclovin:
It crashes when trying to execute 
Rf("times",times);


Thanks for your bug report!

From the investigation, the array processing in RAssingStringVector is not correctly ported to new MQL4.

I've updated the DLL, so please get the latest version from GitHub.

In this version, DLL-hardcoded minor version number updated to 4, so please also copy MQL4/Include/mt4R.mqh.

 
TJmclovin:
It crashes when trying to execute 
Rf("times",times);


Thanks for your bug report!

From the investigation, the array processing in RAssingStringVector is not correctly ported to new MQL4.

I've updated the DLL, so please get the latest version from GitHub.

In this version, DLL-hardcoded minor version number updated to 4, so please also copy MQL4/Include/mt4R.mqh.

 
TJmclovin:

Thanks for fixing it! Works great! One more minor change is required though:

// assign string to variable given by name
procedure RAssignString(AHandle: LongInt; AVariable: PWideChar; AValue: PChar (should also be PWideChar?)); stdcall;
begin
  if isValid(AHandle) then
    TRConsole(AHandle).AssignString(WideStringToString(AVariable, CP_ACP), WideStringToString(AValue, CP_ACP));
end;


Thanks for bug report, I've fixed at v1.4.0-SNAPSHOT-b5.

Please update the dll and the include file, because of minor version number is changed from before b3.

 
TJmclovin:

Thanks for fixing it! Works great! One more minor change is required though:

// assign string to variable given by name
procedure RAssignString(AHandle: LongInt; AVariable: PWideChar; AValue: PChar (should also be PWideChar?)); stdcall;
begin
  if isValid(AHandle) then
    TRConsole(AHandle).AssignString(WideStringToString(AVariable, CP_ACP), WideStringToString(AValue, CP_ACP));
end;


Thanks for bug report, I've fixed at v1.4.0-SNAPSHOT-b5.

Please update the dll and the include file, because of minor version number is changed from before b3.

 

Excellent job! Thanks for the instant fixes :) !!!

Two more things:

  • RGetInteger: AExpression: PChar should be PWideChar and subsequently Result := TRConsole(AHandle).GetInteger(WideStringToString(AExpression, CP_ACP))
  • RGetBool: Same as above :)

Again, thank your very much !

EDIT: Next time I'll just open an issue at your repo if you don't mind. I don't want to spam the comments section here ;)

 

Excellent job! Thanks for the instant fixes :) !!!

Two more things:

  • RGetInteger: AExpression: PChar should be PWideChar and subsequently Result := TRConsole(AHandle).GetInteger(WideStringToString(AExpression, CP_ACP))
  • RGetBool: Same as above :)

Again, thank your very much !

EDIT: Next time I'll just open an issue at your repo if you don't mind. I don't want to spam the comments section here ;)

 
TJmclovin:

Excellent job! Thanks for the instant fixes :) !!!

Two more things:

  • RGetInteger: AExpression: PChar should be PWideChar and subsequently Result := TRConsole(AHandle).GetInteger(WideStringToString(AExpression, CP_ACP))
  • RGetBool: Same as above :)

Again, thank your very much !


Great thank you and I'm sorry about terrible porting quality...

I've fixed RGetBoo/RGetInteger bug at v1.4.0-SNAPSHOT-b6.


EDIT: Next time I'll just open an issue at your repo if you don't mind. I don't want to spam the comments section here ;)


I'll welcome for iissue from you if you feel to report something about this!

 
TJmclovin:

Excellent job! Thanks for the instant fixes :) !!!

Two more things:

  • RGetInteger: AExpression: PChar should be PWideChar and subsequently Result := TRConsole(AHandle).GetInteger(WideStringToString(AExpression, CP_ACP))
  • RGetBool: Same as above :)

Again, thank your very much !


Great thank you and I'm sorry about terrible porting quality...

I've fixed RGetBoo/RGetInteger bug at v1.4.0-SNAPSHOT-b6.


EDIT: Next time I'll just open an issue at your repo if you don't mind. I don't want to spam the comments section here ;)


I'll welcome for iissue from you if you feel to report something about this!

12345
New comment
Reason: