Scripts: TakeAllProfit

New comment
 

TakeAllProfit:

TakeAllProfit

Author: Lam K

 

What this thing is supposed to do?

(please, with a message, ok? )))

 
26994:

What this thing is supposed to do?

(please, with a message, ok? )))


Does exactly what the name implies ... it closes all trades that are in profit.
 
This script is wonderful it closes all the profittng trades at the same time.
 
It sometimes leaves profits on the table, I don't know if it's code or broker, but on at least one occasion, it closed three profitable orders but left a fourth order open with +13 pips. My brother says it's also a little slow, but overall I rate it above average. Thanks. JJ
 

UPDATE:

it seems to be the only takeprofit script so better than nothing but I give it an average C (6) rating because it has some flaws.

(1) it leaves some profitable trades open, so you either have to manually pop out the profitable trade(s), or reset the script by closing and re-opening the metatrader platform, and it's a little slow.

(2) it gets stuck and interferes with other operations, for example, you try to switch to timeframe 15m, it prompts with OK popup window, until you reset the script by closing and re-opening the platform.

Thanx, JJ

 
jgray110:

UPDATE:

it seems to be the only takeprofit script so better than nothing but I give it an average C (6) rating because it has some flaws.

(1) it leaves some profitable trades open, so you either have to manually pop out the profitable trade(s), or reset the script by closing and re-opening the metatrader platform, and it's a little slow.

(2) it gets stuck and interferes with other operations, for example, you try to switch to timeframe 15m, it prompts with OK popup window, until you reset the script by closing and re-opening the platform.

Thanx, JJ

This is the update been finish , But this broad deny to my update Post!

SO...

Here is the Update!

//+------------------------------------------------------------------+
//| TakeAllProfit2.mq4
//| Version 2
//|

//| Fix Bug the slow, this is using the while loop bug by MT4

//| Fix the Some Profitable not close

//| Fix the New version MT4 not working
//+------------------------------------------------------------------+

#property copyright "Copyright K Lam 2015"
#property link      "http://www.FxKillU.net/"
#property show_confirm
#include <stdlib.mqh>

#define MAGICMA  20151214
#define Version  20151214
#define Flowing 9
#define OP_CLOSEBUY  71
#define OP_CLOSESELL 72

extern string Name_Expert = "Take All Trades";
extern string PSymbol = "Any";//Any for any Symbol "USDCAD" else
extern int TakeProfitPoint = 1;//temp no use..... any profit will close the easy to take at a day inside!
extern int MiniProfit = 1; //any profit will close the easy to take at a day inside!
extern int MagicKey = 0;//fix key or 0 for any
extern int Timeout=60*1;//1 Minute

//+------------------------------------------------------------------+
//| cal the point range
//+------------------------------------------------------------------+
double GetSlippage(string XSymbol)
{
   double bid   =MarketInfo(XSymbol,MODE_BID);
   double ask   =MarketInfo(XSymbol,MODE_ASK);
   double point =MarketInfo(XSymbol,MODE_POINT);
   return((ask-bid)/point);
}

//+------------------------------------------------------------------+
//| Check Server and wait server ready
//+------------------------------------------------------------------+
bool NBusy() //Not busy
{
   int cnt=10;
   int Waitfor;
   datetime StartWait=TimeCurrent();//datetime Waitfor,StartWait=TimeCurrent();

   for(cnt=10;cnt>=0;cnt--) {//while(count>=0) { // while always delay much! do not use
      Waitfor=TimeCurrent()-StartWait;
      if(IsTradeContextBusy()) cnt=10;
         else break;
        
      if(Waitfor > Timeout) {      //if(Waitfor > timeout) break;
         Print("Server Timeout! Wait ",Timeout," seconds. TradeContext Not free.");     
         return(false);
         }
      }
  
   if(Waitfor!=0) { //Comment("\n   ",Waitfor," seconds. Wait Server TradeContext free.");
      Print(Waitfor," seconds. Wait Server TradeContext free.");
      }
return(true);
}

//+------------------------------------------------------------------+
//| script "TakeAllProfit Profit last to 0 order"
//+------------------------------------------------------------------+
int TakeAllProfit(string TPSymbol,int MKey)
{
   bool result;
   int err;
   int TPCnt; //return closed count
   int OType,TradeTick;
   double price,OrderProfitCash,RealProfit;
   string CSymbol;
  
   if(OrdersTotal()==0) return(0);  
   if(NBusy()) {Print("Trade context is busy. Please wait");}

   for(TradeTick=OrdersTotal()-1; TradeTick >=0; TradeTick--) {//count form 0       //for(TimeOut=20;TimeOut > 0;TimeOut--) if(!IsTradeAllowed()) Sleep(10);
      if(OrderSelect(TradeTick,SELECT_BY_POS,MODE_TRADES)==false) continue; //      if(OrderSelect(TradeTick,SELECT_BY_POS,MODE_TRADES)) {
     
      if((TPSymbol=="Any") ||
         (OrderSymbol()==TPSymbol && MKey == 0) ||
         (OrderSymbol()==TPSymbol && OrderMagicNumber() == MKey)) {     
     
         OrderProfitCash = OrderProfit()+OrderCommission()+OrderSwap();
         if(OrderProfitCash < MiniProfit) continue;//step out not Close
        
         OType=OrderType();
         CSymbol=OrderSymbol();
         result=true;
         if(OType==OP_BUY || OType==OP_SELL) {
            RefreshRates();
           
            if(OType==OP_BUY) price=MarketInfo(CSymbol,MODE_BID);
            if(OType==OP_SELL) price=MarketInfo(CSymbol,MODE_ASK);// Bid; // not the chart price!!price=Ask;           
           
            if(NBusy())//wait server ready
               result=OrderClose(OrderTicket(),OrderLots(),price,GetSlippage(CSymbol),CLR_NONE);
            } //not buy or sell do nothings

         if(!result) {
            err=GetLastError();
            if(!IsTesting()) Print("TakeProfit Error=",err,ErrorDescription(err)," price=",price," Slippage=",GetSlippage(CSymbol));
            //TPCnt++;
            } else {TPCnt++; err=0; RealProfit+=OrderProfit();//closed in good working
               if(!IsTesting()) Print("TakeProfit OrderProfit = ", OrderProfitCash);}
         //if(error==129 || error==135 || error==146) Sleep(100);// RefreshRates(); 138                             
         if(err==129 || err==135 || err==138 ) RefreshRates();
         }//if((TPSymbol=="Any") ||
      } //for
   if(TPCnt>0 && !IsTesting()) Print(TPCnt," Order Closed Profit @ All =",RealProfit);

return(TPCnt);
}

//+------------------------------------------------------------------+
//| Main Programe
//+------------------------------------------------------------------+
int start()
{
   int    Cnt;
   int CloseNo;
   string Staring;
  
   Staring = "Staring Take Profit, Balance: "+ AccountBalance()+" Equity: "+AccountEquity()+"Last Profit "+AccountProfit();
   Print("Staring Take Profit, Balance: ", AccountBalance()," Equity: ",AccountEquity(),"Last Profit ",AccountProfit());
  
   CloseNo=OrdersTotal();
   Cnt=TakeAllProfit(PSymbol,MagicKey);
   Print(Cnt, "Order Been Closed ");
  
   CloseNo=CloseNo-OrdersTotal();
   Print(Staring);
   Print(CloseNo," Orders Closed, Balance: ", AccountBalance()," Equity: ",AccountEquity(),"Last Profit ",AccountProfit());
  
return(0);
}
//+------------------------------------------------------------------+

 

may be you can see the logic here

https://www.mql5.com/en/code/12107

CloseMultipleOrders
CloseMultipleOrders
  • votes: 8
  • 2014.12.05
  • Nkereuwem Akan
  • www.mql5.com
A simple script to close multiple market orders.
 
Siti Latifah:

may be you can see the logic here

https://www.mql5.com/en/code/12107

Before Not working, I have been forget it, this is Really OLD!


//| Fix Bug the slow, this is using the (while loop) bug by MT4

//| Fix the Some Profitable not close

(not run at last to the 0 order in list, this is when close one order in list,need totalorder -1,but not handle inside before)

NOW Fix!

In Version 2.

Thank You!

K

 

Can anyone show me how to use this script? I attach it to mt4 but it does nothing

New comment