How does I create buy-sell signals in MT4? - MQL4 and MetaTrader 4

Mladen Rakic 2014.06.09 15:37 #2911

daytrade5:
Dear Sir MLADEN, I have been unable to find an indicator that simply plots the prior day's High and Low excluding Sundays. I have been using the attached indicator and was hoping that it could be modified to exclude Sunday's data. Thank you in advance for your assistance.

daytrade5

This should be it. Try it out : prevday_hilo_no_sunday.mq4

Files:

pdhl.gif 70 kb

prevday_hilo_no_sunday.mq4 4 kb

daytrade5 2014.06.09 15:59 #2912

mladen:
daytrade5 This should be it. Try it out : prevday_hilo_no_sunday.mq4

Mladen,

This is absolutely perfect. Thank you so much for your help.

ccjjaa 2014.06.10 05:06 #2913

Hi,

I know this is a little vague however does this effect the functions of an EA in any major way and if so what do I need to look for to rectify it? The issue is 36 Warnings of "arrays passed by reference only" is there a certain way arrays must be handled with this new MT4. Thanks for any insight on this

Suggestions for MQL syntax Help with the meaning Create your own MetaTrader

Mladen Rakic 2014.06.10 05:20 #2914

cja:
Hi, I know this is a little vague however does this effect the functions of an EA in any major way and if so what do I need to look for to rectify it? The issue is 36 Warnings of "arrays passed by reference only" is there a certain way arrays must be handled with this new MT4. Thanks for any insight on this

cja

It should not affect it since the compiler should convert it automatically

To avoid that warning simply add "&" after the array type declaration in the function declaration(so instead of "void example(double arrayPassedByReference[])" use "void example(double& arrayPassedByReference[])" )

Warning "implicit conversion from array declaration double - Where is the wrong

nevar 2014.06.10 12:32 #2915

Dear Mladen and Anyone,

Do you know how does the below code create buy-sell signals?It says ''Series array that contains open-close-high-low prices of each bar'' ''Indicator Curves created:Implements a curve of type DRAW_HISTOGRAM'' As far as I see it doesnt' repaint.

Thanks.

double W_Buffer0[];

double W_Buffer1[];

double R_Buffer0[];

double R_Buffer1[];

double S_Buffer0[];

double S_Buffer1[];

double E_Buffer0[];

double E_Buffer1[];

int R_t3_period=21;

double R_b=0.8;

extern int R_mBar=0;

double W_e1, W_e2, W_e3, W_e4, W_e5, W_e6, W_c1, W_c2, W_c3, W_c4, W_n, W_w1, W_w2, W_b2, W_b3;

double W_t3, W_shift, W_wpr, W_trig, W_t3_period, W_b, W_per, W_psel, W_pbuy;

bool R_ft=True;

double R_e1, R_e2, R_e3, R_e4, R_e5, R_e6, R_c1, R_c2, R_c3, R_c4, R_n, R_w1, R_w2, R_b2, R_b3;

double R_t3[];

int R_LoopBegin, R_shift;

int init()

{

//---- indicators

SetIndexStyle (0,DRAW_NONE);

SetIndexBuffer (0,W_Buffer0);

SetIndexEmptyValue(0,EMPTY_VALUE);

SetIndexStyle (1,DRAW_NONE);

SetIndexBuffer (1,W_Buffer1);

SetIndexEmptyValue(1,EMPTY_VALUE);

SetIndexStyle (2,DRAW_NONE);

SetIndexBuffer (2,R_Buffer0);

SetIndexEmptyValue(2,EMPTY_VALUE);

SetIndexStyle (3,DRAW_NONE);

SetIndexBuffer (3,R_Buffer1);

SetIndexEmptyValue(3,EMPTY_VALUE);

SetIndexStyle (4,DRAW_ARROW,EMPTY,2);

SetIndexArrow (4,241);

SetIndexBuffer (4,S_Buffer0);

SetIndexEmptyValue(4,EMPTY_VALUE);

SetIndexStyle (5,DRAW_ARROW,EMPTY,2);

SetIndexArrow (5,242);

SetIndexBuffer (5,S_Buffer1);

SetIndexEmptyValue(5,EMPTY_VALUE);

SetIndexStyle (6,DRAW_ARROW,EMPTY,2);

SetIndexArrow (6,251);

SetIndexBuffer (6,E_Buffer0);

SetIndexEmptyValue(6,EMPTY_VALUE);

SetIndexStyle (7,DRAW_ARROW,EMPTY,2);

SetIndexArrow (7,251);

SetIndexBuffer (7,E_Buffer1);

SetIndexEmptyValue(7,EMPTY_VALUE);

//----

return(0);

}

//+------------------------------------------------------------------+

//| Custom indicator iteration function |

//+------------------------------------------------------------------+

int start()

{

W_t3_period=8;

W_b=0.8;

W_per=21;

W_psel=-30;

W_pbuy=-70;

W_b2=W_b*W_b;

W_b3=W_b2*W_b;

W_c1=-W_b3;

W_c2=(3*(W_b2+W_b3));

W_c3=-3*(2*W_b2+W_b+W_b3);

W_c4=(1+3*W_b+W_b3+3*W_b2);

W_n=W_t3_period;

if (W_n<1) W_n=1;

W_n = 1 + 0.5*(W_n-1);

W_w1 = 2 / (W_n + 1);

W_w2 = 1 - W_w1;

if (R_mBar==0) R_LoopBegin=Bars;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars);

for(int i=0; i<R_LoopBegin; i++)

{

W_wpr=iWPR(NULL,0,W_per,i);

W_e1 = W_w1*W_wpr + W_w2*W_e1;

W_e2 = W_w1*W_e1 + W_w2*W_e2;

W_e3 = W_w1*W_e2 + W_w2*W_e3;

W_e4 = W_w1*W_e3 + W_w2*W_e4;

W_e5 = W_w1*W_e4 + W_w2*W_e5;

W_e6 = W_w1*W_e5 + W_w2*W_e6;

W_t3 = W_c1*W_e6 + W_c2*W_e5 + W_c3*W_e4 + W_c4*W_e3;

if (W_t3>=-50) W_trig=W_psel;

if (W_t3<-50) W_trig=W_pbuy;

W_Buffer0=W_t3;

W_Buffer1=W_trig;

}

if (R_mBar==0) R_LoopBegin=Bars-R_t3_period-1;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars-R_t3_period-1);

ArrayResize(R_t3, R_LoopBegin);

if (R_ft) {

R_b2=R_b*R_b;

R_b3=R_b2*R_b;

R_c1=-R_b3;

R_c2=(3*(R_b2+R_b3));

R_c3=-3*(2*R_b2+R_b+R_b3);

R_c4=(1+3*R_b+R_b3+3*R_b2);

R_n=R_t3_period;

if (R_n<1) R_n=1;

R_n=1+0.5*(R_n-1);

R_w1=2/(R_n+1);

R_w2=1-R_w1;

R_ft=False;

}

for (R_shift=R_LoopBegin; R_shift>=0; R_shift--) {

R_e1=R_w1*Close[R_shift]+R_w2*R_e1;

R_e2=R_w1*R_e1+R_w2*R_e2;

R_e3=R_w1*R_e2+R_w2*R_e3;

R_e4=R_w1*R_e3+R_w2*R_e4;

R_e5=R_w1*R_e4+R_w2*R_e5;

R_e6=R_w1*R_e5+R_w2*R_e6;

R_t3[R_shift]=R_c1*R_e6+R_c2*R_e5+R_c3*R_e4+R_c4*R_e3;

if (R_t3[R_shift+1]<=R_t3[R_shift]) R_Buffer0[R_shift]=R_t3[R_shift]; else R_Buffer0[R_shift]=0;

if (R_t3[R_shift+1]>R_t3[R_shift]) R_Buffer1[R_shift]=R_t3[R_shift]; else R_Buffer1[R_shift]=0;

}

if (R_mBar==0) R_LoopBegin=Bars-R_t3_period-1;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars-R_t3_period-1);

for (int cnt=0;cnt<=R_LoopBegin;cnt++)

{

if(R_Buffer0[cnt]>0 && R_Buffer1[cnt+1]>0 && W_Buffer0[cnt]>W_Buffer0[cnt+1] && W_Buffer0[cnt+1]>W_psel) S_Buffer0[cnt]=Low[cnt]-6*Point; else S_Buffer0[cnt]=0;

if(R_Buffer1[cnt]>0 && R_Buffer0[cnt+1]>0 && W_Buffer0[cnt]<W_Buffer0[cnt+1] && W_Buffer0[cnt+1]<W_pbuy) S_Buffer1[cnt]=High[cnt]+6*Point; else S_Buffer1[cnt]=0;

}

if (R_mBar==0) R_LoopBegin=Bars-R_t3_period-1;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars-R_t3_period-1);

for (cnt=0;cnt<=R_LoopBegin;cnt++)

{

if(W_Buffer0[cnt]W_psel) E_Buffer0[cnt]=High[cnt]+6*Point; else E_Buffer0[cnt]=0;

if(W_Buffer0[cnt]>W_pbuy && W_Buffer0[cnt+1]<W_pbuy) E_Buffer1[cnt]=Low[cnt]-6*Point; else E_Buffer1[cnt]=0;

}

Convert this into MT3 help on new developed Any questions from newcomers

Mladen Rakic 2014.06.10 12:42 #2916

nevar:
Dear Mladen and Anyone,

Do you know how does the below code create buy-sell signals?It says ''Series array that contains open-close-high-low prices of each bar'' ''Indicator Curves created:Implements a curve of type DRAW_HISTOGRAM'' As far as I see it doesnt' repaint.

Thanks.

double W_Buffer0[];

double W_Buffer1[];

double R_Buffer0[];

double R_Buffer1[];

double S_Buffer0[];

double S_Buffer1[];

double E_Buffer0[];

double E_Buffer1[];

int R_t3_period=21;

double R_b=0.8;

extern int R_mBar=0;

double W_e1, W_e2, W_e3, W_e4, W_e5, W_e6, W_c1, W_c2, W_c3, W_c4, W_n, W_w1, W_w2, W_b2, W_b3;

double W_t3, W_shift, W_wpr, W_trig, W_t3_period, W_b, W_per, W_psel, W_pbuy;

bool R_ft=True;

double R_e1, R_e2, R_e3, R_e4, R_e5, R_e6, R_c1, R_c2, R_c3, R_c4, R_n, R_w1, R_w2, R_b2, R_b3;

double R_t3[];

int R_LoopBegin, R_shift;

int init()

{

//---- indicators

SetIndexStyle (0,DRAW_NONE);

SetIndexBuffer (0,W_Buffer0);

SetIndexEmptyValue(0,EMPTY_VALUE);

SetIndexStyle (1,DRAW_NONE);

SetIndexBuffer (1,W_Buffer1);

SetIndexEmptyValue(1,EMPTY_VALUE);

SetIndexStyle (2,DRAW_NONE);

SetIndexBuffer (2,R_Buffer0);

SetIndexEmptyValue(2,EMPTY_VALUE);

SetIndexStyle (3,DRAW_NONE);

SetIndexBuffer (3,R_Buffer1);

SetIndexEmptyValue(3,EMPTY_VALUE);

SetIndexStyle (4,DRAW_ARROW,EMPTY,2);

SetIndexArrow (4,241);

SetIndexBuffer (4,S_Buffer0);

SetIndexEmptyValue(4,EMPTY_VALUE);

SetIndexStyle (5,DRAW_ARROW,EMPTY,2);

SetIndexArrow (5,242);

SetIndexBuffer (5,S_Buffer1);

SetIndexEmptyValue(5,EMPTY_VALUE);

SetIndexStyle (6,DRAW_ARROW,EMPTY,2);

SetIndexArrow (6,251);

SetIndexBuffer (6,E_Buffer0);

SetIndexEmptyValue(6,EMPTY_VALUE);

SetIndexStyle (7,DRAW_ARROW,EMPTY,2);

SetIndexArrow (7,251);

SetIndexBuffer (7,E_Buffer1);

SetIndexEmptyValue(7,EMPTY_VALUE);

//----

return(0);

}

//+------------------------------------------------------------------+

//| Custom indicator iteration function |

//+------------------------------------------------------------------+

int start()

{

W_t3_period=8;

W_b=0.8;

W_per=21;

W_psel=-30;

W_pbuy=-70;

W_b2=W_b*W_b;

W_b3=W_b2*W_b;

W_c1=-W_b3;

W_c2=(3*(W_b2+W_b3));

W_c3=-3*(2*W_b2+W_b+W_b3);

W_c4=(1+3*W_b+W_b3+3*W_b2);

W_n=W_t3_period;

if (W_n<1) W_n=1;

W_n = 1 + 0.5*(W_n-1);

W_w1 = 2 / (W_n + 1);

W_w2 = 1 - W_w1;

if (R_mBar==0) R_LoopBegin=Bars;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars);

for(int i=0; i<R_LoopBegin; i++)

{

W_wpr=iWPR(NULL,0,W_per,i);

W_e1 = W_w1*W_wpr + W_w2*W_e1;

W_e2 = W_w1*W_e1 + W_w2*W_e2;

W_e3 = W_w1*W_e2 + W_w2*W_e3;

W_e4 = W_w1*W_e3 + W_w2*W_e4;

W_e5 = W_w1*W_e4 + W_w2*W_e5;

W_e6 = W_w1*W_e5 + W_w2*W_e6;

W_t3 = W_c1*W_e6 + W_c2*W_e5 + W_c3*W_e4 + W_c4*W_e3;

if (W_t3>=-50) W_trig=W_psel;

if (W_t3<-50) W_trig=W_pbuy;

W_Buffer0=W_t3;

W_Buffer1=W_trig;

}

if (R_mBar==0) R_LoopBegin=Bars-R_t3_period-1;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars-R_t3_period-1);

ArrayResize(R_t3, R_LoopBegin);

if (R_ft) {

R_b2=R_b*R_b;

R_b3=R_b2*R_b;

R_c1=-R_b3;

R_c2=(3*(R_b2+R_b3));

R_c3=-3*(2*R_b2+R_b+R_b3);

R_c4=(1+3*R_b+R_b3+3*R_b2);

R_n=R_t3_period;

if (R_n<1) R_n=1;

R_n=1+0.5*(R_n-1);

R_w1=2/(R_n+1);

R_w2=1-R_w1;

R_ft=False;

}

for (R_shift=R_LoopBegin; R_shift>=0; R_shift--) {

R_e1=R_w1*Close[R_shift]+R_w2*R_e1;

R_e2=R_w1*R_e1+R_w2*R_e2;

R_e3=R_w1*R_e2+R_w2*R_e3;

R_e4=R_w1*R_e3+R_w2*R_e4;

R_e5=R_w1*R_e4+R_w2*R_e5;

R_e6=R_w1*R_e5+R_w2*R_e6;

R_t3[R_shift]=R_c1*R_e6+R_c2*R_e5+R_c3*R_e4+R_c4*R_e3;

if (R_t3[R_shift+1]<=R_t3[R_shift]) R_Buffer0[R_shift]=R_t3[R_shift]; else R_Buffer0[R_shift]=0;

if (R_t3[R_shift+1]>R_t3[R_shift]) R_Buffer1[R_shift]=R_t3[R_shift]; else R_Buffer1[R_shift]=0;

}

if (R_mBar==0) R_LoopBegin=Bars-R_t3_period-1;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars-R_t3_period-1);

for (int cnt=0;cnt<=R_LoopBegin;cnt++)

{

if(R_Buffer0[cnt]>0 && R_Buffer1[cnt+1]>0 && W_Buffer0[cnt]>W_Buffer0[cnt+1] && W_Buffer0[cnt+1]>W_psel) S_Buffer0[cnt]=Low[cnt]-6*Point; else S_Buffer0[cnt]=0;

if(R_Buffer1[cnt]>0 && R_Buffer0[cnt+1]>0 && W_Buffer0[cnt]<W_Buffer0[cnt+1] && W_Buffer0[cnt+1]<W_pbuy) S_Buffer1[cnt]=High[cnt]+6*Point; else S_Buffer1[cnt]=0;

}

if (R_mBar==0) R_LoopBegin=Bars-R_t3_period-1;

else R_LoopBegin=R_mBar;

R_LoopBegin=MathMin(R_LoopBegin, Bars-R_t3_period-1);

for (cnt=0;cnt<=R_LoopBegin;cnt++)

{

if(W_Buffer0[cnt]W_psel) E_Buffer0[cnt]=High[cnt]+6*Point; else E_Buffer0[cnt]=0;

if(W_Buffer0[cnt]>W_pbuy && W_Buffer0[cnt+1]<W_pbuy) E_Buffer1[cnt]=Low[cnt]-6*Point; else E_Buffer1[cnt]=0;

}

It is combining signals from t3 smoothed wpr and a simple t3

But the last part is done from future to past (something similar to sidus and solar wind) so I would be carefull when using it

Requests & Ideas Dynamic zone indicators ... Indicators with alerts/signal

vozduh92go 2014.06.14 14:18 #2917

Hello Dear Mladen. It is possible to make Step ma bars?

Mladen Rakic 2014.06.14 15:17 #2918

Air92:
Hello Dear Mladen. It is possible to make Step ma bars?

You mean bars colored depending on the color of the step ma?

vozduh92go 2014.06.14 15:31 #2919

mladen:
You mean bars colored depending on the color of the step ma?

Yes,you are right

Mladen Rakic 2014.06.14 16:16 #2920

Air92:
Yes,you are right

Air92

Posted one version here : https://www.mql5.com/en/forum/173044/page12

Coding help - page 292