i try to make an EA but i have some trouble

[[Deleted]]

hello :)

sorry for my terrible english

i try to make an ea but i have problems with icustom

i am using supertrend
https://www.mql5.com/en/code/8268
variables Nbr_Periods and Multiplier
and nonlagdot
https://www.mql5.com/en/code/8026
variables Price, Length, Displace, Filter, Color, ColorBarBack, Deviation

i have written some code but now i have trouble

here is my code

1. #include <stdlib.mqh>
2. 
   
3. extern int TrailingStop11 = 10;
4. extern int NewTakeProfit11 = 30;
5. extern int TrailingGap11 = 3;
6. extern double BuyLots9 = 0.3;
7. extern int BuyStoploss9 = 50;
8. extern int BuyTakeprofit9 = 100;
9. double gd_104 = 1.0;
10. bool gi_112 = FALSE;
11. 
    
12. int init() {
13. Comment("");
14. return (0);
15. }
16. 
    
17. int start() {
18. if (Bars < 10) {
19. Comment("Not enough bars");
20. return (0);
21. }
22. if (gi_112 == TRUE) {
23. Comment("EA Terminated.");
24. return (0);
25. }
26. OnEveryTick2();
27. return (0);
28. }
29. 
    
30. void OnEveryTick2() {
31. TrailingStop11();
32. TechnicalAnalysis2x5();
33. TechnicalAnalysis2x1();
34. }
35. 
    
36. void TrailingStop11() {
37. for (int l_pos_0 = OrdersTotal() - 1; l_pos_0 >= 0; l_pos_0--) {
38. if (OrderSelect(l_pos_0, SELECT_BY_POS, MODE_TRADES)) {
39. if (OrderSymbol() == Symbol() && OrderMagicNumber() == 1) {
40. if (OrderType() == OP_BUY && Ask - OrderOpenPrice() > TrailingStop11 * gd_104 * Point)
41. if (OrderStopLoss() < Ask - (TrailingStop11 + TrailingGap11) * gd_104 * Point) OrderModify(OrderTicket(), OrderOpenPrice(), Ask - TrailingStop11 * gd_104 * Point, Ask + (NewTakeProfit11 + TrailingStop11) * gd_104 * Point, OrderExpiration(), White);
42. if (OrderType() == OP_SELL && OrderOpenPrice() - Bid > TrailingStop11 * gd_104 * Point)
43. if (OrderStopLoss() > Bid + (TrailingStop11 + TrailingGap11) * gd_104 * Point) OrderModify(OrderTicket(), OrderOpenPrice(), Bid + TrailingStop11 * gd_104 * Point, Bid - (NewTakeProfit11 + TrailingStop11) * gd_104 * Point, OrderExpiration(), White);
44. }
45. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
46. }
47. }
48. 
    
49. void TechnicalAnalysis2x5() {
50. if (iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) > iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) && iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0) > iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0)) IfOrderDoesNotExist6();
51. }
52. 
    
53. void IfOrderDoesNotExist6() {
54. bool li_0 = FALSE;
55. for (int l_pos_4 = OrdersTotal() - 1; l_pos_4 >= 0; l_pos_4--) {
56. if (OrderSelect(l_pos_4, SELECT_BY_POS, MODE_TRADES)) {
57. if (OrderType() == OP_SELL && OrderSymbol() == Symbol() && OrderMagicNumber() == 1) li_0 = TRUE;
58. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
59. }
60. if (li_0 == FALSE) {
61. }
62. }
63. 
    
64. void TechnicalAnalysis2x1() {
65. if (iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) > iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) && iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0) > iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0)) IfOrderDoesNotExist3();
66. }
67. 
    
68. void IfOrderDoesNotExist3() {
69. bool li_0 = FALSE;
70. for (int l_pos_4 = OrdersTotal() - 1; l_pos_4 >= 0; l_pos_4--) {
71. if (OrderSelect(l_pos_4, SELECT_BY_POS, MODE_TRADES)) {
72. if (OrderType() == OP_SELL && OrderSymbol() == Symbol() && OrderMagicNumber() == 1) li_0 = TRUE;
73. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
74. }
75. if (li_0 == FALSE) IfOrderDoesNotExist7();
76. }
77. 
    
78. void IfOrderDoesNotExist7() {
79. bool li_0 = FALSE;
80. for (int l_pos_4 = OrdersTotal() - 1; l_pos_4 >= 0; l_pos_4--) {
81. if (OrderSelect(l_pos_4, SELECT_BY_POS, MODE_TRADES)) {
82. if (OrderType() == OP_BUY && OrderSymbol() == Symbol() && OrderMagicNumber() == 1) li_0 = TRUE;
83. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
84. }
85. if (li_0 == FALSE) BuyOrder9();
86. }
87. 
    
88. void BuyOrder9() {
89. bool l_bool_4;
90. int l_ticket_0 = OrderSend(Symbol(), OP_BUY, BuyLots9, Ask, 4, 0, 0, "My Expert", 1, 0, Blue);
91. if (l_ticket_0 > -1) {
92. OrderSelect(l_ticket_0, SELECT_BY_TICKET);
93. l_bool_4 = OrderModify(OrderTicket(), OrderOpenPrice(), Ask - BuyStoploss9 * gd_104 * Point, Ask + BuyTakeprofit9 * gd_104 * Point, 0, Blue);
94. if (l_bool_4 == FALSE) Print("OrderModify() error - ", ErrorDescription(GetLastError()));
95. } else Print("OrderSend() error - ", ErrorDescription(GetLastError()));
96. }
97. 
    
98. int deinit() {
99. return (0);

}



my plan
if the supertrend indicator change to uptrend (green) and the dots are blue (uptrend) > buy
if the supertrend indicator change to downtrend (red) and the dots are red (downtrend) > sell

thank you very much

[[Deleted]]

I have a problem too ... but the different is that I am not making a single EA at all ...
I have been thinking "where is my problem come from?" ... the answer is : "I can not
making an EA" ...

[rv]

Montajo wrote >>
hello :)

sorry for my terrible english

i try to make an ea but i have problems with icustom

i am using supertrend
https://www.mql5.com/en/code/8268
variables Nbr_Periods and Multiplier
and nonlagdot
https://www.mql5.com/en/code/8026
variables Price, Length, Displace, Filter, Color, ColorBarBack, Deviation

i have written some code but now i have trouble

here is my code

1. #include <stdlib.mqh>
2. 
   
3. extern int TrailingStop11 = 10;
4. extern int NewTakeProfit11 = 30;
5. extern int TrailingGap11 = 3;
6. extern double BuyLots9 = 0.3;
7. extern int BuyStoploss9 = 50;
8. extern int BuyTakeprofit9 = 100;
9. double gd_104 = 1.0;
10. bool gi_112 = FALSE;
11. 
    
12. int init() {
13. Comment("");
14. return (0);
15. }
16. 
    
17. int start() {
18. if (Bars < 10) {
19. Comment("Not enough bars");
20. return (0);
21. }
22. if (gi_112 == TRUE) {
23. Comment("EA Terminated.");
24. return (0);
25. }
26. OnEveryTick2();
27. return (0);
28. }
29. 
    
30. void OnEveryTick2() {
31. TrailingStop11();
32. TechnicalAnalysis2x5();
33. TechnicalAnalysis2x1();
34. }
35. 
    
36. void TrailingStop11() {
37. for (int l_pos_0 = OrdersTotal() - 1; l_pos_0 >= 0; l_pos_0--) {
38. if (OrderSelect(l_pos_0, SELECT_BY_POS, MODE_TRADES)) {
39. if (OrderSymbol() == Symbol() && OrderMagicNumber() == 1) {
40. if (OrderType() == OP_BUY && Ask - OrderOpenPrice() > TrailingStop11 * gd_104 * Point)
41. if (OrderStopLoss() < Ask - (TrailingStop11 + TrailingGap11) * gd_104 * Point) OrderModify(OrderTicket(), OrderOpenPrice(), Ask - TrailingStop11 * gd_104 * Point, Ask + (NewTakeProfit11 + TrailingStop11) * gd_104 * Point, OrderExpiration(), White);
42. if (OrderType() == OP_SELL && OrderOpenPrice() - Bid > TrailingStop11 * gd_104 * Point)
43. if (OrderStopLoss() > Bid + (TrailingStop11 + TrailingGap11) * gd_104 * Point) OrderModify(OrderTicket(), OrderOpenPrice(), Bid + TrailingStop11 * gd_104 * Point, Bid - (NewTakeProfit11 + TrailingStop11) * gd_104 * Point, OrderExpiration(), White);
44. }
45. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
46. }
47. }
48. 
    
49. void TechnicalAnalysis2x5() {
50. if (iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) > iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) && iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0) > iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0)) IfOrderDoesNotExist6();
51. }
52. 
    
53. void IfOrderDoesNotExist6() {
54. bool li_0 = FALSE;
55. for (int l_pos_4 = OrdersTotal() - 1; l_pos_4 >= 0; l_pos_4--) {
56. if (OrderSelect(l_pos_4, SELECT_BY_POS, MODE_TRADES)) {
57. if (OrderType() == OP_SELL && OrderSymbol() == Symbol() && OrderMagicNumber() == 1) li_0 = TRUE;
58. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
59. }
60. if (li_0 == FALSE) {
61. }
62. }
63. 
    
64. void TechnicalAnalysis2x1() {
65. if (iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) > iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) && iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0) > iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0)) IfOrderDoesNotExist3();
66. }
67. 
    
68. void IfOrderDoesNotExist3() {
69. bool li_0 = FALSE;
70. for (int l_pos_4 = OrdersTotal() - 1; l_pos_4 >= 0; l_pos_4--) {
71. if (OrderSelect(l_pos_4, SELECT_BY_POS, MODE_TRADES)) {
72. if (OrderType() == OP_SELL && OrderSymbol() == Symbol() && OrderMagicNumber() == 1) li_0 = TRUE;
73. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
74. }
75. if (li_0 == FALSE) IfOrderDoesNotExist7();
76. }
77. 
    
78. void IfOrderDoesNotExist7() {
79. bool li_0 = FALSE;
80. for (int l_pos_4 = OrdersTotal() - 1; l_pos_4 >= 0; l_pos_4--) {
81. if (OrderSelect(l_pos_4, SELECT_BY_POS, MODE_TRADES)) {
82. if (OrderType() == OP_BUY && OrderSymbol() == Symbol() && OrderMagicNumber() == 1) li_0 = TRUE;
83. } else Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
84. }
85. if (li_0 == FALSE) BuyOrder9();
86. }
87. 
    
88. void BuyOrder9() {
89. bool l_bool_4;
90. int l_ticket_0 = OrderSend(Symbol(), OP_BUY, BuyLots9, Ask, 4, 0, 0, "My Expert", 1, 0, Blue);
91. if (l_ticket_0 > -1) {
92. OrderSelect(l_ticket_0, SELECT_BY_TICKET);
93. l_bool_4 = OrderModify(OrderTicket(), OrderOpenPrice(), Ask - BuyStoploss9 * gd_104 * Point, Ask + BuyTakeprofit9 * gd_104 * Point, 0, Blue);
94. if (l_bool_4 == FALSE) Print("OrderModify() error - ", ErrorDescription(GetLastError()));
95. } else Print("OrderSend() error - ", ErrorDescription(GetLastError()));
96. }
97. 
    
98. int deinit() {
99. return (0);

}



my plan
if the supertrend indicator change to uptrend (green) and the dots are blue (uptrend) > buy
if the supertrend indicator change to downtrend (red) and the dots are red (downtrend) > sell

thank you very much

supertrend has two colored lines, buffer 1 and buffer 2. You need to access both and compare.
Look iCustom for to access the buffers then you will find out when they change from uptrend to downtrend

[[Deleted]]

Hi there,

I have never used custom indicators, but a quick scan of the code reveals the following :-

Have a look at this statement on line 50

iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) > iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0)

What is the point of this, as it is comparing something to itself? The second part of the statments should be different to the first part in some way else this statment will ALWAYS result in false. For example :-

if (1 > 1) {Do_This}

will always be false and the "Do_This" routine will never ever be executed.

Also just a comment on your coding.....I am not one to judge as I am still learning, but I would imagine that it would be better to avoid calling functions from within functions. Where possible, create a function to do a specific task(preferably only 1) and use the result of that function to branch off from a central control point rather than dashing from place to place.

I would rather have the program flow look something like this :-

if (TechnicalAnalysis2x5() == true)IfOrderDoesNotExist6();
//======================Other Code========================


//===================End Other Code=======================
bool TechnicalAnalysis2x5() 
{
     if (iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) > iCustom(NULL, 0, "SuperTrend", 1, 1, 1, 0) &&                             //check SuperTrend
         iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0) > iCustom(NULL, 0, "nonlagdot", 1, 1, 1, 1, 1, 1, 1, 1, 0)){  //confirm nonlagdot 
         return(true);
     }
     return(false);//returns false if the icustom indications fails
}//end bool TechnicalAnalysis2x5() 

One more thing, you need to Normalise your doubles(Stoploss & Takeprofit) in the OrderModify routine, or you also headed for more problems.

Hope it helps.

[pipsfighter]

i guess that the nonlagdot should work with manual trading only that the NLD value shift returns same number with nol and 1 value shift

that is to avoid the work to quote incoming number with the value shift request

[Simon Gniadkowski]

pipsfighter:

i guess that the nonlagdot should work with manual trading only that the NLD value shift returns same number with nol and 1 value shift

that is to avoid the work to quote incoming number with the value shift request

Do you expect a reply from the OP after 3 years ? please do not dredge up old threads/posts without a very good reason.

Thread started - 2010.03.22