help fineturn EA - Online Trading - MQL4 and MetaTrader 4

Ronaldo 2009.03.09 23:57 #1

delcor wrote >>

can some one help me Fine tune a EA please

it can do better - all i see it buy and sell in the wrong places

Do you want to explain your strategy? We need to check if it is coded according to the stated strategy before we can finetune it.

If the codes are correct and we are getting poor trades from the EA, then the strategy is at fault? Is the strategy working well from manual trading?

Please help - "Market [Branch closed!] EURUSD - "Hedging" in Forex trading

Rudolph Brits 2009.03.10 07:26 #2

ronaldosim:

Do you want to explain your strategy? We need to check if it is coded according to the stated strategy before we can finetune it.

If the codes are correct and we are getting poor trades from the EA, then the strategy is at fault? Is the strategy working well from manual trading?

thank you for comeing back

the strategy is - it must only buy or sell when ema cross. there is a setting that works well and if it only buy and sell on the crosses it will take profit

i have tied it as it is but it does not buy on the cross of the 2 ema's

it must close open order and buy when short ema cross the long ema and the other way round. at this stage i want it only to do that.

then we can do the 2nd stage. no money management at this stage. i am new to programing but want to learn more

can u help me

as it is it do the job on the eur/usd 15 and1h tf - but not enough

EA Help Error 130 Putting an object anchored

Ronaldo 2009.03.10 07:47 #3

delcor wrote >>

thank you for comeing back

the strategy is - it must only buy or sell when ema cross. there is a setting that works well and if it only buy and sell on the crosses it will take profit

i have tied it as it is but it does not buy on the cross of the 2 ema's

it must close open order and buy when short ema cross the long ema and the other way round. at this stage i want it only to do that.

then we can do the 2nd stage. no money management at this stage. i am new to programing but want to learn more

can u help me

as it is it do the job on the eur/usd 15 and1h tf - but not enough

i suspect so; for EMA crosses your code is incorrect

Ema=iMA(NULL,0,ShortEma,LongEma,MODE_EMA,PRICE_CLOSE,0);

you need two iMA each for the longema and shortema

SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);

LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);

SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);

LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);

and to check for cross

if (SEMA1>LEMA1 && SEMA2<LEMA2) send buy order

and for sell

if (SEMA1<LEMA1 && SEMA2>LEMA2) send sell order

help with argument Difference between this 2 Lesson 13 - Your

Rudolph Brits 2009.03.10 12:45 #4

ronaldosim:

i suspect so; for EMA crosses your code is incorrect

Ema=iMA(NULL,0,ShortEma,LongEma,MODE_EMA,PRICE_CLOSE,0);

you need two iMA each for the longema and shortema

SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);

LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);

SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);

LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);

and to check for cross

if (SEMA1>LEMA1 && SEMA2<LEMA2) send buy order

and for sell

if (SEMA1<LEMA1 && SEMA2>LEMA2) send sell order

ok so the

SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);

LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);

SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);

LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);

must be placed in the "check for open orders conditions - below "get moving average"

and the "

if (SEMA1>LEMA1 && SEMA2<LEMA2) send buy order" where ?

also the LEMA1 AND LEMA2 must I defined at the top

still new in this

my skype is delcor59 if you want to skype me

thanks for your help

help with argument Difference between this 2 help with tralling stop

Ronaldo 2009.03.10 13:50 #5

delcor wrote >>

ok so the

SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);

LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);

SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);

LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);

must be placed in the "check for open orders conditions - below "get moving average"

and the "

if (SEMA1>LEMA1 && SEMA2<LEMA2) send buy order" where ?

also the LEMA1 AND LEMA2 must I defined at the top

still new in this

my skype is delcor59 if you want to skype me

thanks for your help

something like this modifying fr yr own codes....

void CheckForOpen()
{
double Ema;
int res;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
Ema=iMA(NULL,0,ShortEma,LongEma,MODE_EMA,PRICE_CLOSE,0);
double SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);
double LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);
double SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);
double LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);

//---- sell conditions
// if(Open[1]>Ema && Close[1]<Ema)
if (SEMA1<LEMA1 && SEMA2>LEMA2)
{
res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,0,0,"",MAGICMA,0,Red);
return;
}
//---- buy conditions
// if(Open[1]<Ema && Close[1]>Ema)
if (SEMA1>LEMA1 && SEMA2<LEMA2)
{
res=OrderSend(Symbol(),OP_BUY,LotsOptimized(),Ask,3,0,0,"",MAGICMA,0,Blue);
return;
}
//----
}

void CheckForClose()
{
double Ema;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
Ema=iMA(NULL,0,ShortEma,LongEma,MODE_EMA,PRICE_CLOSE,0);
double SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);
double LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);
double SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);
double LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);
//----
for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
//---- check order type
if(OrderType()==OP_BUY)
{
// if(Open[1]>Ema && Close[1]<Ema)
if (SEMA1<LEMA1 && SEMA2>LEMA2) OrderClose(OrderTicket(),OrderLots(),Bid,3,White);
break;
}
if(OrderType()==OP_SELL)
{
// if(Open[1]<Ema && Close[1]>Ema)
if (SEMA1>LEMA1 && SEMA2<LEMA2) OrderClose(OrderTicket(),OrderLots(),Ask,3,White);
break;
}
}
//----
}

help with tralling stop help with argument How to define

Rudolph Brits 2009.03.10 14:26 #6

ronaldosim:

something like this modifying fr yr own codes....

void CheckForOpen()
{
double Ema;
int res;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
Ema=iMA(NULL,0,ShortEma,LongEma,MODE_EMA,PRICE_CLOSE,0);
double SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);
double LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);
double SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);
double LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);

//---- sell conditions
// if(Open[1]>Ema && Close[1]<Ema)
if (SEMA1<LEMA1 && SEMA2>LEMA2)
{
res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,0,0,"",MAGICMA,0,Red);
return;
}
//---- buy conditions
// if(Open[1]<Ema && Close[1]>Ema)
if (SEMA1>LEMA1 && SEMA2<LEMA2)
{
res=OrderSend(Symbol(),OP_BUY,LotsOptimized(),Ask,3,0,0,"",MAGICMA,0,Blue);
return;
}
//----
}

void CheckForClose()
{
double Ema;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
Ema=iMA(NULL,0,ShortEma,LongEma,MODE_EMA,PRICE_CLOSE,0);
double SEMA1=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,1);
double LEMA1=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,1);
double SEMA2=iMA(NULL,0,ShortEma,0,MODE_EMA,PRICE_CLOSE,2);
double LEMA2=iMA(NULL,0,LongEma,0,MODE_EMA,PRICE_CLOSE,2);
//----
for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
//---- check order type
if(OrderType()==OP_BUY)
{
// if(Open[1]>Ema && Close[1]<Ema)
if (SEMA1<LEMA1 && SEMA2>LEMA2) OrderClose(OrderTicket(),OrderLots(),Bid,3,White);
break;
}
if(OrderType()==OP_SELL)
{
// if(Open[1]<Ema && Close[1]>Ema)
if (SEMA1>LEMA1 && SEMA2<LEMA2) OrderClose(OrderTicket(),OrderLots(),Ask,3,White);
break;
}
}
//----
}

thank you again

some thing is not right. when i back test the Ea it show only buys and no sells

Ronaldo 2009.03.10 14:43 #7

delcor wrote >>

thank you again

some thing is not right. when i back test the Ea it show only buys and no sells

noticed that depending on which order is fired first ie buy or sell, once the cross starts you fire an order and when the opposite cross you close the order; in yr start() when u check for existence of market order, u will prevent the one of the order type never to fire ie when u start with buy it will always be buy; when u start with a sell order, it will always be a sell order; take out that check condition

OrderOpenTime & OrderCloseBy Coding help Error 130

Rudolph Brits 2009.03.10 14:51 #8

ronaldosim:

noticed that depending on which order is fired first ie buy or sell, once the cross starts you fire an order and when the opposite cross you close the order; in yr start() when u check for existence of market order, u will prevent the one of the order type never to fire ie when u start with buy it will always be buy; when u start with a sell order, it will always be a sell order; take out that check condition

are your refering to the check condition at the bottom of the EA

//+------------------------------------------------------------------+
//| Start function |
//+------------------------------------------------------------------+
void start()
{
//---- check for history and trading
if(Bars<100 || IsTradeAllowed()==false) return;
//---- calculate open orders by current symbol
if(CalculateCurrentOrders(Symbol())==0) CheckForOpen();
else CheckForClose();
//----

}

because there is also

void CheckForOpen()

void CheckForClose()

[ARCHIVE] Any rookie question, Not referenced Phoenix 2007 (new thread)

Rudolph Brits 2009.03.10 15:41 #9

delcor:

are your refering to the check condition at the bottom of the EA

//+------------------------------------------------------------------+
//| Start function |
//+------------------------------------------------------------------+
void start()
{
//---- check for history and trading
if(Bars<100 || IsTradeAllowed()==false) return;
//---- calculate open orders by current symbol
if(CalculateCurrentOrders(Symbol())==0) CheckForOpen();
else CheckForClose();
//----

}

because there is also

void CheckForOpen()

void CheckForClose()

tell me is there a test system on the EA programing to show you step for step what happens when this EA runs

Ronaldo 2009.03.10 16:09 #10

delcor wrote >>

are your refering to the check condition at the bottom of the EA

//+------------------------------------------------------------------+
//| Start function |
//+------------------------------------------------------------------+
void start()
{
//---- check for history and trading
if(Bars<100 || IsTradeAllowed()==false) return;
//---- calculate open orders by current symbol
if(CalculateCurrentOrders(Symbol())==0) CheckForOpen();
else CheckForClose();
//----

}

because there is also

void CheckForOpen()

void CheckForClose()

if(Bars<100 || IsTradeAllowed()==false) return;
//---- calculate open orders by current symbol
CheckForOpen();
CheckForClose();
//----