Bug in CExpertMoney::CheckOpenShort?

[lori]

In the below code, if no price is specified the code will use the market ask price.

Surely this should be the bid if we're going short?

double CExpertMoney::CheckOpenShort(double price, double sl)
{
    if(m_symbol == NULL)
    {
        return(0.0);
    }
    //---
    double lot;
    if(price == 0.0)
    {
        lot = m_account.MaxLotCheck(m_symbol.Name(), ORDER_TYPE_SELL, m_symbol.Ask(), m_percent); // <--- Here, should it not be m_symbol.Bid() ?
    }
    else
    {
        lot = m_account.MaxLotCheck(m_symbol.Name(), ORDER_TYPE_SELL, price, m_percent);
    }
    if(lot < m_symbol.LotsMin())
    {
        return(0.0);
    }
    //---
    return(m_symbol.LotsMin());
}

[phi nuts]

lori:

In the below code, if no price is specified the code will use the market ask price.

Surely this should be the bid if we're going short?

Yes it is a bug, it should Bid - not Ask. I hope one of the admins reply.

Good one lori 

[lori]

How does one bring this to the attention of the guys at MetaQuotes?

How many people are using this for their trading with a bug in it, and still, almost a month later, nothing has been done about it once I've brought it up?

[phi nuts]

lori:

How does one bring this to the attention of the guys at MetaQuotes?

How many people are using this for their trading with a bug in it, and still, almost a month later, nothing has been done about it once I've brought it up?

I know, and its makes me wonder :D. I saw the announcement for build 722, but it did not mention about this !

I will write to service desk with the screenshot of CExpertMoney::CheckOpenShort and CheckOpenLong, see what they say ... on Monday :(

[phi nuts]

phi.nuts:

I know, and its makes me wonder :D. I saw the announcement for build 722, but it did not mention about this !

I will write to service desk with the screenshot of CExpertMoney::CheckOpenShort and CheckOpenLong, see what they say ... on Monday :(

MQ says bug is fixed, wait for the next build.

BTW, I think we can fix that ourselves :D. 

[lori]

Yeah, I have fixed it in my code when I found it - I posted this to be of help for others