dynamic lotsize not working. help! - page 5

New comment
 
Michael Charles Schefe #:
isnt the if line made redundant by the first loop? ie i>= 0

i >= 0 is basically "standard" for iterating "backward" in a loop, where 0 is the merely the first number of the count, so no.

Also, remember that in that custom function, nothing runs unless PositionsTotal() >= 1.

 
Ryan L Johnson #:

Also, remember that in that custom function, nothing runs unless PositionsTotal() >= 1.

hence my query about it being redundant.
 
Michael Charles Schefe #:
[H]ence my query about it being redundant.

I just saw your EDIT. In your code, you have no limiting condition so yes, your code will run on every tick.

// Global Enviro - preprocessor
#define total (ushort)PositionsTotal()
// OnTick
//   ushort total0 = total;
// custom function call(ed) -only when already confirmed that a position is open.
   for(int k = total - 1; k >= 0; k--)
To be clear, that limiting condition can be in OnTick() just the same (together with your actual close all conditions).
 
Michael Charles Schefe #: not sure if the code i posted will show the issue in backtest, but the code is 100% same code that i have used last week and this on demo account, live charts. my dynamic lotsize is working for buy trades, but all my sell trades are the same, bigger lotsize, when most of em should be smaller 0.14. see description of my planned dynamic lotsize in a previous comment. (#14)
I really couldn't reproduce the problem in the Tester. Apparently, the EA opens BUY and SELL trades in the same way, using the first and second defined lots (no trades with the third lot). But here are some suggestions for changes for testing in a demo account:

1) Remove SetAsyncMode(true) on line 167 - I'm not convinced that this is the reason for the problem, especially since it's a demo account (and not a real one) and you report that it only occurs with SELL, but it's worth a test;

2) On line 361, when POSITION_TYPE_SELL, you modify the global variable "sym0": 
sym0 = position.Symbol();

The global "sym0" is used, for example, in the following situations:

#define ask (double)SymbolInfoDouble(sym0, SYMBOL_ASK)
#define bid (double)SymbolInfoDouble(sym0, SYMBOL_BID)
#define pnt (double)SymbolInfoDouble(sym0, SYMBOL_POINT)

In the Tester, with only one active symbol, this does not generate problems. However, in a demo account, if there is any open position of another symbol (from another instance of the EA, another EA, or manual order), "sym0" will be contaminated during the loop and will subsequently use the ask, bid, and pnt values ​​of the wrong symbol. Therefore, I think you should standardize the SELL check to be the same as the BUY check:

if(position.Symbol() == _Symbol)
{
   s4 += 1;


3) In openNewTrade(), the parameters "buy4" and "sel4" are int, but they are receiving bool values ​​(big2buy and big2sel):

// Line 549
if(openNewTrade(sigBuy, sigSel, big2buy, big2sel) >= true)

Since these values ​​become 0 or 1, the conditions "sel4 > 2" and "buy4 > 2" within openNewTrade() are always false. That is, the third lot (iStart3Lots) is never reached - neither for buy nor for sell. I think you should pass "totalsel" and "totalbuy" (which are integers and increment):

openNewTrade(sigBuy, sigSel, totalbuy, totalsel)


4) The variables "buyMxg" and "buyMng" are being initialized incorrectly (lines 288-289):

selMxg = buyMng = 0;
buyMxg = selMng = DBL_MAX;

This way, the comparisons "position.PriceOpen() > buyMxg" and "position.PriceOpen() < buyMng" are never true - so "buyMxg" and "buyMng" are never updated. I think you should correct it to:

selMxg = buyMxg = 0;
buyMng = selMng = DBL_MAX;


5) To facilitate the identification of possible future errors during demo testing, add a Print statement right before the lot calculation in openNewTrade(), within the SELL block:

PrintFormat("SELL trigger | s4=%d | b4=%d | total=%d | sym0=%s | _Symbol=%s", s4, b4, PositionsTotal(), sym0, _Symbol);


That's all for now... Happy testing! 😊

 
Vinicius Pereira De Oliveira #:

That's all for now... Happy testing! 😊

well! WOW WEEE! thanks a lot mate! only read half of it so far, busy with day job, but will do the sym0 change tonight, around 8 hours from now. and it makes sense, that I will make the change on the ea that is trading, rather than a new ea. thanks a lot! i will also add a if tester line before the setAsynch just because it is another fast mod. i will read the rest in 6 hours from now!

after reading point 3, i feel dumb. so i changed that as it was set to the wrong variable, instead of big2buy, big3sel, these should have been totalbuy, totalsel, and the above mentioned mods. will read the remainder tonight in 6 hours.

thanks again. i am surprised that it was even working on buy trades!

 
agreed with all your points! Initialising of the variables was wrong also, so i have modified them as you said. like i said, i feel dumb. I would blame it on drinking and coding, but i dont think that i was drinking when i was coding!
12345
New comment