help me correct it

mt4 money 2023.02.02 13:05

#property indicator_chart_window
#property indicator_buffers 3
#property indicator_color1 Red
#property indicator_color2 Blue
#property indicator_color3 Green

double PSAR[];
double IKH[];
double BB[];
double RSI[];
double MACD[];
double STO[];
double ADX[];
double CCI[];
double Buy[];
double Sell[];

int OnInit()
{
   IndicatorBuffers(3);
   SetIndexBuffer(0, Buy);
   SetIndexBuffer(1, Sell);
   SetIndexBuffer(2, PSAR);
   return(INIT_SUCCEEDED);
}

int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
{
   int i, counted_bars = IndicatorCounted();

   if(counted_bars < 0) return(-1);
   if(counted_bars > 0) counted_bars--;

   if(counted_bars >= rates_total) return(0);

   // Calculate Parabolic SAR
   double sar = iParabolicSAR(NULL, 0, 0.02, 0.2, counted_bars);
   PSAR[counted_bars] = sar;

   // Calculate Ichimoku Kinko Hyo
   int ikh_tenkan = 9;
   int ikh_kijun = 26;
   int ikh_senkou = 52;
   double tenkan = iIchimoku(NULL, 0, ikh_tenkan, ikh_kijun, ikh_senkou, MODE_TENKANSEN, counted_bars);
   double kijun = iIchimoku(NULL, 0, ikh_tenkan, ikh_kijun, ikh_senkou, MODE_KIJUNSEN, counted_bars);
   double senkou = iIchimoku(NULL, 0, ikh_tenkan, ikh_kijun, ikh_senkou, MODE_SENKOUSPANA, counted_bars);
   IKH[counted_bars] = (tenkan + kijun + senkou) / 3;

   // Calculate Bollinger Bands
   int bb_period = 20;
   double bb_dev = 2.0;
   double bb_upper = iBands(NULL, 0, bb_period, bb_dev, PRICE_CLOSE, MODE_UPPER, counted_bars);
   double bb_lower = iBands(NULL, 0, bb_period, bb_dev, PRICE_CLOSE, MODE_LOWER, counted_bars);
   BB[counted_bars] = (bb_upper + bb_lower) / 2;

   // Calculate Relative Strength Index
  
   int rsi_period = 14;
   double rsi = iRSI(NULL, 0, rsi_period, PRICE_CLOSE, counted_bars);
   RSI[counted_bars] = rsi;

   // Calculate Moving Average Convergence Divergence
   int macd_fast = 12;
   int macd_slow = 26;
   int macd_signal = 9;
   double macd = iMACD(NULL, 0, macd_fast, macd_slow, macd_signal, PRICE_CLOSE, MODE_MAIN, counted_bars);
   MACD[counted_bars] = macd;

   // Calculate Stochastic Oscillator
   int sto_k_period = 14;
   int sto_d_period = 3;
   int sto_slowing = 3;
   int sto_method = MODE_SMA;
   double sto_k = iStochastic(NULL, 0, sto_k_period, sto_d_period, sto_slowing, sto_method, PRICE_CLOSE, counted_bars);
   STO[counted_bars] = sto_k;

   // Calculate Average Directional Movement Index
   int adx_period = 14;
   double adx = iADX(NULL, 0, adx_period, PRICE_CLOSE, counted_bars);
   ADX[counted_bars] = adx;

   // Calculate Commodity Channel Index
   int cci_period = 20;
   double cci = iCCI(NULL, 0, cci_period, PRICE_TYPICAL, counted_bars);
   CCI[counted_bars] = cci;

   // Calculate Buying Point
   Buy[counted_bars] = (PSAR[counted_bars] + IKH[counted_bars] + BB[counted_bars] + RSI[counted_bars] + MACD[counted_bars] + STO[counted_bars] + ADX[counted_bars] + CCI[counted_bars]) / 8;

   // Calculate Selling Point
   Sell[counted_bars] = (PSAR[counted_bars] + IKH[counted_bars] + BB[counted_bars] + RSI[counted_bars] + MACD[counted_bars] + STO[counted_bars] + ADX[counted_bars] + CCI[counted_bars]) / 8;

   return(rates_total);
}

have some error which is

'iParabolicSAR' - function not defined,

'iBands' - wrong parameters count,

'iStochastic' - wrong parameters count,

improper enumerator cannot be used,

'iADX' - wrong parameters count,

variable 'i' not used

William Roeder 2023.02.02 13:46 #1

Why did you post your MT4 question in the MT5 General section instead of the MQL4 section, (bottom of the Root page)?
General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
Next time, post in the correct place. The moderators will likely move this thread there soon.
There is no such function as “iParabolicSAR”. Perhaps you should read the manual. List of MQL4 Functions - MQL4 Reference
Read the call for iBands.
Read the call for iStochastic.
Read the call for iADX.
```
double bb_upper = iBands(NULL, 0, bb_period, bb_dev, PRICE_CLOSE, MODE_UPPER, counted_bars);
```
After the first call counted_bars will be equal to Bars and you are reading/writing after the oldest bar.

You should stop using the old event handlers (init, start, deinit) and IndicatorCounted() and start using new event handlers (OnInit, OnTick/OnCalculate, OnDeinit).
Event Handling Functions - MQL4 Reference
How to do your lookbacks correctly - MQL4 programming forum #9-14 & #19 (2016)

Issue while using iCustom Need some help with How to coding about:

Lorentzos Roussos 2023.02.02 14:18 #2

mt4 money:

have some error which is

The lines for sell and buy are identical .

The stochastic was missing the mode (main or signal) and the stochastic price is STO_CLOSECLOSE or STO_HIGHLOW .
The ParabolicSar is the iSAR in mt4
The adx also needed MODE_MAIN or PLUS_DI MINUS_DI
There was no loop for the iteration through bars
You must also deflect the amount of bars equivalent to the number of required bars to exist for the calculation to be viable (although i think this is handled automatically now)
The parameters for the indicators could be inputs so i placed them on top
You needed more buffers for the calculation of all indicators , and 3 plots per the display

Now i'm curious if you feed this back to chatGPT and instruct it that this would be the correct form , (after you plug in the calculation for the sell[]) , will it learn ? (if this is the case can you actually send it to chatgpt and report on its response here ? thanks)

All this assumes you wanted it for mt4 . 😇

#property indicator_chart_window
#property indicator_plots 3
#property indicator_buffers 10
#property indicator_color1 clrRed
#property indicator_color2 clrBlue
#property indicator_color3 clrGreen
#property strict
input int ikh_tenkan = 9;
input int ikh_kijun = 26;
input int ikh_senkou = 52;
input int bb_period = 20;
input double bb_dev = 2.0;
input int rsi_period = 14;
input int macd_fast = 12;
input int macd_slow = 26;
input int macd_signal = 9;
input int sto_k_period = 14;
input int sto_d_period = 3;
input int sto_slowing = 3;
input int sto_method = MODE_SMA;
input int adx_period = 14;
input int cci_period = 20;

double PSAR[];
double IKH[];
double BB[];
double RSI[];
double MACD[];
double STO[];
double ADX[];
double CCI[];
double Buy[];
double Sell[];

int deflect=0;
int OnInit()
{
   SetIndexBuffer(0, Buy);
   SetIndexBuffer(1, Sell);
   SetIndexBuffer(2, PSAR);
   int co=3;
   SetIndexBuffer(co,IKH);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;
   SetIndexBuffer(co,BB);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;
   SetIndexBuffer(co,RSI);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;
   SetIndexBuffer(co,MACD);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;
   SetIndexBuffer(co,STO);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;
   SetIndexBuffer(co,ADX);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;
   SetIndexBuffer(co,CCI);SetIndexStyle(co,DRAW_NONE,EMPTY,EMPTY,clrNONE);co++;

   deflect=MathMax(MathMax(ikh_tenkan,ikh_kijun),ikh_senkou);   
   deflect=MathMax(deflect,bb_period);
   deflect=MathMax(deflect,rsi_period);
   deflect=MathMax(deflect,macd_slow);
   deflect=MathMax(deflect,macd_signal);
   deflect=MathMax(deflect,sto_k_period*sto_d_period);
   deflect=MathMax(deflect,adx_period);
   deflect=MathMax(deflect,cci_period);
   return(INIT_SUCCEEDED);
}

int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
{
int new_bars=rates_total-prev_calculated;
int from=new_bars-deflect-2;
if(new_bars>=1&&new_bars<deflect){
  from=new_bars;
  }
  for(int i=from;i>=1;i--)
  {
   // Calculate Parabolic SAR
   double sar = iSAR(NULL, 0, 0.02, 0.2, i);
   PSAR[i] = sar;

   // Calculate Ichimoku Kinko Hyo
   double tenkan = iIchimoku(NULL, 0, ikh_tenkan, ikh_kijun, ikh_senkou, MODE_TENKANSEN, i);
   double kijun = iIchimoku(NULL, 0, ikh_tenkan, ikh_kijun, ikh_senkou, MODE_KIJUNSEN, i);
   double senkou = iIchimoku(NULL, 0, ikh_tenkan, ikh_kijun, ikh_senkou, MODE_SENKOUSPANA, i);
   IKH[i] = (tenkan + kijun + senkou) / 3;

   // Calculate Bollinger Bands

   double bb_upper = iBands(NULL, 0, bb_period, bb_dev,0, PRICE_CLOSE, MODE_UPPER, i);
   double bb_lower = iBands(NULL, 0, bb_period, bb_dev,0, PRICE_CLOSE, MODE_LOWER, i);
   BB[i] = (bb_upper + bb_lower) / 2;

   // Calculate Relative Strength Index
  

   double rsi = iRSI(NULL, 0, rsi_period, PRICE_CLOSE, i);
   RSI[i] = rsi;

   // Calculate Moving Average Convergence Divergence

   double macd = iMACD(NULL, 0, macd_fast, macd_slow, macd_signal, PRICE_CLOSE, MODE_MAIN, i);
   MACD[i] = macd;

   // Calculate Stochastic Oscillator

   double sto_k = iStochastic(NULL, 0, sto_k_period, sto_d_period, sto_slowing, sto_method,STO_CLOSECLOSE,MODE_MAIN,i);
   STO[i] = sto_k;

   // Calculate Average Directional Movement Index

   double adx = iADX(NULL, 0, adx_period, PRICE_CLOSE,MODE_MAIN,i);
   ADX[i] = adx;

   // Calculate Commodity Channel Index

   double cci = iCCI(NULL, 0, cci_period, PRICE_TYPICAL, i);
   CCI[i] = cci;

   // Calculate Buying Point
   Buy[i] = (PSAR[i] + IKH[i] + BB[i] + RSI[i] + MACD[i] + STO[i] + ADX[i] + CCI[i]) / 8;

   // Calculate Selling Point
   Sell[i] = (PSAR[i] + IKH[i] + BB[i] + RSI[i] + MACD[i] + STO[i] + ADX[i] + CCI[i]) / 8;
  
  }

   return(rates_total);
}

HELP! Custom Bullish/Bearish Pattern Any questions from newcomers Use iFractal to place

mt4 money 2023.02.02 16:40 #3

Lorentzos Roussos #:

The lines for sell and buy are identical .

The stochastic was missing the mode (main or signal) and the stochastic price is STO_CLOSECLOSE or STO_HIGHLOW .
The ParabolicSar is the iSAR in mt4
The adx also needed MODE_MAIN or PLUS_DI MINUS_DI
There was no loop for the iteration through bars
You must also deflect the amount of bars equivalent to the number of required bars to exist for the calculation to be viable (although i think this is handled automatically now)
The parameters for the indicators could be inputs so i placed them on top
You needed more buffers for the calculation of all indicators , and 3 plots per the display

All this assumes you wanted it for mt4 . 😇

int sto_k_period = 14;

int sto_d_period = 3;

int sto_slowing = 3;

int sto_method = MODE_SMA;

double sto_k = iStochastic(NULL, 0, sto_k_period, sto_d_period, sto_slowing, sto_method,STO_CLOSECLOSE,MODE_MAIN,i);

STO[i] = sto_k;

if i put like this, it will have

possible use of uninitialized variable 'i'

how to solve it??

actually, if coding like this it is ok???

Stochastic based EA MQL4 Learning This has got me

William Roeder 2023.02.02 16:45 #4

mt4 money #: how to solve it??

Don't use the uninitialized variable “i”, initialize it first.
Don't double post! You already had this thread open.
General rules and best pratices of the Forum. - General - MQL5 programming forum (2017)

Lorentzos Roussos 2023.02.02 16:51 #5

mt4 money #:

int sto_k_period = 14;

int sto_d_period = 3;

int sto_slowing = 3;

int sto_method = MODE_SMA;

double sto_k = iStochastic(NULL, 0, sto_k_period, sto_d_period, sto_slowing, sto_method,STO_CLOSECLOSE,MODE_MAIN,i);

STO[i] = sto_k;

if i put like this, it will have

possible use of uninitialized variable 'i'

how to solve it??

actually, if coding like this it is ok???

Imagine the file you have opened is the "global scope" , and inside each function you have "the function scope".

If you -for example- remove the input words from the indicator parameters in the example i shared , then you will have your indicator parameters available for the calculations but the user wont be able to adjust them (you wont need to declare them in the oncalculate function that is)

Then when it comes to i , where is it running ? Where are you placing that code ?

If you changed the stochastic in your code to have STO_CLOSECLOSE,MODE_MAIN and i , then no it wont work .

The OnCalculate is telling you 2 things when it runs .

How many candles exist on the chart (rates_total)

And how many of them OnCalculate (the indicator) has processed so far.

So the first time it runs it will tell you "i have 100 candles and have processed 0 of them"

So you will have to loop inside those 100 candles and perform your operations . That is what "i" could be .

So unlike trading view , you have to iterate , it does not apply your calculations to all past candles

Is it possible to Questions from Beginners MQL5 I have been working

mt4 money 2023.02.02 17:03 #6

William Roeder #:

Don't use the uninitialized variable “i”, initialize it first.
Don't double post! You already had this thread open.
General rules and best pratices of the Forum. - General - MQL5 programming forum (2017)

how initialize

mt4 money 2023.02.02 17:13 #7

Lorentzos Roussos #:

Imagine the file you have opened is the "global scope" , and inside each function you have "the function scope".

Then when it comes to i , where is it running ? Where are you placing that code ?

If you changed the stochastic in your code to have STO_CLOSECLOSE,MODE_MAIN and i , then no it wont work .

The OnCalculate is telling you 2 things when it runs .

How many candles exist on the chart (rates_total)

And how many of them OnCalculate (the indicator) has processed so far.

So the first time it runs it will tell you "i have 100 candles and have processed 0 of them"

So you will have to loop inside those 100 candles and perform your operations . That is what "i" could be .

So unlike trading view , you have to iterate , it does not apply your calculations to all past candles

i see and thank you help me correct it thanks if yiu want use it go ahead

mt4 money 2023.02.02 17:48 #8

it have a line inside, actually is which coding line???

Lorentzos Roussos 2023.02.02 18:04 #9

mt4 money #:
it have a line inside, actually is which coding line???

I don't understand , sorry

mt4 money 2023.02.02 18:06 #10

Lorentzos Roussos #:

I don't understand , sorry

in the chart window have a line ，how you coding it

Files:

16753611717805621531683202513288.jpg 5547 kb

1 2

New comment