Discussion of article "The Player of Trading Based on Deal History" - page 2

New comment
 
For some reason my Expert Advisor doesn't work, it parses the history then goes on to create a balance and then the alerts fly out where it says there is no data on the symbol....history is all downloaded, what is the reason? I also tried to feed reports from the trading history of the EA also parses then goes the process of balance creation and then the EA crashes and nothing happens...In the files folder after all the actions are created Excel files in which everything seems to be normal.
 
arbuz:
For some reason my Expert Advisor doesn't work, it parses the history then goes on to create a balance and then the alerts fly out where it says there is no data on the symbol....history is all downloaded, what is the reason? I also tried to feed reports from the trading history of the Expert Advisor also parses then goes the process of balance creation and then the EA crashes and nothing happens...In the files folder after all the actions are created Excel files in which everything seems to be normal.

Verify this symbol by hand using this algorithm



  3. Make sure that the required section of history for all instruments participating in the trading report is available on the M1 timeframe. To do this, manually open the required chart of TF M1, set the vertical line and using the Ctrl+B command or from the context menu List of objects, through properties, change the date of the vertical line to the date of the start of trading.
  4. Then press the "Show" button. If there are no quotes, there are two possible reasons. Either the quotes are not downloaded, or the "Max. bars in window" parameter is set too small. Bars in the window" in the context menu Service->Settings->Charts.
 

Thanks for the tip, I want to try the player in work, but two of four files in the archive are not compiled - Player Report and Report Parser mt4 shows a couple of errors.

2 question - will the player work together with a pre-installed EA?

 
vspexp:

Thanks for the tip, I want to try the player in work, but two of four files in the archive are not compiled - Player Report and Report Parser mt4 shows a couple of errors.

2nd question - will the player work together with a pre-installed EA?

You should check it, it was a long time ago, maybe there were some changes in the language that are critical for the code.

The player works on the basis of a standard report, no matter what it was generated by tester or MT.

 
Urain:

You should check it, it was a long time ago, maybe there were some changes critical for the code in the language.

The code in Structur_File.mqh (ushort type->ushort m_type) has been corrected in the attached article. The updated version is in the attachment.

The error started to appear after adding the check of intersection of names of class members and methods to the compiler.

It is better to use the "m_" prefix when declaring class members.

Files:
Player_History_Trades.zip  547 kb
 

When trying to compile, several errors popped up:

Errors

 
Karputov Vladimir:

When trying to compile, several errors popped up:

These are not errors, but compiler warnings that the namespace of global and local variables overlap and the programmer should be careful.

There are no errors there. Feel free to use it.

 
Nikolay Demko:

These are not errors, but compiler warnings that the namespace of global and local variables overlap and the programmer should be careful.

There are no errors there. Feel free to use it.

I always thought that every warning is a potential error or a "black swan" in the future. Could you, as the author of the article, fix the code and remove all these potential errors?
 
Karputov Vladimir:
I always thought that every warning is a potential bug or "black swan" in the future. Could you, as the author of the article, fix the code and remove all these potential errors?

To do this, we need to rename a lot of variables (on a lot of files), and after all, variable names carry some conceptual load.

What do you propose to rename variables bar, pos, time into ?

Just adding suffixes means cluttering the code and making it unreadable.

Write to servicedesk to stop the compiler from generating yellow warnings :)

You have made it convenient for you by displaying non-critical warnings for programmers to write accurately in important places, and you are not satisfied.

 

I too have everything stopping at the "create balance history" stage. It creates files for all pairs and stops. The account was opened on 22 September. On M1 all symbols have quotes from 16 September (I checked by pressing Home).

Tried the code from the post Automated-Trading - no changes.

123
New comment