Review order modification and error impact

Tretyakov Rostyslav 2021.09.26 11:56 #16251

EVGENII SHELIPOV #:

Nothing has changed.

Change everything...

//+----------------------------------------------------------------------------+
void ClosseMinMaxOrders()
  {
   int slipp = MarketInfo(_Symbol,MODE_SPREAD)*2;
   int minTicket=GetOrderTicket(0);
   int maxTicket=GetOrderTicket(1);
   for(int i = OrdersTotal()-1; i>=0; i--)
     {
      if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
        {
         if (OrderClose(maxTicket, OrderLots(), Bid, slipp)&&OrderClose(minTicket, OrderLots(), Bid, slipp))
            Print("Максимальный и минимальный ордера на покупку успешно закрыты!");
         else
            Print("Не удалось закрыть максимальный и минимальный ордера на покупку!",GetLastError());
        }
     }
  }
//+----------------------------------------------------------------------------+
//| Калькуляция профита максимального и минимального ордера в сетке            |
//+----------------------------------------------------------------------------+
double CalculiteProfit()
  {
   double minProfit = 0, maxProfit = 0;
   for(int i = OrdersTotal()-1; i>=0; i--)
     {
      if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
        {
         if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
           {
            if(OrderTicket() == GetOrderTicket(0))
               minProfit = OrderProfit();
            if(OrderTicket() == GetOrderTicket(1))
               maxProfit = OrderProfit();
           }
        }
     }
   return(minProfit+maxProfit);
  }
//+----------------------------------------------------------------------------+
//| Номер тикета                                                               |
//| 0-минимального ордера в сетке                                              |
//| 1-максимального ордера в сетке                                             |
//+----------------------------------------------------------------------------+
int GetOrderTicket(int tick=-1)
   {
   int min_ticket = INT_MAX;
   int max_ticket = 0;
   int result=-1;
      {
      for (int cnt = OrdersTotal() - 1; cnt >= 0; cnt--) 
         {
         if(OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES))
            {
            if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic) 
               {
               if (OrderType() == OP_BUY || OrderType() == OP_SELL)
                  {
                  if(OrderTicket() < min_ticket)
                     min_ticket = OrderTicket();
                  if(OrderTicket() > max_ticket) 
                     max_ticket = OrderTicket();
                  }
               }
            }
         }
      }
   if(tick==0) {result=min_ticket;} else
   if(tick==1) {result=max_ticket;} else {result=-1;}
   return(result);
   }
//+----------------------------------------------------------------------------+

Tretyakov Rostyslav 2021.09.26 12:21 #16252

EVGENII SHELIPOV #:

Nothing has changed.

Or so...

//--- global parameters
bool closeAll=false;
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
//---
   if(CalculiteProfit() > ProfitMinMaxOrders && Drawdown > DrawdownClosingMinMaxOrders)
      closeAll=true;
   ClosseMinMaxOrders()
  }
//+----------------------------------------------------------------------------+
void ClosseMinMaxOrders()
  {
   if(closeAll==true)
     {
      int slipp = MarketInfo(_Symbol,MODE_SPREAD)*2;
      int minTicket=GetOrderTicket(0);
      int maxTicket=GetOrderTicket(1);
      for(int i = OrdersTotal()-1; i>=0; i--)
        {
         if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
           {
            if (OrderClose(maxTicket, OrderLots(), Bid, slipp)&&OrderClose(minTicket, OrderLots(), Bid, slipp))
               Print("Максимальный и минимальный ордера на покупку успешно закрыты!");
            else
               Print("Не удалось закрыть максимальный и минимальный ордера на покупку!",GetLastError());
           }
        }
      closeAll=false;
     }
  }
//+----------------------------------------------------------------------------+
//| Калькуляция профита максимального и минимального ордера в сетке            |
//+----------------------------------------------------------------------------+
double CalculiteProfit()
  {
   double minProfit = 0, maxProfit = 0;
   for(int i = OrdersTotal()-1; i>=0; i--)
     {
      if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
        {
         if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
           {
            if(OrderTicket() == GetOrderTicket(0))
               minProfit = OrderProfit();
            if(OrderTicket() == GetOrderTicket(1))
               maxProfit = OrderProfit();
           }
        }
     }
   return(minProfit+maxProfit);
  }
//+----------------------------------------------------------------------------+
//| Номер тикета                                                               |
//| 0-минимального ордера в сетке                                              |
//| 1-максимального ордера в сетке                                             |
//+----------------------------------------------------------------------------+
int GetOrderTicket(int tick=-1)
   {
   int min_ticket = INT_MAX;
   int max_ticket = 0;
   int result=-1;
      {
      for (int cnt = OrdersTotal() - 1; cnt >= 0; cnt--) 
         {
         if(OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES))
            {
            if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic) 
               {
               if (OrderType() == OP_BUY || OrderType() == OP_SELL)
                  {
                  if(OrderTicket() < min_ticket)
                     {
                     min_ticket = OrderTicket();
                     }
                  if(OrderTicket() > max_ticket) 
                     {
                     max_ticket = OrderTicket();
                     }
                  }
               }
            }
         }
      }
   if(tick==0) {result=min_ticket;} else
   if(tick==1) {result=max_ticket;} else {result=-1;}
   return(result);
   }
//+----------------------------------------------------------------------------+

EVGENII SHELIPOV 2021.09.26 12:53 #16253

MakarFX #:

I gave you another function...no need to add anything

Or you can move it...

//+----------------------------------------------------------------------------+
//| Закрытие минимального и максимального ордеров                              |
//+----------------------------------------------------------------------------+
void  ClosseMinMaxOrders()
{
  int slipp = (int) MarketInfo(_Symbol,MODE_SPREAD)*2;
  for(int i = OrdersTotal()-1; i>=0; i--)
  {
     if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
     {
       if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
        {
         if (OrderType() == OP_BUY)
          {
         if (CalculiteProfit() > 0 && Drawdown > DrawdownClosingMinMaxOrders)
         (OrderClose(GetTicketMinOrder(), GetMinLotOrder(), Bid, slipp) && OrderClose(GetTicketMaxOrder(), FindLastLots(), Bid, slipp)); 
           // Print("Максимальный и минимальный ордера на покупку успешно закрыты!");
         else
              Print("Не удалось закрыть максимальный и минимальный ордера на покупку!",GetLastError());
          }   
   
        if (OrderType() == OP_SELL)
         {
        if  (CalculiteProfit() > 0 && Drawdown > DrawdownClosingMinMaxOrders)     
         (OrderClose(GetTicketMinOrder(), GetMinLotOrder(), Ask, slipp) && OrderClose(GetTicketMaxOrder(), FindLastLots(), Ask, slipp));
           // Print("Максимальный и минимальный ордера на продажу успешно закрыты!");
         else
              Print("Не удалось закрыть максимальный и минимальный ордера на продажу!",GetLastError());
         }
       } 
     }
  }
}

Tretyakov Rostyslav 2021.09.26 13:18 #16254

EVGENII SHELIPOV #:

You can delete the highlighted items

//+----------------------------------------------------------------------------+
//| Закрытие минимального и максимального ордеров                              |
//+----------------------------------------------------------------------------+
void  ClosseMinMaxOrders()
{
  int slipp = (int) MarketInfo(_Symbol,MODE_SPREAD)*2;
  for(int i = OrdersTotal()-1; i>=0; i--)
  {
     if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
     {
       if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
        {
         if (OrderType() == OP_BUY)
          {
         if (CalculiteProfit() > 0 && Drawdown > DrawdownClosingMinMaxOrders)
         (OrderClose(GetTicketMinOrder(), GetMinLotOrder(), Bid, slipp) && OrderClose(GetTicketMaxOrder(), FindLastLots(), Bid, slipp)); 
           // Print("Максимальный и минимальный ордера на покупку успешно закрыты!");
         else
              Print("Не удалось закрыть максимальный и минимальный ордера на покупку!",GetLastError());
          }   
   
        if (OrderType() == OP_SELL)
         {
        if  (CalculiteProfit() > 0 && Drawdown > DrawdownClosingMinMaxOrders)     
         (OrderClose(GetTicketMinOrder(), GetMinLotOrder(), Ask, slipp) && OrderClose(GetTicketMaxOrder(), FindLastLots(), Ask, slipp));
           // Print("Максимальный и минимальный ордера на продажу успешно закрыты!");
         else
              Print("Не удалось закрыть максимальный и минимальный ордера на продажу!",GetLastError());
         }
       } 
     }
  }
}

EVGENII SHELIPOV 2021.09.26 13:33 #16255

MakarFX #:

The highlighted can be deleted

Makar can you explain why

Tretyakov Rostyslav 2021.09.26 13:39 #16256

EVGENII SHELIPOV #:

Makar can you explain why

the "slipp" size allows you to delete an order from any direction...as long as the ticket matches

EVGENII SHELIPOV 2021.09.26 14:06 #16257

MakarFX #:

You can delete the highlighted text.

i will send you the pictures but i don't need to rewrite them, i want to know if you have any experience of this.

If there is an old average price in the order grid and the min/max order is closed then the orders are not modified if a new max order opens

 if (CountTrade() < MaxOrders)                                                           
       {
           int order_type = FindLastOrderType();
           if (order_type == OP_BUY)
           { 
              price = FindLastOrderPrice(OP_BUY);  
              if(Ask<= price - Step()*Point)
              {
                  lastlot = NormalizeDouble(GetMinLotOrder()*MathPow( MultiplierParameter, OrdersTotal()), 2);
                  ticket = OrderSend(Symbol(), OP_BUY, lastlot, Ask, slip, 0, 0, "Групповой ордер", Magic, 0, Blue);
                  if (ticket < 1)
                      Print ("Ошибка ордера на покупку");
                            ModifyOrders(OP_BUY);
              }


           }
             if (order_type == OP_SELL)
           { 
              price = FindLastOrderPrice(OP_SELL);  
              if(Bid>= price + Step()*Point)
              {
                  lastlot = NormalizeDouble(GetMinLotOrder()*MathPow( MultiplierParameter, OrdersTotal()), 2);
                  ticket = OrderSend(Symbol(), OP_SELL, lastlot, Bid, slip, 0, 0, "Групповой ордер", Magic, 0, Red);
                  if (ticket < 1)
                      Print ("Ошибка ордера на продажу!");
                            ModifyOrders(OP_SELL);
              }

If the price goes to the old average price and the order grid closes at it, we will get a loss. I had to add another modification in one place

//+----------------------------------------------------------------------------+
//| Закрытие минимального и максимального ордеров                              |
//+----------------------------------------------------------------------------+
void  ClosseMinMaxOrders()
{
  int slipp = (int) MarketInfo(_Symbol,MODE_SPREAD)*2;
  for(int i = OrdersTotal()-1; i>=0; i--)
  {
     if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
     {
       if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic)
        {
         if (OrderType() == OP_BUY)
          {
         if (CalculiteProfit() > 0 && Drawdown > DrawdownClosingMinMaxOrders)
         (OrderClose(GetTicketMinOrder(), GetMinLotOrder(), Bid, slipp) && OrderClose(GetTicketMaxOrder(), FindLastLots(), Bid, slipp));
           // Print("Максимальный и минимальный ордера на покупку успешно закрыты!");
         else
              Print("Не удалось закрыть максимальный и минимальный ордера на покупку!",GetLastError());
              ModifyOrders(OP_BUY);
          }   
   
        if (OrderType() == OP_SELL)
         {
        if  (CalculiteProfit() > 0 && Drawdown > DrawdownClosingMinMaxOrders)     
         (OrderClose(GetTicketMinOrder(), GetMinLotOrder(), Ask, slipp) && OrderClose(GetTicketMaxOrder(), FindLastLots(), Ask, slipp));
           // Print("Максимальный и минимальный ордера на продажу успешно закрыты!");
         else
              Print("Не удалось закрыть максимальный и минимальный ордера на продажу!",GetLastError());
              ModifyOrders(OP_SELL);
         }
       } 
     }
  }
}

Here is the modification function

//+----------------------------------------------------------------------------+
//| Модификация групповых ордеров                                              |
//+----------------------------------------------------------------------------+
void ModifyOrders(int otype)
{
    double avg_price, order_lots = 0;
    price = 0;
   
    for(int i = OrdersTotal()-1; i>=0; i--)
    {
       if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
       {
         if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic && OrderType() == otype)
         {
            price += OrderOpenPrice() * OrderLots();
            order_lots += OrderLots() ;
         }
       }
    }
    avg_price = NormalizeDouble(price / order_lots, Digits);
     {
     ObjectDelete(0, "AveragePriceLine");
     ObjectCreate(0,"AveragePriceLine" ,OBJ_HLINE, 0, 0, avg_price);
     ObjectSet("AveragePriceLine",OBJPROP_COLOR, Magenta);
     }
    if (otype == OP_BUY) tp = NormalizeDouble (avg_price + TakeProfitGroupOrder*Point, Digits);
    if (otype == OP_SELL) tp = NormalizeDouble (avg_price - TakeProfitGroupOrder*Point, Digits);
    
    for(int i = OrdersTotal()-1; i>=0; i--) 
    {
       if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
       {
           if(OrderSymbol() == Symbol() && OrderMagicNumber() == Magic && OrderType() == otype)
           {
               if(OrderModify(OrderTicket(), OrderOpenPrice(), 0, tp, 0))
                  Print("Ордера успешно модифицированы!");
                else Print("Ошибка модификации ордеров!");
           }
       }
    }
}

The question is how critical the errors in the log are

Need Help in using FOREX - Trends, forecasts OrderModify error 1

EVGENII SHELIPOV 2021.09.26 14:09 #16258

MakarFX #:
the "slipp" size allows you to delete an order from any direction...as long as the ticket matches

Ask or Bid price doesn't matter

Tretyakov Rostyslav 2021.09.26 14:25 #16259

EVGENII SHELIPOV #:

Ask or Bid price doesn't matter

no matter

Tretyakov Rostyslav 2021.09.26 14:27 #16260

EVGENII SHELIPOV #:

The question is how critical the errors in the logbook are

Not critical, but there is an explanation...

Any questions from newcomers on MQL4 and MQL5, help and discussion on algorithms and codes - page 1626