How to learn and code in MMLS - Expert Advisors and Automated Trading

spike thunder 2021.03.08 11:41 #11

Icham Aidibe:

The parenthesis are correctly opened at line 41 and close at line 164, but there, you are confused :

HI Icham,

Great help, thank you very much.

Great you pointed out the mistake,as i am new to MQL, this will help me learn and code in a much proper way.

thank very much

Icham Aidibe 2021.03.08 12:03 #12

spike thunder:

HI Icham,

Great help, thank you very much.

Great you pointed out the mistake,as i am new to MQL, this will help me learn and code in a much proper way.

thank very much

you welcome, that's how one learn 👍

MQL looks like the C++ so ....

if(condition) { function(); }
else { otherfunction(); }

for(int x=0;x<size;x++) { function(); }

... is a must-know.

spike thunder 2021.03.08 14:29 #13

Icham Aidibe:

you welcome, that's how one learn 👍

MQL looks like the C++ so ....

... is a must-know.

thank you

spike thunder 2021.03.08 14:32 #14

Vladimir Karputov:

First, please correct your code - move the creation of the indicator handle to OnInit (please start reading the Documentation - there are lots of examples there). After that show your code. And only then can I watch.

Sure, am already working on this and looking forward to learn some other things also.

Thank you

Gerald Masese 2021.03.16 02:44 #15

I did some cleaning for you with my little knowledge. It is running on strategy tester.

//+------------------------------------------------------------------+
//|                                                       test.mq5 |
//|                        Copyright 2021, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2021, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"

#include<Trade\Trade.mqh>
CTrade trade;

//--- input parameters
input int      iMA = 21;
input int      TakeProfit = 250;
input int      SL = 250;
input int      TrailingStop = 10;
int movingAverageDefinition;
bool bullish;
bool bearish;
//+------------------------------------------------------------------+
//|                                                       test.mq5 |
//|                        Copyright 2021, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2021, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"

#include<Trade\Trade.mqh>
CTrade trade;

//--- input parameters
input int      iMA = 21;
input int      TakeProfit = 50;
input int      SL = 1000;
input int      TrailingStop = 10;
int movingAverageDefinition;
bool bullish;
bool bearish;
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//---
movingAverageDefinition = iMA(_Symbol,_Period,21,0,MODE_EMA,PRICE_CLOSE);

bullish = iClose(_Symbol,PERIOD_CURRENT,0) > iOpen(_Symbol,PERIOD_CURRENT,0);
bearish = iClose(_Symbol,PERIOD_CURRENT,0) <  iOpen(_Symbol,PERIOD_CURRENT,0);
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {


  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()

  {
//------------(line 41)


   double myMovingAverageArray[];
   
   ArraySetAsSeries(myMovingAverageArray,true);
   CopyBuffer(movingAverageDefinition,0,0,21,myMovingAverageArray);
   double myMovingAverageValue=myMovingAverageArray[0];
   
   double Ask=NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_ASK),_Digits);
   double Bid=NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_BID),_Digits);

      // ----------------buy------------------------------------
      if(PositionsTotal()<4)
      {
      if(iClose(_Symbol,PERIOD_CURRENT,0) > iOpen(_Symbol,PERIOD_CURRENT,0) > (myMovingAverageArray[0]))
        {
         trade.Buy(0.10,NULL,Ask,(Ask-1000*_Point),(Ask+1000*_Point),NULL);
         //CheckTrailingStop();
        }
                   // return(false);

         //--------------------sell------------------------------------
           if(iClose(_Symbol,PERIOD_CURRENT,0) < iOpen(_Symbol,PERIOD_CURRENT,0) < (myMovingAverageArray[0]))

           {
            trade.Sell(0.10,NULL,Bid,(Bid+1000*_Point),(Bid-1000*_Point),NULL);
            // CheckTrailingStop();
              //return(false);

              }
            }
     } //------------------------------ (line 164
//+------------------------------------------------------------------+ //| Expert initialization function                                   | //+------------------------------------------------------------------+ int OnInit()   { //--- movingAverageDefinition = iMA(_Symbol,_Period,21,0,MODE_EMA,PRICE_CLOSE); bullish = iClose(_Symbol,PERIOD_CURRENT,0) > iOpen(_Symbol,PERIOD_CURRENT,0); bearish = iClose(_Symbol,PERIOD_CURRENT,0) <  iOpen(_Symbol,PERIOD_CURRENT,0); //---    return(INIT_SUCCEEDED);   } //+------------------------------------------------------------------+ //| Expert deinitialization function                                 | //+------------------------------------------------------------------+ void OnDeinit(const int reason)   {   } //+------------------------------------------------------------------+ //| Expert tick function                                             | //+------------------------------------------------------------------+ void OnTick()   { //------------(line 41)    double myMovingAverageArray[];       ArraySetAsSeries(myMovingAverageArray,true);    CopyBuffer(movingAverageDefinition,0,0,21,myMovingAverageArray);    double myMovingAverageValue=myMovingAverageArray[0];       double Ask=NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_ASK),_Digits);    double Bid=NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_BID),_Digits);       // ----------------buy------------------------------------       if(iClose(_Symbol,PERIOD_CURRENT,0) > iOpen(_Symbol,PERIOD_CURRENT,0) > (myMovingAverageArray[0]))         {          trade.Buy(0.10,NULL,Ask,(Ask-1000*_Point),0,NULL);          //CheckTrailingStop();         }                    // return(false);          //--------------------sell------------------------------------            if(iClose(_Symbol,PERIOD_CURRENT,0) < iOpen(_Symbol,PERIOD_CURRENT,0) < (myMovingAverageArray[0]))            {             trade.Sell(0.10,NULL,Bid,(Bid+1000*_Point),0,NULL);             // CheckTrailingStop();               //return(false);               }      } //------------------------------ (line 164

spike thunder 2021.03.18 12:22 #16

Gerald Masese:

I did some cleaning for you with my little knowledge. It is running on strategy tester.

hello Gerald,

Great thanks for your kindness and great help. I have also try it on strategy tester, indeed this is working great.

Thank you very much

William Roeder 2021.08.18 12:13 #17

bullish = iClose(_Symbol,PERIOD_CURRENT,0) > iOpen(_Symbol,PERIOD_CURRENT,0);
bearish = iClose(_Symbol,PERIOD_CURRENT,0) <  iOpen(_Symbol,PERIOD_CURRENT,0);

Don't try to use any price or server related functions in OnInit (or on load or in OnTimer before you've received a tick), as there may be no connection/chart yet:

Terminal starts.
Indicators/EAs are loaded. Static and globally declared variables are initialized. (Do not depend on a specific order.)
OnInit is called.
For indicators OnCalculate is called with any existing history.
Human may have to enter password, connection to server begins.
New history is received, OnCalculate called again.
New tick is received, OnCalculate/OnTick is called. Now TickValue, TimeCurrent, account information and prices are valid.

Chart data loaded? trying to draw horizontal After trade opened, i

Faycal Zaidi 2023.04.05 22:46 #18

Hello guys, plz can someone help with this two errors and one wornings

error 1: '{' - unbalanced parentheses

void OnTick() {

Error 2:

'}' - unexpected end of program

// Close all open trades

CloseAll();

}

Warnings :

truncation of constant value

Best regards ):

Files:

Test_problem_1.PNG 3 kb

Test_problem_2.PNG 3 kb

Error script Im getting 2 errors How to fix unexpected

William Roeder 2023.04.06 00:33 #19

Faycal Zaidi #: s, plz can someone help with this two errors and one wornings

Do you really expect an answer? There are no mind readers here and our crystal balls are cracked.
How To Ask Questions The Smart Way. (2004)
Be precise and informative about your problem
Always post all relevant code (using Code button) or attach the source file.
Don't Hijack other threads for your off-topic post. Next time, make your own, new, thread.

Off-topic posts Please help me, thank Unknow data/symbols in the

Nampé Antonin 2023.04.30 17:26 #20

Hello team, I urgently need your help for this problem which I am sure is very small for you, so please solve it for me, it’s nice!

Files:

Capture_d2scran_p1114w.png 190 kb

Capture_dakcran_n11152.png 179 kb

'}' - unexpected end of program test.mq5 164 1 and '{' - unbalanced parentheses test.mq5 41 1 - page 2