OrderModify not working

New comment
 

I am using this code to test my order modify function but is not working and it is returning false. Please what could be the problem. I am still learning. Thanks for your kind help.

//+------------------------------------------------------------------+
//|                                                  modify-test.mq4 |
//|                        Copyright 2020, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2020, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict

bool buytrue;
bool selltrue;
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//---
  
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//---
   
  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
bool isModified;
isModified = toModify();
Alert(isModified);
  
  }
//+------------------------------------------------------------------+



         
bool toModify() {
bool ModifyOrders=false;
int ticket;
double pricelevel;
   for(int i=0; i<OrdersTotal(); i++)
     {
      if(OrderSelect(i,SELECT_BY_TICKET,MODE_TRADES))
        {
         //Alert("Order Ticket = ", OrderTicket(), " Order Open Price= ", OrderOpenPrice());
         ticket=OrderTicket();
         pricelevel=OrderOpenPrice();
         if(OrderType()==OP_BUY) {
            ModifyOrders=OrderModify(ticket,pricelevel,NormalizeDouble(Bid-5000*Point,Digits),NormalizeDouble(Ask+5000*Point,Digits),0,clrBlue);
        }
         if(OrderType()==OP_SELL) {
            ModifyOrders=OrderModify(ticket,pricelevel,NormalizeDouble(Ask+5000*Point,Digits),NormalizeDouble(Bid-5000*Point,Digits),0,clrRed);
        }
        }
        }
        return ModifyOrders;
}
 
pirokele:

I am using this code to test my order modify function but is not working and it is returning false. Please what could be the problem. I am still learning. Thanks for your kind help.

try this one,not tested!

bool toModify()
  {
   int ticket;
   double pricelevel;
   for(int i=0; i<OrdersTotal(); i++)
     {
      if(!OrderSelect(i,SELECT_BY_TICKET,MODE_TRADES))break;
        {
         //Alert("Order Ticket = ", OrderTicket(), " Order Open Price= ", OrderOpenPrice());
         ticket=OrderTicket();
         pricelevel=OrderOpenPrice();
         if(OrderType()==OP_BUY)
           {
            if(!OrderModify(ticket,pricelevel,NormalizeDouble(Bid-5000*Point,Digits),NormalizeDouble(Ask+5000*Point,Digits),0,clrBlue))
              {
               Print("Failed to modify buy - error : ",GetLastError());
               return(false);
              }
           }
         if(OrderType()==OP_SELL)
           {
            if(!OrderModify(ticket,pricelevel,NormalizeDouble(Ask+5000*Point,Digits),NormalizeDouble(Bid-5000*Point,Digits),0,clrRed))
              {
               Print("Failed to modify sell - error : ",GetLastError());
               return(false);
              }
           }
        }
     }
   return(true);
  }
 
pirokele: s not working and it is returning false. Please what could be the problem 
  1. ModifyOrders=OrderModify(ticket, …

    Check your return codes, and report your errors.

    Don't look at GLE/LE unless you have an error. Don't just silence the compiler, it is trying to help you.
              What are Function return values ? How do I use them ? - MQL4 programming forum
              Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles

    Do you really expect an answer, with the information you've provided? There are no mind readers here and our crystal balls are cracked.
         How To Ask Questions The Smart Way. 2004
              Be precise and informative about your problem 

  2.     NormalizeDouble(Bid-5000*Point,Digits)
    You used NormalizeDouble, It's use is usually wrong, as it is in your case.

    1. Floating point has infinite number of decimals, it's your not understanding floating point and that some numbers can't be represented exactly. (like 1/10.)
                Double-precision floating-point format - Wikipedia, the free encyclopedia

      See also The == operand. - MQL4 programming forum

    2. Print out your values to the precision you want with DoubleToString - Conversion Functions - MQL4 Reference.

    3. SL/TP (stops) need to be normalized to tick size (not Point) — code fails on metals. (On 5Digit Broker Stops are only allowed to be placed on full pip values. How to find out in mql? - MQL4 programming forum) and abide by the limits Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial and that requires understanding floating point equality Can price != price ? - MQL4 programming forum

    4. Open price for pending orders need to be adjusted. On Currencies, Point == TickSize, so you will get the same answer, but it won't work on Metals. So do it right: Trailing Bar Entry EA - MQL4 programming forum or Bid/Ask: (No Need) to use NormalizeDouble in OrderSend - MQL4 programming forum

    5. Lot size must also be adjusted to a multiple of LotStep and check against min and max. If that is not a power of 1/10 then NormalizeDouble is wrong. Do it right.

    6. MathRound() and NormalizeDouble() are rounding in a different way. Make it explicit.
                MT4:NormalizeDouble - MQL5 programming forum
                How to Normalize - Expert Advisors and Automated Trading - MQL5 programming forum

    7. Prices you get from the terminal are already normalized.

    8. PIP, Point, or Tick are all different in general.
                What is a TICK? - MQL4 programming forum 2014.08.03

New comment